Add notification filters #66

Merged
Twyco merged 2 commits from koda/notification-filters into main 2026-05-18 23:02:59 +00:00
Contributor

Summary

  • add persisted notification filters with attribute/operator/value normalization and matching
  • expose filter configuration in project notification settings for create and edit flows
  • cover filter dispatch behavior for ticket create and ticket status change events

Verification

  • npm run build
  • APP_KEY="base64:$(php -r 'echo base64_encode(random_bytes(32));')" php artisan test tests/Feature/Models/NotificationActionTest.php tests/Feature/Notifications/ProjectNotificationActionManagementTest.php tests/Feature/Notifications/TicketCreatedNotificationDispatchTest.php tests/Feature/Notifications/TicketStatusChangedNotificationDispatchTest.php tests/Feature/Projects/ProjectNotificationSettingsControllerTest.php
  • npm run types:check
  • vendor/bin/pint --dirty --format agent
## Summary - add persisted notification filters with attribute/operator/value normalization and matching - expose filter configuration in project notification settings for create and edit flows - cover filter dispatch behavior for ticket create and ticket status change events ## Verification - npm run build - APP_KEY="base64:$(php -r 'echo base64_encode(random_bytes(32));')" php artisan test tests/Feature/Models/NotificationActionTest.php tests/Feature/Notifications/ProjectNotificationActionManagementTest.php tests/Feature/Notifications/TicketCreatedNotificationDispatchTest.php tests/Feature/Notifications/TicketStatusChangedNotificationDispatchTest.php tests/Feature/Projects/ProjectNotificationSettingsControllerTest.php - npm run types:check - vendor/bin/pint --dirty --format agent
Twyco changed target branch from koda/ticket-create-notification-action to main 2026-04-29 10:34:19 +00:00
Twyco added 1 commit 2026-04-29 10:34:19 +00:00
Koda added 1 commit 2026-04-29 10:41:56 +00:00
Merge main into notification filters
linter / quality (pull_request) Successful in 3m31s
tests / ci (8.4) (pull_request) Successful in 2m0s
ad7ab48443
Eric requested changes 2026-05-10 18:33:42 +00:00
@@ -0,0 +42,4 @@
$operator = NotificationFilterOperator::tryFrom((string) Arr::get($filter, 'operator', ''));
if ($operator === null) {
return false;
Owner

warum hier auf null und nich ' ' wenn das default val ist, oder ist weil das enum null gibt wenn nicht da

warum hier auf null und nich ' ' wenn das default val ist, oder ist weil das enum null gibt wenn nicht da
Owner

Enum::tryFrom(string) gibt null oder Enum zurück

Enum::tryFrom(string) gibt null oder Enum zurück
Twyco merged commit f4661acf1b into main 2026-05-18 23:02:59 +00:00
Twyco deleted branch koda/notification-filters 2026-05-18 23:02:59 +00:00
Sign in to join this conversation.
No Reviewers
No labels
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PetschStudios/KanbanGit#66