Twyco
changed target branch from codex/v0.5-webhook-notification/release-ticket-docs to codex/v0.5-webhook-notification/01-notification-action-foundation2026-04-22 08:32:53 +00:00
Thanks for the solid backend coverage. I found one functional UI issue: existing Discord message templates are not prefilled in edit forms, so updates can fail unless users re-enter the template each time. Requesting changes for that fix.
Thanks for the solid backend coverage. I found one functional UI issue: existing Discord message templates are not prefilled in edit forms, so updates can fail unless users re-enter the template each time. Requesting changes for that fix.
Should fix: this is a native <textarea>, so :default-value is ignored. Existing Discord templates are not prefilled in the edit form. For Discord actions, a simple metadata update can then fail validation (message_template is required) unless the user retypes the template every time. Please bind the current value with :value (or textarea content / v-model) so saved templates are loaded correctly.
Should fix: this is a native `<textarea>`, so `:default-value` is ignored. Existing Discord templates are not prefilled in the edit form. For Discord actions, a simple metadata update can then fail validation (`message_template` is required) unless the user retypes the template every time. Please bind the current value with `:value` (or textarea content / `v-model`) so saved templates are loaded correctly.
Re-review update: I re-ran this PR from a clean checkout and ran npm run build before the PHP tests. The notification-settings test suite now passes; the earlier test failure was environment/setup related and is not a defect in this PR.
The remaining functional issue is unchanged: existing Discord message_template values are not prefilled in the edit form because the textarea uses :default-value instead of a bound value (:value/v-model or textarea content).
Re-review update: I re-ran this PR from a clean checkout and ran `npm run build` before the PHP tests. The notification-settings test suite now passes; the earlier test failure was environment/setup related and is not a defect in this PR.
The remaining functional issue is unchanged: existing Discord `message_template` values are not prefilled in the edit form because the textarea uses `:default-value` instead of a bound value (`:value`/`v-model` or textarea content).
Twyco
changed target branch from codex/v0.5-webhook-notification/01-notification-action-foundation to main2026-04-24 16:38:23 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Koda
Thanks for the solid backend coverage. I found one functional UI issue: existing Discord message templates are not prefilled in edit forms, so updates can fail unless users re-enter the template each time. Requesting changes for that fix.
@@ -0,0 +543,4 @@"name="message_template"rows="4":default-value="Should fix: this is a native
<textarea>, so:default-valueis ignored. Existing Discord templates are not prefilled in the edit form. For Discord actions, a simple metadata update can then fail validation (message_templateis required) unless the user retypes the template every time. Please bind the current value with:value(or textarea content /v-model) so saved templates are loaded correctly.Here is the improvements PR: OpenSource/KanbanGit#57
Re-review update: I re-ran this PR from a clean checkout and ran
npm run buildbefore the PHP tests. The notification-settings test suite now passes; the earlier test failure was environment/setup related and is not a defect in this PR.The remaining functional issue is unchanged: existing Discord
message_templatevalues are not prefilled in the edit form because the textarea uses:default-valueinstead of a bound value (:value/v-modelor textarea content).