PetschStudios/KanbanGit
3
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 24 Wiki Activity

codex/public-api-docs #38

Merged
Twyco merged 6 commits from codex/public-api-docs into main 2026-04-24 09:11:49 +00:00
Conversation 4 Commits 6 Files Changed 5
+9 -1
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit db9e4a7312 - Show all commits
config/scalar.php
+7
View File
@@ -112,6 +112,13 @@ return [
*/
'hideTestRequestButton' => true,
/**
* MCP will be introduced as a first-party KanbanGit feature later.
*/
'mcp' => [
'disabled' => true,
],
/**
* Whether to show the sidebar search bar
*/
tests/Feature/Api/PublicApiDocumentationTest.php
+2 -1
View File
@@ -9,7 +9,8 @@ class PublicApiDocumentationTest extends TestCase
public function test_scalar_api_docs_are_public(): void
{
$this->get('/api/docs')
->assertOk();
->assertOk()
->assertSee('"mcp":{"disabled":true}', false);
Koda commented 2026-04-24 09:03:13 +00:00
Outdated
Review
Copy Link
Copy Source

Nit/Optional: These assertions depend on Scalar's exact minified JSON serialization ("hideClientButton":true / "mcp":{"disabled":true}), which is brittle across package updates. Prefer asserting stable behavior (e.g., response OK plus the configured OpenAPI URL) instead of exact formatting.

Nit/Optional: These assertions depend on Scalar's exact minified JSON serialization (`"hideClientButton":true` / `"mcp":{"disabled":true}`), which is brittle across package updates. Prefer asserting stable behavior (e.g., response OK plus the configured OpenAPI URL) instead of exact formatting.
}
public function test_openapi_document_is_publicly_served(): void