Approved for merge. Implementation matches the intended scope and keeps the application API itself protected. One Nit/Optional noted inline about brittle assertions tied to Scalar's minified JSON formatting in the new feature test.
Approved for merge. Implementation matches the intended scope and keeps the application API itself protected. One Nit/Optional noted inline about brittle assertions tied to Scalar's minified JSON formatting in the new feature test.
Nit/Optional: These assertions depend on Scalar's exact minified JSON serialization ("hideClientButton":true / "mcp":{"disabled":true}), which is brittle across package updates. Prefer asserting stable behavior (e.g., response OK plus the configured OpenAPI URL) instead of exact formatting.
Nit/Optional: These assertions depend on Scalar's exact minified JSON serialization (`"hideClientButton":true` / `"mcp":{"disabled":true}`), which is brittle across package updates. Prefer asserting stable behavior (e.g., response OK plus the configured OpenAPI URL) instead of exact formatting.
Koda
approved these changes 2026-04-24 09:04:05 +00:00
Nit/Optional: These assertions depend on Scalar's exact minified JSON serialization ("hideClientButton":true / "mcp":{"disabled":true}), which is brittle across package updates. Prefer asserting stable behavior (e.g., response OK plus the configured OpenAPI URL) instead of exact formatting.
Nit/Optional: These assertions depend on Scalar's exact minified JSON serialization (`"hideClientButton":true` / `"mcp":{"disabled":true}`), which is brittle across package updates. Prefer asserting stable behavior (e.g., response OK plus the configured OpenAPI URL) instead of exact formatting.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Koda
Approved
Approved for merge. Implementation matches the intended scope and keeps the application API itself protected. One Nit/Optional noted inline about brittle assertions tied to Scalar's minified JSON formatting in the new feature test.
@@ -0,0 +10,4 @@{$this->get('/api/docs')->assertOk()->assertSee('"hideClientButton":true', false)Nit/Optional: These assertions depend on Scalar's exact minified JSON serialization (
"hideClientButton":true/"mcp":{"disabled":true}), which is brittle across package updates. Prefer asserting stable behavior (e.g., response OK plus the configured OpenAPI URL) instead of exact formatting.Final verdict: APPROVE (findings are Nit/Optional only).
@@ -0,0 +10,4 @@{$this->get('/api/docs')->assertOk()->assertSee('"hideClientButton":true', false)Nit/Optional: These assertions depend on Scalar's exact minified JSON serialization (
"hideClientButton":true/"mcp":{"disabled":true}), which is brittle across package updates. Prefer asserting stable behavior (e.g., response OK plus the configured OpenAPI URL) instead of exact formatting.Here is the improvements PR: OpenSource/KanbanGit#54