small codestyle fixes
linter / quality (pull_request) Successful in 1m15s
tests / ci (8.4) (pull_request) Successful in 1m11s

This commit is contained in:
2026-03-26 21:52:03 +01:00
parent 5a723b1940
commit 23954e9653
4 changed files with 9 additions and 23 deletions
@@ -9,6 +9,7 @@ use App\Models\BoardColumn;
use App\Models\Project; use App\Models\Project;
use Illuminate\Http\RedirectResponse; use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Illuminate\Support\Arr;
use Illuminate\Support\Collection; use Illuminate\Support\Collection;
use Illuminate\Support\Facades\DB; use Illuminate\Support\Facades\DB;
use Inertia\Inertia; use Inertia\Inertia;
@@ -42,12 +43,13 @@ class ProjectBoardSettingsController extends Controller
$this->projectPermissionService->userCanManageProjectAccess($request->user(), $project), $this->projectPermissionService->userCanManageProjectAccess($request->user(), $project),
403, 403,
); );
$validated = $request->validated();
$desiredPosition = $request->position() ?? $project->boardColumns()->count() + 1; $desiredPosition = Arr::get($validated, 'position') ?? $project->boardColumns()->count() + 1;
$boardColumn = DB::transaction(function () use ($project, $request, $desiredPosition): BoardColumn { $boardColumn = DB::transaction(function () use ($project, $validated, $desiredPosition): BoardColumn {
$boardColumn = $project->boardColumns()->create([ $boardColumn = $project->boardColumns()->create([
'name' => $request->validated('name'), 'name' => Arr::get($validated, 'name'),
'position' => $project->boardColumns()->count() + 1, 'position' => $project->boardColumns()->count() + 1,
]); ]);
@@ -69,13 +71,14 @@ class ProjectBoardSettingsController extends Controller
$this->projectPermissionService->userCanManageProjectAccess($request->user(), $project), $this->projectPermissionService->userCanManageProjectAccess($request->user(), $project),
403, 403,
); );
$validated = $request->validated();
DB::transaction(function () use ($boardColumn, $project, $request): void { DB::transaction(function () use ($boardColumn, $project, $validated): void {
$boardColumn->update([ $boardColumn->update([
'name' => $request->validated('name'), 'name' => Arr::get($validated, 'name'),
]); ]);
$this->reorderColumns($project, $boardColumn, $request->position()); $this->reorderColumns($project, $boardColumn, Arr::get($validated, 'position'));
}); });
return to_route('projects.settings.board', $project) return to_route('projects.settings.board', $project)
@@ -27,15 +27,4 @@ class StoreBoardColumnRequest extends FormRequest
'position' => ['nullable', 'integer', 'min:1'], 'position' => ['nullable', 'integer', 'min:1'],
]; ];
} }
public function position(): ?int
{
$position = $this->validated('position');
if ($position === null) {
return null;
}
return (int) $position;
}
} }
@@ -27,9 +27,4 @@ class UpdateBoardColumnRequest extends FormRequest
'position' => ['required', 'integer', 'min:1'], 'position' => ['required', 'integer', 'min:1'],
]; ];
} }
public function position(): int
{
return (int) $this->validated('position');
}
} }
@@ -5,5 +5,4 @@ export type BoardColumnModel = {
project_id: number; project_id: number;
created_at: string; created_at: string;
updated_at: string; updated_at: string;
[key: string]: unknown;
}; };