From 23954e9653707860de7542356a54e603907b1bb0 Mon Sep 17 00:00:00 2001
From: Twyco <twyco@icloud.com>
Date: Thu, 26 Mar 2026 21:52:03 +0100
Subject: [PATCH] small codestyle fixes

---
 .../ProjectBoardSettingsController.php            | 15 +++++++++------
 app/Http/Requests/StoreBoardColumnRequest.php     | 11 -----------
 app/Http/Requests/UpdateBoardColumnRequest.php    |  5 -----
 resources/js/types/models/board-column-model.ts   |  1 -
 4 files changed, 9 insertions(+), 23 deletions(-)

diff --git a/app/Http/Controllers/ProjectBoardSettingsController.php b/app/Http/Controllers/ProjectBoardSettingsController.php
index ccb9e1a..b6aca5b 100644
--- a/app/Http/Controllers/ProjectBoardSettingsController.php
+++ b/app/Http/Controllers/ProjectBoardSettingsController.php
@@ -9,6 +9,7 @@ use App\Models\BoardColumn;
 use App\Models\Project;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
+use Illuminate\Support\Arr;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\DB;
 use Inertia\Inertia;
@@ -42,12 +43,13 @@ class ProjectBoardSettingsController extends Controller
             $this->projectPermissionService->userCanManageProjectAccess($request->user(), $project),
             403,
         );
+        $validated = $request->validated();
 
-        $desiredPosition = $request->position() ?? $project->boardColumns()->count() + 1;
+        $desiredPosition = Arr::get($validated, 'position') ?? $project->boardColumns()->count() + 1;
 
-        $boardColumn = DB::transaction(function () use ($project, $request, $desiredPosition): BoardColumn {
+        $boardColumn = DB::transaction(function () use ($project, $validated, $desiredPosition): BoardColumn {
             $boardColumn = $project->boardColumns()->create([
-                'name' => $request->validated('name'),
+                'name' => Arr::get($validated, 'name'),
                 'position' => $project->boardColumns()->count() + 1,
             ]);
 
@@ -69,13 +71,14 @@ class ProjectBoardSettingsController extends Controller
             $this->projectPermissionService->userCanManageProjectAccess($request->user(), $project),
             403,
         );
+        $validated = $request->validated();
 
-        DB::transaction(function () use ($boardColumn, $project, $request): void {
+        DB::transaction(function () use ($boardColumn, $project, $validated): void {
             $boardColumn->update([
-                'name' => $request->validated('name'),
+                'name' => Arr::get($validated, 'name'),
             ]);
 
-            $this->reorderColumns($project, $boardColumn, $request->position());
+            $this->reorderColumns($project, $boardColumn, Arr::get($validated, 'position'));
         });
 
         return to_route('projects.settings.board', $project)
diff --git a/app/Http/Requests/StoreBoardColumnRequest.php b/app/Http/Requests/StoreBoardColumnRequest.php
index 29e5a0b..212bbf2 100644
--- a/app/Http/Requests/StoreBoardColumnRequest.php
+++ b/app/Http/Requests/StoreBoardColumnRequest.php
@@ -27,15 +27,4 @@ class StoreBoardColumnRequest extends FormRequest
             'position' => ['nullable', 'integer', 'min:1'],
         ];
     }
-
-    public function position(): ?int
-    {
-        $position = $this->validated('position');
-
-        if ($position === null) {
-            return null;
-        }
-
-        return (int) $position;
-    }
 }
diff --git a/app/Http/Requests/UpdateBoardColumnRequest.php b/app/Http/Requests/UpdateBoardColumnRequest.php
index 22f0520..5de51c8 100644
--- a/app/Http/Requests/UpdateBoardColumnRequest.php
+++ b/app/Http/Requests/UpdateBoardColumnRequest.php
@@ -27,9 +27,4 @@ class UpdateBoardColumnRequest extends FormRequest
             'position' => ['required', 'integer', 'min:1'],
         ];
     }
-
-    public function position(): int
-    {
-        return (int) $this->validated('position');
-    }
 }
diff --git a/resources/js/types/models/board-column-model.ts b/resources/js/types/models/board-column-model.ts
index a4bb179..52b8f69 100644
--- a/resources/js/types/models/board-column-model.ts
+++ b/resources/js/types/models/board-column-model.ts
@@ -5,5 +5,4 @@ export type BoardColumnModel = {
     project_id: number;
     created_at: string;
     updated_at: string;
-    [key: string]: unknown;
 };