Keep guest rooms moderated and restore owner moderation
CI/CD / test_and_check_app (push) Successful in 2m22s
CI/CD / Publish immutable image (push) Successful in 1m16s

This commit is contained in:
2026-09-24 15:02:05 +02:00
parent 4dfe79ce5c
commit 33df9e49ab
6 changed files with 267 additions and 11 deletions
+57 -2
View File
@@ -2,6 +2,7 @@
use App\Enums\RoomStateChange;
use App\Events\RoomStateChanged;
use App\Jobs\RemoveAbsentPlayers;
use App\Models\Room;
use App\Models\User;
use Illuminate\Support\Facades\Event;
@@ -37,7 +38,7 @@ test('a guest automatically joins the embedded room', function () {
$player = $room->players()->sole();
expect($player->user_id)->toBeNull()
->and($player->is_moderator)->toBeFalse();
->and($player->is_moderator)->toBeTrue();
$response->assertSessionHas("room_players.{$room->id}", $player->id);
});
@@ -80,10 +81,64 @@ test('an authenticated user automatically joins the embedded room', function ()
'room_id' => $room->id,
'user_id' => $user->id,
'name' => 'Nico',
'is_moderator' => false,
'is_moderator' => true,
]);
});
test('a persistent room owner regains moderation through the embedded room', function () {
$owner = User::factory()->create();
$room = createEmbeddedRoom([
'owner_id' => $owner->id,
'is_persistent' => true,
]);
$oldModerator = $room->players()->create([
'user_id' => $owner->id,
'name' => 'Nico',
'is_moderator' => true,
'last_seen_at' => now()->subHour(),
]);
app()->call([new RemoveAbsentPlayers, 'handle']);
$this->actingAs($owner)
->withSession(["room_players.{$room->id}" => $oldModerator->id])
->get(route('embedded.room', [
'join_code' => $room->join_code,
'player_name' => 'Nico',
]))
->assertOk()
->assertInertia(fn (Assert $page) => $page
->where('currentPlayer.is_moderator', true));
expect($room->players()->where('user_id', $owner->id)->sole()->id)->not->toBe($oldModerator->id);
});
test('a persistent room owner does not take over another account session when becoming moderator', function () {
$owner = User::factory()->create();
$otherUser = User::factory()->create();
$room = createEmbeddedRoom([
'owner_id' => $owner->id,
'is_persistent' => true,
]);
$otherPlayer = $room->players()->create([
'user_id' => $otherUser->id,
'name' => 'Anna',
]);
$this->actingAs($owner)
->withSession(["room_players.{$room->id}" => $otherPlayer->id])
->get(route('embedded.room', [
'join_code' => $room->join_code,
'player_name' => 'Nico',
]))
->assertOk()
->assertInertia(fn (Assert $page) => $page
->where('currentPlayer.is_moderator', true));
expect($otherPlayer->fresh()->is_moderator)->toBeFalse()
->and($room->players()->where('user_id', $owner->id)->sole()->is_moderator)->toBeTrue();
});
test('embedded access reuses the user player and applies a changed display name', function () {
$user = User::factory()->create();
$room = createEmbeddedRoom();