708 lines
28 KiB
PHP
708 lines
28 KiB
PHP
<?php
|
|
|
|
namespace Tests\Feature\Projects;
|
|
|
|
use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
|
|
use App\Models\Project;
|
|
use App\Models\RepositoryConnection;
|
|
use App\Models\Ticket;
|
|
use App\Models\TicketFieldDefinition;
|
|
use App\Models\TicketFieldValue;
|
|
use App\Models\TicketLink;
|
|
use App\Models\TicketLinkType;
|
|
use App\Models\TicketPriority;
|
|
use App\Models\TicketWorklogEntry;
|
|
use App\Models\User;
|
|
use App\Models\UserGitConnection;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\Http;
|
|
use Inertia\Testing\AssertableInertia as Assert;
|
|
use Tests\TestCase;
|
|
|
|
class ProjectTicketControllerTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
/**
|
|
* Ensure users with view permission can open ticket details and inspect worklog history.
|
|
*/
|
|
public function test_users_with_view_permission_can_view_ticket_details(): void
|
|
{
|
|
$viewer = User::factory()->create();
|
|
$project = Project::factory()->create([
|
|
'key' => 'CORE',
|
|
]);
|
|
|
|
app(InitializeProjectTicketMetadata::class)->handle($project);
|
|
|
|
$priority = TicketPriority::factory()->for($project)->create([
|
|
'name' => 'Medium',
|
|
'position' => 1,
|
|
]);
|
|
$fieldDefinition = TicketFieldDefinition::factory()->for($project)->create([
|
|
'field_type' => 'number',
|
|
'label' => 'Story Points',
|
|
'position' => 1,
|
|
]);
|
|
$ticketLinkType = TicketLinkType::factory()->for($project)->create([
|
|
'label' => 'Relates to',
|
|
'position' => 1,
|
|
]);
|
|
|
|
$ticket = Ticket::factory()->create([
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 1,
|
|
'ticket_key' => 'CORE-1',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
|
'title' => 'Ticket detail test',
|
|
]);
|
|
$linkedTicket = Ticket::factory()->create([
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 2,
|
|
'ticket_key' => 'CORE-2',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
|
'title' => 'Linked ticket',
|
|
]);
|
|
|
|
TicketFieldValue::factory()->create([
|
|
'ticket_field_definition_id' => $fieldDefinition->id,
|
|
'ticket_id' => $ticket->id,
|
|
'value_number' => 5,
|
|
'value_user_id' => null,
|
|
]);
|
|
TicketLink::factory()->create([
|
|
'source_ticket_id' => $ticket->id,
|
|
'target_ticket_id' => $linkedTicket->id,
|
|
'ticket_link_type_id' => $ticketLinkType->id,
|
|
]);
|
|
|
|
TicketWorklogEntry::factory()->create([
|
|
'actor_id' => $viewer->id,
|
|
'entry_type' => 'updated',
|
|
'summary' => 'Updated Story Points field.',
|
|
'ticket_id' => $ticket->id,
|
|
]);
|
|
|
|
$this->syncProjectPermissions($project, $viewer, ['view']);
|
|
|
|
$this->actingAs($viewer)
|
|
->get(route('projects.tickets.show', [$project, $ticket]))
|
|
->assertOk()
|
|
->assertInertia(fn (Assert $page) => $page
|
|
->component('projects/Ticket')
|
|
->where('project.id', $project->id)
|
|
->where('ticket.ticket_key', 'CORE-1')
|
|
->where('suggestedBranchName', 'core-1-ticket-detail-test')
|
|
->where('ticket.field_values.0.ticket_field_definition.label', 'Story Points')
|
|
->where('ticket.field_values.0.value_number', 5)
|
|
->where('ticket.worklog_entries.0.actor.name', $viewer->name)
|
|
->where('linkedTickets.0.linked_ticket.ticket_key', 'CORE-2')
|
|
->where('linkedTickets.0.ticket_link_type.label', 'Relates to')
|
|
->where('repositoryBranches', [])
|
|
->where('repositoryPullRequests', [])
|
|
->where('canEditTicket', false),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Ensure ticket details expose matching branches, pull requests, and inaccessible repository links.
|
|
*/
|
|
public function test_ticket_details_include_matching_branches_pull_requests_and_inaccessible_repository_links(): void
|
|
{
|
|
Http::preventStrayRequests();
|
|
Http::fake([
|
|
'https://git.example.test/api/v1/repos/core-team/kanbangit/branches*' => Http::response([
|
|
['name' => 'CORE-1-login-form'],
|
|
['name' => 'CORE-1/fix-oauth'],
|
|
['name' => 'CORE-10-should-not-match'],
|
|
['name' => 'main'],
|
|
]),
|
|
'https://git.example.test/api/v1/repos/core-team/kanbangit/pulls*' => Http::response([
|
|
[
|
|
'number' => 42,
|
|
'title' => 'Add login form',
|
|
'state' => 'open',
|
|
'merged' => false,
|
|
'html_url' => 'https://git.example.test/core-team/kanbangit/pulls/42',
|
|
'head' => [
|
|
'ref' => 'CORE-1-login-form',
|
|
],
|
|
],
|
|
[
|
|
'number' => 43,
|
|
'title' => 'Close auth gap',
|
|
'state' => 'closed',
|
|
'merged' => true,
|
|
'html_url' => 'https://git.example.test/core-team/kanbangit/pulls/43',
|
|
'head' => [
|
|
'ref' => 'CORE-1/fix-oauth',
|
|
],
|
|
],
|
|
[
|
|
'number' => 99,
|
|
'title' => 'Other ticket change',
|
|
'state' => 'open',
|
|
'merged' => false,
|
|
'html_url' => 'https://git.example.test/core-team/kanbangit/pulls/99',
|
|
'head' => [
|
|
'ref' => 'CORE-10-should-not-match',
|
|
],
|
|
],
|
|
]),
|
|
]);
|
|
|
|
$viewer = User::factory()->create();
|
|
$project = Project::factory()->create([
|
|
'key' => 'CORE',
|
|
]);
|
|
|
|
app(InitializeProjectTicketMetadata::class)->handle($project);
|
|
|
|
$priority = TicketPriority::factory()->for($project)->create([
|
|
'name' => 'Medium',
|
|
'position' => 1,
|
|
]);
|
|
|
|
$ticket = Ticket::factory()->create([
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 1,
|
|
'ticket_key' => 'CORE-1',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
|
'title' => 'Branch detail test',
|
|
]);
|
|
|
|
RepositoryConnection::factory()->for($project)->create([
|
|
'base_url' => 'https://git.example.test',
|
|
'owner_name' => 'core-team',
|
|
'provider_repository_id' => '501',
|
|
'repository_full_name' => 'core-team/kanbangit',
|
|
'repository_name' => 'kanbangit',
|
|
'repository_url' => 'https://git.example.test/core-team/kanbangit',
|
|
]);
|
|
RepositoryConnection::factory()->for($project)->create([
|
|
'base_url' => 'https://git.other.test',
|
|
'owner_name' => 'other-team',
|
|
'provider_repository_id' => '902',
|
|
'repository_full_name' => 'other-team/mobile',
|
|
'repository_name' => 'mobile',
|
|
'repository_url' => 'https://git.other.test/other-team/mobile',
|
|
]);
|
|
|
|
UserGitConnection::factory()->for($viewer)->create([
|
|
'base_url' => 'https://git.example.test',
|
|
]);
|
|
|
|
$this->syncProjectPermissions($project, $viewer, ['view']);
|
|
|
|
$this->actingAs($viewer)
|
|
->get(route('projects.tickets.show', [$project, $ticket]))
|
|
->assertOk()
|
|
->assertInertia(fn (Assert $page) => $page
|
|
->component('projects/Ticket')
|
|
->where('suggestedBranchName', 'core-1-branch-detail-test')
|
|
->where('repositoryBranches.0.repository_connection.repository_full_name', 'core-team/kanbangit')
|
|
->has('repositoryBranches.0.branches', 2)
|
|
->where('repositoryBranches.0.branches.0.name', 'CORE-1-login-form')
|
|
->where('repositoryBranches.0.branches.1.name', 'CORE-1/fix-oauth')
|
|
->where('repositoryBranches.1.repository_connection.repository_full_name', 'other-team/mobile')
|
|
->where('repositoryBranches.1.repository_connection.has_personal_access', false)
|
|
->where('repositoryBranches.1.branches', [])
|
|
->has('repositoryPullRequests.0.pull_requests', 2)
|
|
->where('repositoryPullRequests.0.pull_requests.0.number', '42')
|
|
->where('repositoryPullRequests.0.pull_requests.0.title', 'Add login form')
|
|
->where('repositoryPullRequests.0.pull_requests.0.status', 'open')
|
|
->where('repositoryPullRequests.0.pull_requests.1.number', '43')
|
|
->where('repositoryPullRequests.0.pull_requests.1.status', 'merged')
|
|
->where('repositoryPullRequests.1.repository_connection.repository_full_name', 'other-team/mobile')
|
|
->where('repositoryPullRequests.1.repository_connection.has_personal_access', false)
|
|
->where('repositoryPullRequests.1.pull_requests', []),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Ensure updating ticket details requires the project edit permission.
|
|
*/
|
|
public function test_updating_ticket_details_requires_edit_permission(): void
|
|
{
|
|
$viewer = User::factory()->create();
|
|
$project = Project::factory()->create();
|
|
|
|
app(InitializeProjectTicketMetadata::class)->handle($project);
|
|
|
|
$priority = TicketPriority::factory()->for($project)->create([
|
|
'name' => 'Medium',
|
|
'position' => 1,
|
|
]);
|
|
|
|
$ticket = Ticket::factory()->create([
|
|
'project_id' => $project->id,
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
|
]);
|
|
|
|
$this->syncProjectPermissions($project, $viewer, ['view']);
|
|
|
|
$this->actingAs($viewer)
|
|
->patch(route('projects.tickets.update', [$project, $ticket]), [
|
|
'title' => 'Updated title',
|
|
'description' => 'Updated description',
|
|
'acceptance_criteria' => 'Updated criteria',
|
|
'blocked_comment' => $ticket->blocked_comment,
|
|
'is_blocked' => $ticket->is_blocked,
|
|
'parent_ticket_id' => $ticket->parent_ticket_id,
|
|
'ticket_type_id' => $ticket->ticket_type_id,
|
|
'ticket_priority_id' => $ticket->ticket_priority_id,
|
|
'field_values' => [],
|
|
])
|
|
->assertForbidden();
|
|
}
|
|
|
|
/**
|
|
* Ensure editing tracked ticket fields creates a worklog entry and persists field values.
|
|
*/
|
|
public function test_users_with_edit_permission_can_update_ticket_details_and_custom_fields(): void
|
|
{
|
|
$editor = User::factory()->create([
|
|
'name' => 'Editor User',
|
|
]);
|
|
$assignee = User::factory()->create([
|
|
'name' => 'Assigned User',
|
|
]);
|
|
$project = Project::factory()->create([
|
|
'key' => 'CORE',
|
|
]);
|
|
|
|
app(InitializeProjectTicketMetadata::class)->handle($project);
|
|
|
|
$lowPriority = TicketPriority::factory()->for($project)->create([
|
|
'name' => 'Low',
|
|
'position' => 1,
|
|
]);
|
|
$highPriority = TicketPriority::factory()->for($project)->create([
|
|
'name' => 'High',
|
|
'position' => 2,
|
|
]);
|
|
|
|
$assigneeField = TicketFieldDefinition::factory()->for($project)->create([
|
|
'field_type' => 'user',
|
|
'label' => 'Assignee',
|
|
'position' => 1,
|
|
]);
|
|
$storyPointsField = TicketFieldDefinition::factory()->for($project)->create([
|
|
'field_type' => 'number',
|
|
'label' => 'Story Points',
|
|
'position' => 2,
|
|
]);
|
|
|
|
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
|
|
$parentType = $project->ticketTypes()->where('system_key', 'parent')->firstOrFail();
|
|
|
|
$ticket = Ticket::factory()->create([
|
|
'acceptance_criteria' => 'Old acceptance criteria',
|
|
'description' => 'Old description',
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 1,
|
|
'ticket_key' => 'CORE-1',
|
|
'ticket_priority_id' => $lowPriority->id,
|
|
'ticket_type_id' => $taskType->id,
|
|
'title' => 'Old title',
|
|
]);
|
|
|
|
TicketFieldValue::factory()->create([
|
|
'ticket_field_definition_id' => $assigneeField->id,
|
|
'ticket_id' => $ticket->id,
|
|
'value_number' => null,
|
|
'value_user_id' => $editor->id,
|
|
]);
|
|
TicketFieldValue::factory()->create([
|
|
'ticket_field_definition_id' => $storyPointsField->id,
|
|
'ticket_id' => $ticket->id,
|
|
'value_number' => 3,
|
|
'value_user_id' => null,
|
|
]);
|
|
|
|
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
|
|
|
|
$this->actingAs($editor)
|
|
->patch(route('projects.tickets.update', [$project, $ticket]), [
|
|
'title' => 'Updated title',
|
|
'description' => 'Updated description',
|
|
'acceptance_criteria' => 'Updated acceptance criteria',
|
|
'blocked_comment' => $ticket->blocked_comment,
|
|
'is_blocked' => $ticket->is_blocked,
|
|
'parent_ticket_id' => $ticket->parent_ticket_id,
|
|
'ticket_type_id' => $parentType->id,
|
|
'ticket_priority_id' => $highPriority->id,
|
|
'field_values' => [
|
|
[
|
|
'ticket_field_definition_id' => $assigneeField->id,
|
|
'value_user_id' => $assignee->id,
|
|
],
|
|
[
|
|
'ticket_field_definition_id' => $storyPointsField->id,
|
|
'value_number' => 8,
|
|
],
|
|
],
|
|
])
|
|
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
|
|
->assertSessionHas('status', 'CORE-1 was updated.');
|
|
|
|
$this->assertDatabaseHas('tickets', [
|
|
'id' => $ticket->id,
|
|
'title' => 'Updated title',
|
|
'description' => 'Updated description',
|
|
'acceptance_criteria' => 'Updated acceptance criteria',
|
|
'ticket_type_id' => $parentType->id,
|
|
'ticket_priority_id' => $highPriority->id,
|
|
]);
|
|
|
|
$this->assertDatabaseHas('ticket_field_values', [
|
|
'ticket_id' => $ticket->id,
|
|
'ticket_field_definition_id' => $assigneeField->id,
|
|
'value_user_id' => $assignee->id,
|
|
]);
|
|
|
|
$this->assertDatabaseHas('ticket_field_values', [
|
|
'ticket_id' => $ticket->id,
|
|
'ticket_field_definition_id' => $storyPointsField->id,
|
|
'value_number' => 8.0,
|
|
]);
|
|
|
|
$this->assertDatabaseHas('ticket_worklog_entries', [
|
|
'ticket_id' => $ticket->id,
|
|
'actor_id' => $editor->id,
|
|
'entry_type' => 'updated',
|
|
'summary' => 'Updated title, description, acceptance criteria, type, priority, Assignee field, and Story Points field.',
|
|
]);
|
|
}
|
|
|
|
/**
|
|
* Ensure non-parent tickets cannot be assigned as a parent target.
|
|
*/
|
|
public function test_assigning_a_non_parent_ticket_as_parent_is_rejected(): void
|
|
{
|
|
$editor = User::factory()->create();
|
|
$project = Project::factory()->create([
|
|
'key' => 'CORE',
|
|
]);
|
|
|
|
app(InitializeProjectTicketMetadata::class)->handle($project);
|
|
|
|
$priority = TicketPriority::factory()->for($project)->create([
|
|
'name' => 'Medium',
|
|
'position' => 1,
|
|
]);
|
|
|
|
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
|
|
|
|
$candidateParent = Ticket::factory()->create([
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 1,
|
|
'ticket_key' => 'CORE-1',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $taskType->id,
|
|
'title' => 'Task ticket',
|
|
]);
|
|
|
|
$childTicket = Ticket::factory()->create([
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 2,
|
|
'ticket_key' => 'CORE-2',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $taskType->id,
|
|
'title' => 'Child ticket',
|
|
]);
|
|
|
|
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
|
|
|
|
$this->actingAs($editor)
|
|
->from(route('projects.tickets.show', [$project, $childTicket]))
|
|
->patch(route('projects.tickets.update', [$project, $childTicket]), [
|
|
'title' => $childTicket->title,
|
|
'description' => $childTicket->description,
|
|
'acceptance_criteria' => $childTicket->acceptance_criteria,
|
|
'blocked_comment' => $childTicket->blocked_comment,
|
|
'is_blocked' => $childTicket->is_blocked,
|
|
'parent_ticket_id' => $candidateParent->id,
|
|
'ticket_type_id' => $childTicket->ticket_type_id,
|
|
'ticket_priority_id' => $childTicket->ticket_priority_id,
|
|
'field_values' => [],
|
|
])
|
|
->assertRedirect(route('projects.tickets.show', [$project, $childTicket]))
|
|
->assertSessionHasErrors('parent_ticket_id');
|
|
}
|
|
|
|
/**
|
|
* Ensure parent relationships can be assigned and are written to the worklog.
|
|
*/
|
|
public function test_users_with_edit_permission_can_assign_parent_tickets(): void
|
|
{
|
|
$editor = User::factory()->create();
|
|
$project = Project::factory()->create([
|
|
'key' => 'CORE',
|
|
]);
|
|
|
|
app(InitializeProjectTicketMetadata::class)->handle($project);
|
|
|
|
$priority = TicketPriority::factory()->for($project)->create([
|
|
'name' => 'Medium',
|
|
'position' => 1,
|
|
]);
|
|
|
|
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
|
|
$parentType = $project->ticketTypes()->where('system_key', 'parent')->firstOrFail();
|
|
|
|
$parentTicket = Ticket::factory()->create([
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 1,
|
|
'ticket_key' => 'CORE-1',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $parentType->id,
|
|
'title' => 'Parent ticket',
|
|
]);
|
|
|
|
$childTicket = Ticket::factory()->create([
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 2,
|
|
'ticket_key' => 'CORE-2',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $taskType->id,
|
|
'title' => 'Child ticket',
|
|
]);
|
|
|
|
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
|
|
|
|
$this->actingAs($editor)
|
|
->patch(route('projects.tickets.update', [$project, $childTicket]), [
|
|
'title' => $childTicket->title,
|
|
'description' => $childTicket->description,
|
|
'acceptance_criteria' => $childTicket->acceptance_criteria,
|
|
'blocked_comment' => $childTicket->blocked_comment,
|
|
'is_blocked' => $childTicket->is_blocked,
|
|
'parent_ticket_id' => $parentTicket->id,
|
|
'ticket_type_id' => $childTicket->ticket_type_id,
|
|
'ticket_priority_id' => $childTicket->ticket_priority_id,
|
|
'field_values' => [],
|
|
])
|
|
->assertRedirect(route('projects.tickets.show', [$project, $childTicket]))
|
|
->assertSessionHas('status', 'CORE-2 was updated.');
|
|
|
|
$this->assertDatabaseHas('tickets', [
|
|
'id' => $childTicket->id,
|
|
'parent_ticket_id' => $parentTicket->id,
|
|
]);
|
|
|
|
$this->assertDatabaseHas('ticket_worklog_entries', [
|
|
'ticket_id' => $childTicket->id,
|
|
'actor_id' => $editor->id,
|
|
'entry_type' => 'updated',
|
|
'summary' => 'Updated parent ticket.',
|
|
]);
|
|
}
|
|
|
|
/**
|
|
* Ensure parent ticket detail pages show nested child trees.
|
|
*/
|
|
public function test_parent_ticket_detail_pages_show_nested_child_trees(): void
|
|
{
|
|
$viewer = User::factory()->create();
|
|
$project = Project::factory()->create([
|
|
'key' => 'CORE',
|
|
]);
|
|
|
|
app(InitializeProjectTicketMetadata::class)->handle($project);
|
|
|
|
$priority = TicketPriority::factory()->for($project)->create([
|
|
'name' => 'Medium',
|
|
'position' => 1,
|
|
]);
|
|
|
|
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
|
|
$parentType = $project->ticketTypes()->where('system_key', 'parent')->firstOrFail();
|
|
|
|
$rootParent = Ticket::factory()->create([
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 1,
|
|
'ticket_key' => 'CORE-1',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $parentType->id,
|
|
'title' => 'Root parent',
|
|
]);
|
|
|
|
$nestedParent = Ticket::factory()->create([
|
|
'parent_ticket_id' => $rootParent->id,
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 2,
|
|
'ticket_key' => 'CORE-2',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $parentType->id,
|
|
'title' => 'Nested parent',
|
|
]);
|
|
|
|
$directTask = Ticket::factory()->create([
|
|
'parent_ticket_id' => $rootParent->id,
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 3,
|
|
'ticket_key' => 'CORE-3',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $taskType->id,
|
|
'title' => 'Direct task',
|
|
]);
|
|
|
|
$nestedTask = Ticket::factory()->create([
|
|
'parent_ticket_id' => $nestedParent->id,
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 4,
|
|
'ticket_key' => 'CORE-4',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $taskType->id,
|
|
'title' => 'Nested task',
|
|
]);
|
|
|
|
$this->syncProjectPermissions($project, $viewer, ['view']);
|
|
|
|
$this->actingAs($viewer)
|
|
->get(route('projects.tickets.show', [$project, $rootParent]))
|
|
->assertOk()
|
|
->assertInertia(fn (Assert $page) => $page
|
|
->component('projects/Ticket')
|
|
->where('childTicketTree.0.ticket_key', $nestedParent->ticket_key)
|
|
->where('childTicketTree.0.children.0.ticket_key', $nestedTask->ticket_key)
|
|
->where('childTicketTree.1.ticket_key', $directTask->ticket_key),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Ensure blocked tickets require a blocker comment.
|
|
*/
|
|
public function test_blocked_tickets_require_a_blocker_comment_when_updating(): void
|
|
{
|
|
$editor = User::factory()->create();
|
|
$project = Project::factory()->create();
|
|
|
|
app(InitializeProjectTicketMetadata::class)->handle($project);
|
|
|
|
$priority = TicketPriority::factory()->for($project)->create([
|
|
'name' => 'Medium',
|
|
'position' => 1,
|
|
]);
|
|
$ticket = Ticket::factory()->create([
|
|
'project_id' => $project->id,
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
|
]);
|
|
|
|
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
|
|
|
|
$this->actingAs($editor)
|
|
->from(route('projects.tickets.show', [$project, $ticket]))
|
|
->patch(route('projects.tickets.update', [$project, $ticket]), [
|
|
'title' => $ticket->title,
|
|
'description' => $ticket->description,
|
|
'acceptance_criteria' => $ticket->acceptance_criteria,
|
|
'ticket_type_id' => $ticket->ticket_type_id,
|
|
'ticket_priority_id' => $ticket->ticket_priority_id,
|
|
'parent_ticket_id' => $ticket->parent_ticket_id,
|
|
'is_blocked' => true,
|
|
'blocked_comment' => '',
|
|
'field_values' => [],
|
|
])
|
|
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
|
|
->assertSessionHasErrors('blocked_comment');
|
|
|
|
$this->assertDatabaseHas('tickets', [
|
|
'id' => $ticket->id,
|
|
'is_blocked' => false,
|
|
'blocked_comment' => null,
|
|
]);
|
|
}
|
|
|
|
/**
|
|
* Ensure blocking and unblocking a ticket persists the state and logs both changes.
|
|
*/
|
|
public function test_users_with_edit_permission_can_block_and_unblock_tickets(): void
|
|
{
|
|
$editor = User::factory()->create();
|
|
$project = Project::factory()->create([
|
|
'key' => 'CORE',
|
|
]);
|
|
|
|
app(InitializeProjectTicketMetadata::class)->handle($project);
|
|
|
|
$priority = TicketPriority::factory()->for($project)->create([
|
|
'name' => 'Medium',
|
|
'position' => 1,
|
|
]);
|
|
$ticket = Ticket::factory()->create([
|
|
'project_id' => $project->id,
|
|
'sequence_number' => 1,
|
|
'ticket_key' => 'CORE-1',
|
|
'ticket_priority_id' => $priority->id,
|
|
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
|
]);
|
|
|
|
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
|
|
|
|
$this->actingAs($editor)
|
|
->patch(route('projects.tickets.update', [$project, $ticket]), [
|
|
'title' => $ticket->title,
|
|
'description' => $ticket->description,
|
|
'acceptance_criteria' => $ticket->acceptance_criteria,
|
|
'ticket_type_id' => $ticket->ticket_type_id,
|
|
'ticket_priority_id' => $ticket->ticket_priority_id,
|
|
'parent_ticket_id' => $ticket->parent_ticket_id,
|
|
'is_blocked' => true,
|
|
'blocked_comment' => 'Waiting for dependency approval.',
|
|
'field_values' => [],
|
|
])
|
|
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
|
|
->assertSessionHas('status', 'CORE-1 was updated.');
|
|
|
|
$this->assertDatabaseHas('tickets', [
|
|
'id' => $ticket->id,
|
|
'is_blocked' => true,
|
|
'blocked_comment' => 'Waiting for dependency approval.',
|
|
]);
|
|
|
|
$this->assertDatabaseHas('ticket_worklog_entries', [
|
|
'ticket_id' => $ticket->id,
|
|
'actor_id' => $editor->id,
|
|
'entry_type' => 'updated',
|
|
'summary' => 'Updated blocker comment and blocked state.',
|
|
]);
|
|
|
|
$this->actingAs($editor)
|
|
->patch(route('projects.tickets.update', [$project, $ticket]), [
|
|
'title' => $ticket->title,
|
|
'description' => $ticket->description,
|
|
'acceptance_criteria' => $ticket->acceptance_criteria,
|
|
'ticket_type_id' => $ticket->ticket_type_id,
|
|
'ticket_priority_id' => $ticket->ticket_priority_id,
|
|
'parent_ticket_id' => $ticket->parent_ticket_id,
|
|
'is_blocked' => false,
|
|
'blocked_comment' => '',
|
|
'field_values' => [],
|
|
])
|
|
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
|
|
->assertSessionHas('status', 'CORE-1 was updated.');
|
|
|
|
$this->assertDatabaseHas('tickets', [
|
|
'id' => $ticket->id,
|
|
'is_blocked' => false,
|
|
'blocked_comment' => null,
|
|
]);
|
|
|
|
$this->assertSame(
|
|
2,
|
|
TicketWorklogEntry::query()
|
|
->where('ticket_id', $ticket->id)
|
|
->where('entry_type', 'updated')
|
|
->where('summary', 'Updated blocker comment and blocked state.')
|
|
->count(),
|
|
);
|
|
}
|
|
}
|