PetschStudios/KanbanGit
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 27 Wiki Activity

delete-functions-in-request-arr-get-replacement #24

Merged
Twyco merged 9 commits from delete-functions-in-request-arr-get-replacement into main 2026-04-11 12:51:57 +00:00
Conversation 1 Commits 9 Files Changed 28
+13 -16
2 changed files with 13 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 50d787883c - Show all commits
app/Http/Controllers/ProjectController.php
+4 -16
View File
@@ -64,6 +64,7 @@ class ProjectController extends Controller
public function show(Request $request, Project $project): Response public function show(Request $request, Project $project): Response
{ {
$user = $request->user(); $user = $request->user();
abort_unless( abort_unless(
$this->projectPermissionService->userCanViewProject($user, $project), $this->projectPermissionService->userCanViewProject($user, $project),
403, 403,
@@ -112,6 +113,7 @@ class ProjectController extends Controller
Project $project, Project $project,
User $user, User $user,
): RedirectResponse { ): RedirectResponse {
$user = $request->user(); $user = $request->user();
abort_unless( abort_unless(
@@ -119,14 +121,7 @@ class ProjectController extends Controller
403, 403,
); );
$validated = $request->validated(); $this->projectPermissionService->syncUserPermissions($project, $user, $request->permissions());
Eric marked this conversation as resolved
Twyco commented 2026-04-04 09:38:32 +00:00
Review
Copy Link
Copy Source

das kann alles raus.

einfach distinct in die request packen und dann einfach nur:

$permissions = Arr::get($validated, 'permissions', [])

das kann alles raus. einfach **distinct** in die request packen und dann einfach nur: $permissions = Arr::get($validated, 'permissions', [])
$permissions = collect(Arr::get($validated, 'permissions'))
->map(fn (mixed $permission): string => (string) $permission)
->unique()
->values()
->all();
$this->projectPermissionService->syncUserPermissions($project, $user, $permissions);
return to_route('projects.access', $project) return to_route('projects.access', $project)
->with('status', "{$user->name} permissions were updated."); ->with('status', "{$user->name} permissions were updated.");
@@ -142,14 +137,7 @@ class ProjectController extends Controller
403, 403,
); );
$validated = $request->validated(); $this->projectPermissionService->syncTeamPermissions($project, $team, $request->permissions());
$permissions = collect(Arr::get($validated, 'permissions'))
->map(fn (mixed $permission): string => (string) $permission)
->unique()
->values()
->all();
$this->projectPermissionService->syncTeamPermissions($project, $team, $permissions);
return to_route('projects.access', $project) return to_route('projects.access', $project)
->with('status', "{$team->name} permissions were updated."); ->with('status', "{$team->name} permissions were updated.");
app/Http/Requests/SyncProjectPermissionsRequest.php
+9
View File
@@ -33,4 +33,13 @@ class SyncProjectPermissionsRequest extends FormRequest
]; ];
} }
public function permissions(): array
{
return collect($this->validated('permissions', []))
->map(fn (mixed $permission): string => (string) $permission)
->unique()
->values()
->all();
}
} }