PetschStudios/KanbanGit
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 27 Wiki Activity

delete-functions-in-request-arr-get-replacement #24

Merged
Twyco merged 9 commits from delete-functions-in-request-arr-get-replacement into main 2026-04-11 12:51:57 +00:00
Conversation 1 Commits 9 Files Changed 28
+18 -12
2 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2e78379b1a - Show all commits
app/Http/Controllers/ProjectController.php
+17 -4
View File
@@ -115,16 +115,22 @@ class ProjectController extends Controller
): RedirectResponse {
$user = $request->user();
abort_unless(
$this->projectPermissionService->userCanManageProjectAccess($user, $project),
403,
);
$this->projectPermissionService->syncUserPermissions($project, $user, $request->permissions());
$validated = $request->validated();
$permissions = collect(Arr::get($validated, 'permissions'))
Eric marked this conversation as resolved
Twyco commented 2026-04-04 09:38:32 +00:00
Review
Copy Link
Copy Source

das kann alles raus.

einfach distinct in die request packen und dann einfach nur:

$permissions = Arr::get($validated, 'permissions', [])

das kann alles raus. einfach **distinct** in die request packen und dann einfach nur: $permissions = Arr::get($validated, 'permissions', [])
->map(fn (mixed $permission): string => (string) $permission)
->unique()
->values()
->all();
$this->projectPermissionService->syncUserPermissions($project, $user, $permissions);
return to_route('projects.access', $project)
->with('status', "{$user->name} permissions were updated.");
->with('status', "Regular User permissions were updated.");
}
public function updateTeamPermissions(
@@ -137,7 +143,14 @@ class ProjectController extends Controller
403,
);
$this->projectPermissionService->syncTeamPermissions($project, $team, $request->permissions());
$validated = $request->validated();
$permissions = collect(Arr::get($validated, 'permissions'))
->map(fn (mixed $permission): string => (string) $permission)
->unique()
->values()
Eric marked this conversation as resolved Outdated
Twyco commented 2026-04-04 09:38:42 +00:00
Outdated
Review
Copy Link
Copy Source

selbe wie oben

selbe wie oben
->all();
$this->projectPermissionService->syncTeamPermissions($project, $team, $permissions);
return to_route('projects.access', $project)
->with('status', "{$team->name} permissions were updated.");
app/Http/Requests/SyncProjectPermissionsRequest.php
+1 -8
View File
@@ -33,13 +33,6 @@ class SyncProjectPermissionsRequest extends FormRequest
];
}
public function permissions(): array
{
return collect($this->validated('permissions', []))
->map(fn (mixed $permission): string => (string) $permission)
->unique()
->values()
->all();
}
}