PetschStudios/KanbanGit
3
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 24 Wiki Activity

delete-functions-in-request-arr-get-replacement #24

Merged
Twyco merged 9 commits from delete-functions-in-request-arr-get-replacement into main 2026-04-11 12:51:57 +00:00
Conversation 1 Commits 9 Files Changed 28
+11 -35
7 changed files with 11 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0743b7c26c - Show all commits
app/Http/Controllers/Admin/UserManagementController.php
+3 -3
View File
@@ -25,10 +25,10 @@ class UserManagementController extends Controller
public function update(UpdateUserAdminStatusRequest $request, User $user): RedirectResponse
{
$validated = $request->validated();
$user->forceFill([
'is_admin' => $request->boolean('is_admin'),
])->save();
$user->is_admin = $validated['is_admin'];
Twyco commented 2026-04-04 09:31:51 +00:00
Outdated
Review
Copy Link
Copy Source

hier ist noch nen $request->boolean

hier ist noch nen $request->boolean
Twyco commented 2026-04-11 12:43:23 +00:00
Outdated
Review
Copy Link
Copy Source

das geht so (glaube ich) nicht. Du kannst darfst das forceFill nciht entfernen, weil is_admin ist kein fillable, daher forceFill.

außerdem benutzt du jetzt $validated['is_admin'] statt Arr::get($validated, 'is_admin')

das geht so (glaube ich) nicht. Du kannst darfst das forceFill nciht entfernen, weil is_admin ist kein fillable, daher forceFill. außerdem benutzt du jetzt $validated['is_admin'] statt Arr::get($validated, 'is_admin')
$user->save();
$status = $user->is_admin
? "{$user->name} now has admin access."
app/Http/Controllers/ProjectController.php
+2 -10
View File
@@ -120,11 +120,7 @@ class ProjectController extends Controller
);
$validated = $request->validated();
$permissions = collect(Arr::get($validated, 'permissions'))
->map(fn (mixed $permission): string => (string) $permission)
->unique()
->values()
->all();
$permissions = Arr::get($validated, 'permissions', []);
Eric marked this conversation as resolved
Twyco commented 2026-04-04 09:38:32 +00:00
Review
Copy Link
Copy Source

das kann alles raus.

einfach distinct in die request packen und dann einfach nur:

$permissions = Arr::get($validated, 'permissions', [])

das kann alles raus. einfach **distinct** in die request packen und dann einfach nur: $permissions = Arr::get($validated, 'permissions', [])
$this->projectPermissionService->syncUserPermissions($project, $user, $permissions);
@@ -143,11 +139,7 @@ class ProjectController extends Controller
);
$validated = $request->validated();
$permissions = collect(Arr::get($validated, 'permissions'))
->map(fn (mixed $permission): string => (string) $permission)
->unique()
->values()
->all();
$permissions = Arr::get($validated, 'permissions', []);
$this->projectPermissionService->syncTeamPermissions($project, $team, $permissions);
1
app/Http/Controllers/Settings/GitConnectionController.php
+4 -6
View File
@@ -23,11 +23,9 @@ class GitConnectionController extends Controller
public function edit(Request $request): Response
{
$user = $request->user();
$session = $request->session();
return Inertia::render('settings/GitConnections', [
'gitConnections' => $user->gitConnections
'gitConnections' => $request->user()->gitConnections
Eric marked this conversation as resolved Outdated
Twyco commented 2026-04-04 09:45:50 +00:00
Outdated
Review
Copy Link
Copy Source

hier brauchst du keine lokalen vars, beides wird ja nur einmal genutzt

hier brauchst du keine lokalen vars, beides wird ja nur einmal genutzt
->map(fn (UserGitConnection $gitConnection): array => [
'account_login' => $gitConnection->account_login,
'account_name' => $gitConnection->account_name,
@@ -41,7 +39,7 @@ class GitConnectionController extends Controller
'user_id' => $gitConnection->user_id,
])
->values(),
'status' => $session->get('status'),
'status' => $request->session()->get('status'),
]);
}
@@ -51,7 +49,7 @@ class GitConnectionController extends Controller
$apiToken = Arr::get($validated, 'api_token');
$baseUrl = Arr::get($validated, 'base_url');
$provider = GitProviderKey::from((string) Arr::get($validated, 'provider'));
$provider = GitProviderKey::from(Arr::get($validated, 'provider'));
$user = $request->user();
Eric marked this conversation as resolved
Twyco commented 2026-04-04 09:47:06 +00:00
Review
Copy Link
Copy Source

(string) cast kann weg, das validiert die request ja schon

(string) cast kann weg, das validiert die request ja schon
@@ -91,7 +89,7 @@ class GitConnectionController extends Controller
$validated = $request->validated();
$apiToken = Arr::get($validated, 'api_token');
$baseUrl = Arr::get($validated, 'base_url');
$provider = GitProviderKey::from((string) Arr::get($validated, 'provider'));
$provider = GitProviderKey::from(Arr::get($validated, 'provider'));
Eric marked this conversation as resolved
Twyco commented 2026-04-04 09:47:21 +00:00
Review
Copy Link
Copy Source

selbe hier mit cast

selbe hier mit cast
app/Http/Controllers/TeamController.php
+1 -5
View File
@@ -52,11 +52,7 @@ class TeamController extends Controller
{
$validated = $request->validated();
$userIds = collect(Arr::get($validated, 'user_ids', []))
->map(fn (mixed $userId): int => (int) $userId)
->unique()
->values()
->all();
$userIds = Arr::get($validated, 'user_ids', []);
Twyco commented 2026-04-04 09:50:59 +00:00
Review
Copy Link
Copy Source

hier auch einfach $userIds = Arr::get($validated, 'user_ids', []) und distinct ind request dazu

das collect->map->unique->values->all mach gar nichts.

hier auch einfach $userIds = Arr::get($validated, 'user_ids', []) und distinct ind request dazu das collect->map->unique->values->all mach gar nichts.
Twyco commented 2026-04-11 12:45:46 +00:00
Review
Copy Link
Copy Source

hier hast du vergessen distinct in die request reinzumachen

hier hast du vergessen distinct in die request reinzumachen
$this->projectPermissionService->syncTeamMembers($team, $userIds);
app/Http/Requests/SyncProjectPermissionsRequest.php
+1
View File
@@ -28,6 +28,7 @@ class SyncProjectPermissionsRequest extends FormRequest
'permissions' => ['nullable', 'array'],
'permissions.*' => [
'string',
'distinct',
Rule::in(ProjectPermissionService::permissions()),
],
];
app/Http/Requests/UpdateProjectTicketRequest.php
-8
View File
@@ -174,14 +174,6 @@ class UpdateProjectTicketRequest extends FormRequest
return $attributes;
}
/**
* @return array<int, array{
* ticket_field_definition_id: int,
* value_number?: float|int|string|null,
* value_user_id?: int|string|null
* }>
*/
private function createsCycle(Ticket $ticket, Ticket $candidateParent): bool
{
$currentParent = $candidateParent;
1
app/Http/Requests/UpdateTeamMembersRequest.php
-3
View File
@@ -29,7 +29,4 @@ class UpdateTeamMembersRequest extends FormRequest
];
}
/**
* @return array<int, int>
*/
}