delete-functions-in-request-arr-get-replacement #24
@@ -25,10 +25,10 @@ class UserManagementController extends Controller
|
||||
|
||||
public function update(UpdateUserAdminStatusRequest $request, User $user): RedirectResponse
|
||||
{
|
||||
$validated = $request->validated();
|
||||
|
||||
$user->forceFill([
|
||||
'is_admin' => $request->boolean('is_admin'),
|
||||
])->save();
|
||||
$user->is_admin = $validated['is_admin'];
|
||||
$user->save();
|
||||
|
||||
$status = $user->is_admin
|
||||
? "{$user->name} now has admin access."
|
||||
|
||||
@@ -120,11 +120,7 @@ class ProjectController extends Controller
|
||||
);
|
||||
|
||||
$validated = $request->validated();
|
||||
$permissions = collect(Arr::get($validated, 'permissions'))
|
||||
->map(fn (mixed $permission): string => (string) $permission)
|
||||
->unique()
|
||||
->values()
|
||||
->all();
|
||||
$permissions = Arr::get($validated, 'permissions', []);
|
||||
|
||||
|
Eric marked this conversation as resolved
|
||||
$this->projectPermissionService->syncUserPermissions($project, $user, $permissions);
|
||||
|
||||
@@ -143,11 +139,7 @@ class ProjectController extends Controller
|
||||
);
|
||||
|
||||
$validated = $request->validated();
|
||||
$permissions = collect(Arr::get($validated, 'permissions'))
|
||||
->map(fn (mixed $permission): string => (string) $permission)
|
||||
->unique()
|
||||
->values()
|
||||
->all();
|
||||
$permissions = Arr::get($validated, 'permissions', []);
|
||||
|
||||
$this->projectPermissionService->syncTeamPermissions($project, $team, $permissions);
|
||||
|
||||
|
||||
@@ -23,11 +23,9 @@ class GitConnectionController extends Controller
|
||||
|
||||
public function edit(Request $request): Response
|
||||
{
|
||||
$user = $request->user();
|
||||
$session = $request->session();
|
||||
|
||||
return Inertia::render('settings/GitConnections', [
|
||||
'gitConnections' => $user->gitConnections
|
||||
'gitConnections' => $request->user()->gitConnections
|
||||
->map(fn (UserGitConnection $gitConnection): array => [
|
||||
'account_login' => $gitConnection->account_login,
|
||||
'account_name' => $gitConnection->account_name,
|
||||
@@ -41,7 +39,7 @@ class GitConnectionController extends Controller
|
||||
'user_id' => $gitConnection->user_id,
|
||||
])
|
||||
->values(),
|
||||
'status' => $session->get('status'),
|
||||
'status' => $request->session()->get('status'),
|
||||
]);
|
||||
}
|
||||
|
||||
@@ -51,7 +49,7 @@ class GitConnectionController extends Controller
|
||||
|
||||
$apiToken = Arr::get($validated, 'api_token');
|
||||
$baseUrl = Arr::get($validated, 'base_url');
|
||||
$provider = GitProviderKey::from((string) Arr::get($validated, 'provider'));
|
||||
$provider = GitProviderKey::from(Arr::get($validated, 'provider'));
|
||||
$user = $request->user();
|
||||
|
||||
|
Eric marked this conversation as resolved
Twyco
commented
(string) cast kann weg, das validiert die request ja schon (string) cast kann weg, das validiert die request ja schon
|
||||
|
||||
@@ -91,7 +89,7 @@ class GitConnectionController extends Controller
|
||||
$validated = $request->validated();
|
||||
$apiToken = Arr::get($validated, 'api_token');
|
||||
$baseUrl = Arr::get($validated, 'base_url');
|
||||
$provider = GitProviderKey::from((string) Arr::get($validated, 'provider'));
|
||||
$provider = GitProviderKey::from(Arr::get($validated, 'provider'));
|
||||
|
||||
|
||||
|
Eric marked this conversation as resolved
Twyco
commented
selbe hier mit cast selbe hier mit cast
|
||||
|
||||
|
||||
@@ -52,11 +52,7 @@ class TeamController extends Controller
|
||||
{
|
||||
$validated = $request->validated();
|
||||
|
||||
$userIds = collect(Arr::get($validated, 'user_ids', []))
|
||||
->map(fn (mixed $userId): int => (int) $userId)
|
||||
->unique()
|
||||
->values()
|
||||
->all();
|
||||
$userIds = Arr::get($validated, 'user_ids', []);
|
||||
|
||||
|
Twyco
commented
hier auch einfach $userIds = Arr::get($validated, 'user_ids', []) und distinct ind request dazu das collect->map->unique->values->all mach gar nichts. hier auch einfach $userIds = Arr::get($validated, 'user_ids', []) und distinct ind request dazu
das collect->map->unique->values->all mach gar nichts.
Twyco
commented
hier hast du vergessen distinct in die request reinzumachen hier hast du vergessen distinct in die request reinzumachen
|
||||
$this->projectPermissionService->syncTeamMembers($team, $userIds);
|
||||
|
||||
|
||||
@@ -28,6 +28,7 @@ class SyncProjectPermissionsRequest extends FormRequest
|
||||
'permissions' => ['nullable', 'array'],
|
||||
'permissions.*' => [
|
||||
'string',
|
||||
'distinct',
|
||||
Rule::in(ProjectPermissionService::permissions()),
|
||||
],
|
||||
];
|
||||
|
||||
@@ -174,14 +174,6 @@ class UpdateProjectTicketRequest extends FormRequest
|
||||
return $attributes;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array<int, array{
|
||||
* ticket_field_definition_id: int,
|
||||
* value_number?: float|int|string|null,
|
||||
* value_user_id?: int|string|null
|
||||
* }>
|
||||
*/
|
||||
|
||||
private function createsCycle(Ticket $ticket, Ticket $candidateParent): bool
|
||||
{
|
||||
$currentParent = $candidateParent;
|
||||
|
||||
@@ -29,7 +29,4 @@ class UpdateTeamMembersRequest extends FormRequest
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array<int, int>
|
||||
*/
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user
das kann alles raus.
einfach distinct in die request packen und dann einfach nur:
$permissions = Arr::get($validated, 'permissions', [])