From ba9c4fd2e8e2745024fc99b3718b1e91206b7ccc Mon Sep 17 00:00:00 2001 From: Twyco Date: Sun, 27 Sep 2026 22:09:09 +0200 Subject: [PATCH] fix(KAN-65): package release DMGs without Finder automation --- .github/workflows/macos-release.yml | 3 +++ native/tests/macos-workflow.test.js | 13 +++++++++++++ 2 files changed, 16 insertions(+) diff --git a/.github/workflows/macos-release.yml b/.github/workflows/macos-release.yml index f930079..af33abd 100644 --- a/.github/workflows/macos-release.yml +++ b/.github/workflows/macos-release.yml @@ -176,6 +176,9 @@ jobs: - name: Build, sign and notarize with Tauri uses: tauri-apps/tauri-action@1deb371b0cd8bd54025b384f1cd735e725c4060f # v1.0.0 env: + # The DMG bundler reads these variables separately from --ci. + CI: "true" + TAURI_BUNDLER_DMG_IGNORE_CI: "false" APPLE_ID: dev@petsch-studios.de APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }} TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }} diff --git a/native/tests/macos-workflow.test.js b/native/tests/macos-workflow.test.js index b5964df..fc35f76 100644 --- a/native/tests/macos-workflow.test.js +++ b/native/tests/macos-workflow.test.js @@ -113,6 +113,19 @@ test('manual release on main accepts an existing tag without moving it', (t) => assert.equal(f.git(f.checkout, 'rev-parse', 'macos-v1.2.3'), f.commit); }); +test('release DMG packaging disables Finder automation in the Tauri action environment', () => { + const build = workflow + .split(' - name: Build, sign and notarize with Tauri\n')[1] + .split('\n - name:')[0]; + const environment = build + .split(' env:\n')[1] + .split(' with:\n')[0]; + assert.match(environment, /^ {10}CI: "true"$/m); + assert.match(environment, /^ {10}TAURI_BUNDLER_DMG_IGNORE_CI: "false"$/m); + assert.match(build, /--bundles app,dmg/); + assert.match(build, /"createUpdaterArtifacts":true/); +}); + for (const [name, overrides] of [ ['web release tag', { GITHUB_REF: 'refs/tags/v1.2.3' }], ['missing tag', { GITHUB_REF: 'refs/tags/macos-v9.9.9' }], -- 2.54.0