PetschStudios/KanbanGit
3
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 24 Wiki Activity

added status restriction

Browse Source
This commit is contained in:
Twyco
2026-04-14 19:07:15 +02:00
parent 9927a91327
commit fb10ecd535
12 changed files with 570 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Feature/Projects/ProjectBoardControllerTest.php
+128 -1
View File
@@ -119,6 +119,7 @@ class ProjectBoardControllerTest extends TestCase
]);
$this->syncProjectPermissions($project, $user, ['edit', 'view']);
$this->allowMove($backlogStatus, $todoStatus);
$this->actingAs($user)
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
@@ -180,6 +181,7 @@ class ProjectBoardControllerTest extends TestCase
]);
$this->syncProjectPermissions($project, $user, ['edit', 'view']);
$this->allowMove($todoStatus, $doneStatus);
$this->actingAs($user)
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
@@ -237,6 +239,7 @@ class ProjectBoardControllerTest extends TestCase
]);
$this->syncProjectPermissions($project, $user, ['edit', 'view']);
$this->allowMove($doingStatus, $backlogStatus);
$this->actingAs($user)
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
@@ -328,7 +331,6 @@ class ProjectBoardControllerTest extends TestCase
]);
$todoStatus = $this->createColumnStatus($todoColumn);
$backlogStatus = $this->backlogStatus($project);
$backlogStatus->allowedTargetStatuses()->detach($todoStatus->id);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
@@ -364,6 +366,126 @@ class ProjectBoardControllerTest extends TestCase
$this->assertDatabaseCount('ticket_worklog_entries', 0);
}
/**
* Ensure configured status moves can model a restricted workflow.
*/
public function test_users_with_edit_permission_can_follow_configured_status_transitions(): void
{
$user = User::factory()->create();
$project = Project::factory()->create([
'key' => 'CORE',
]);
app(InitializeProjectTicketMetadata::class)->handle($project);
$progressColumn = BoardColumn::factory()->for($project)->create([
'name' => 'Progress',
'position' => 1,
]);
$reviewColumn = BoardColumn::factory()->for($project)->create([
'name' => 'Review',
'position' => 2,
]);
$doneColumn = BoardColumn::factory()->for($project)->create([
'name' => 'Done',
'position' => 3,
]);
$progressStatus = $this->createColumnStatus($progressColumn);
$reviewStatus = $this->createColumnStatus($reviewColumn);
$doneStatus = $this->createColumnStatus($doneColumn);
$this->allowMove($progressStatus, $reviewStatus);
$this->allowMove($reviewStatus, $doneStatus);
$this->allowMove($reviewStatus, $progressStatus);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 2,
]);
$ticket = Ticket::factory()->create([
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_status_id' => $progressStatus->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'title' => 'Board ticket',
]);
$this->syncProjectPermissions($project, $user, ['edit', 'view']);
$this->actingAs($user)
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
'redirect_to' => 'board',
'ticket_status_id' => $reviewStatus->id,
])
->assertRedirect(route('projects.board.index', $project))
->assertSessionHas('status', 'CORE-1 moved to Review.');
$ticket->refresh();
$this->actingAs($user)
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
'redirect_to' => 'board',
'ticket_status_id' => $progressStatus->id,
])
->assertRedirect(route('projects.board.index', $project))
->assertSessionHas('status', 'CORE-1 moved to Progress.');
$ticket->refresh();
$this->actingAs($user)
->from(route('projects.board.index', $project))
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
'redirect_to' => 'board',
'ticket_status_id' => $doneStatus->id,
])
->assertRedirect(route('projects.board.index', $project))
->assertSessionHasErrors('ticket_status_id');
$this->assertDatabaseHas('tickets', [
'id' => $ticket->id,
'ticket_status_id' => $progressStatus->id,
]);
$this->assertDatabaseCount('ticket_worklog_entries', 2);
$this->actingAs($user)
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
'redirect_to' => 'board',
'ticket_status_id' => $reviewStatus->id,
])
->assertRedirect(route('projects.board.index', $project));
$ticket->refresh();
$this->actingAs($user)
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
'redirect_to' => 'board',
'ticket_status_id' => $doneStatus->id,
])
->assertRedirect(route('projects.board.index', $project))
->assertSessionHas('status', 'CORE-1 moved to Done.');
$ticket->refresh();
$this->actingAs($user)
->from(route('projects.board.index', $project))
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
'redirect_to' => 'board',
'ticket_status_id' => $reviewStatus->id,
])
->assertRedirect(route('projects.board.index', $project))
->assertSessionHasErrors('ticket_status_id');
$this->assertDatabaseHas('tickets', [
'id' => $ticket->id,
'ticket_status_id' => $doneStatus->id,
]);
$this->assertDatabaseCount('ticket_worklog_entries', 4);
}
private function backlogStatus(Project $project): TicketStatus
{
return $project->ticketStatuses()
@@ -381,4 +503,9 @@ class ProjectBoardControllerTest extends TestCase
'position' => 1,
]);
}
private function allowMove(TicketStatus $sourceStatus, TicketStatus $targetStatus): void
{
$sourceStatus->allowedTargetStatuses()->syncWithoutDetaching([$targetStatus->id]);
}
}