Align matcher tests with substring matching
This commit is contained in:
@@ -11,9 +11,9 @@ class TicketKeyReferenceMatcherTest extends TestCase
|
||||
use RefreshDatabase;
|
||||
|
||||
/**
|
||||
* Ensure a reference must start with the ticket key, regardless of case.
|
||||
* Ensure a reference matches when it contains the ticket key, regardless of case.
|
||||
*/
|
||||
public function test_matcher_accepts_ticket_key_prefixes_case_insensitively(): void
|
||||
public function test_matcher_accepts_references_containing_the_ticket_key_case_insensitively(): void
|
||||
{
|
||||
$matcher = app(TicketKeyReferenceMatcher::class);
|
||||
|
||||
@@ -22,16 +22,18 @@ class TicketKeyReferenceMatcherTest extends TestCase
|
||||
$this->assertTrue($matcher->matches('CORE-1', 'CORE-1_hotfix'));
|
||||
$this->assertTrue($matcher->matches('CORE-1', 'CORE-1'));
|
||||
$this->assertTrue($matcher->matches('CORE-1', 'core-1-login-form'));
|
||||
$this->assertTrue($matcher->matches('CORE-1', 'CORE-10-login-form'));
|
||||
$this->assertTrue($matcher->matches('CORE-1', 'MY-CORE-1-login-form'));
|
||||
}
|
||||
|
||||
/**
|
||||
* Ensure similar or embedded ticket keys are not treated as matches.
|
||||
* Ensure references without the ticket key are not treated as matches.
|
||||
*/
|
||||
public function test_matcher_rejects_other_ticket_prefixes(): void
|
||||
public function test_matcher_rejects_references_without_the_ticket_key(): void
|
||||
{
|
||||
$matcher = app(TicketKeyReferenceMatcher::class);
|
||||
|
||||
$this->assertFalse($matcher->matches('CORE-1', 'CORE-10-login-form'));
|
||||
$this->assertFalse($matcher->matches('CORE-1', 'MY-CORE-1-login-form'));
|
||||
$this->assertFalse($matcher->matches('CORE-1', 'CORE-2-login-form'));
|
||||
$this->assertFalse($matcher->matches('CORE-1', 'feature/auth-cleanup'));
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user