feat(KAN-55): support app links, file selection and clipboard

native/src-tauri/src/desktop.rs

@@ -39,6 +39,26 @@ fn allows_server_navigation(server: &Url, destination: &Url) -> bool {
         && destination.password().is_none()
 }
 
+fn allows_external_navigation(destination: &Url) -> bool {
+    matches!(destination.scheme(), "https" | "http")
+        && destination.host_str().is_some()
+        && destination.username().is_empty()
+        && destination.password().is_none()
+}
+
+fn open_external(destination: &Url) {
+    if allows_external_navigation(destination) {
+        // Arguments are passed directly to Launch Services, never through a shell.
+        let destination = destination.to_string();
+        std::thread::spawn(move || {
+            let _ = std::process::Command::new("/usr/bin/open")
+                .arg("--")
+                .arg(destination)
+                .status();
+        });
+    }
+}
+
 fn allows_launcher_navigation(destination: &Url) -> bool {
     destination.scheme() == "tauri"
         && destination.host_str() == Some("localhost")
@@ -146,6 +166,9 @@ fn open_workspace(app: &AppHandle, input: &str) -> Result<(), &'static str> {
     let handle = app.clone();
     let navigation_label = label.clone();
     let server_url = server.url.clone();
+    let popup_server = server_url.clone();
+    let popup_handle = app.clone();
+    let popup_label = label.clone();
     let window = WebviewWindowBuilder::new(app, &label, WebviewUrl::External(server.url))
         .title(en::APP_NAME)
         .inner_size(1280.0, 850.0)
@@ -155,12 +178,22 @@ fn open_workspace(app: &AppHandle, input: &str) -> Result<(), &'static str> {
         .data_store_identifier(server.profile)
         .on_navigation(move |destination| {
             if !allows_server_navigation(&server_url, destination) {
+                open_external(destination);
                 return false;
             }
             begin_navigation(&handle, &navigation_label);
             true
         })
-        .on_new_window(|_, _| NewWindowResponse::Deny)
+        .on_new_window(move |destination, _| {
+            if allows_server_navigation(&popup_server, &destination) {
+                if let Some(window) = popup_handle.get_webview_window(&popup_label) {
+                    let _ = window.navigate(destination);
+                }
+            } else {
+                open_external(&destination);
+            }
+            NewWindowResponse::Deny
+        })
         .on_page_load(|window, payload| {
             if payload.event() != PageLoadEvent::Finished {
                 return;
@@ -277,11 +310,31 @@ pub fn builder() -> tauri::Builder<tauri::Wry> {
                     .select_all()
                     .build()?,
             )
+            .item(
+                &SubmenuBuilder::new(app, en::NAVIGATION)
+                    .text("workspace-back", en::BACK)
+                    .text("workspace-forward", en::FORWARD)
+                    .build()?,
+            )
             .build()?;
         app.set_menu(menu)?;
         app.on_menu_event(|app, event| {
             if event.id().as_ref() == "server-settings" {
                 show_launcher(app);
+            } else if let Some(script) = match event.id().as_ref() {
+                "workspace-back" => Some("window.history.back()"),
+                "workspace-forward" => Some("window.history.forward()"),
+                _ => None,
+            } {
+                let label = app
+                    .state::<Mutex<Connection>>()
+                    .lock()
+                    .unwrap()
+                    .label
+                    .clone();
+                if let Some(window) = label.and_then(|label| app.get_webview_window(&label)) {
+                    let _ = window.eval(script);
+                }
             }
         });
         let handle = app.handle().clone();
@@ -347,6 +400,26 @@ pub fn builder() -> tauri::Builder<tauri::Wry> {
 mod tests {
     use super::*;
 
+    #[test]
+    fn external_links_accept_only_web_urls_without_credentials() {
+        for input in [
+            "https://git.example.com/org/repo/pulls/1#diff",
+            "http://git.example.com/repo",
+        ] {
+            assert!(allows_external_navigation(&Url::parse(input).unwrap()));
+        }
+        for input in [
+            "https://user:secret@git.example.com/",
+            "file:///etc/passwd",
+            "javascript:alert(1)",
+            "tauri://localhost/action/open",
+            "mailto:user@example.com",
+            "data:text/html,test",
+        ] {
+            assert!(!allows_external_navigation(&Url::parse(input).unwrap()));
+        }
+    }
+
     #[test]
     fn navigation_is_limited_to_the_selected_https_origin() {
         let server = validate_url("https://example.com:8443/app/").unwrap();