fix: make project template inheritance granular and safe

2026-09-08 10:25:52 +00:00
parent fed6a282a4
commit 9895fc36db
50 changed files with 1504 additions and 624 deletions
@@ -48,9 +48,6 @@ class StoreProjectTicketRequest extends FormRequest
    {
        /** @var Project $project */
        $project = $this->route('project');
-        $projectTemplateId = $project->project_template_id;
-        $ownershipColumn = $projectTemplateId === null ? 'project_id' : 'project_template_id';
-        $ownershipValue = $projectTemplateId ?? $project->id;

        return [
            'acceptance_criteria' => ['nullable', 'array'],
@@ -70,21 +67,21 @@ class StoreProjectTicketRequest extends FormRequest
                'required',
                'integer',
                Rule::exists('ticket_priorities', 'id')->where(
-                    fn ($query) => $query->where($ownershipColumn, $ownershipValue),
+                    fn ($query) => $query->where('project_id', $project->id),
                ),
            ],
            'ticket_status_id' => [
                'required',
                'integer',
                Rule::exists('ticket_statuses', 'id')->where(
-                    fn ($query) => $query->where($ownershipColumn, $ownershipValue),
+                    fn ($query) => $query->where('project_id', $project->id),
                ),
            ],
            'ticket_type_id' => [
                'required',
                'integer',
                Rule::exists('ticket_types', 'id')->where(
-                    fn ($query) => $query->where($ownershipColumn, $ownershipValue),
+                    fn ($query) => $query->where('project_id', $project->id),
                ),
            ],
            'story_points' => ['nullable', 'integer', 'min:0'],