Implement ticket statuses

2026-04-14 03:09:12 +02:00
parent 2dc12c5d60
commit 8f4a8276ac
40 changed files with 1602 additions and 100 deletions
@@ -6,6 +6,7 @@ use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
 use App\Models\BoardColumn;
 use App\Models\Project;
 use App\Models\Ticket;
+use App\Models\TicketStatus;
 use Database\Seeders\BoardColumnSeeder;
 use Database\Seeders\ProjectSeeder;
 use Illuminate\Foundation\Testing\RefreshDatabase;
@@ -69,22 +70,29 @@ class BoardColumnTest extends TestCase
            'name' => 'Doing',
            'position' => 1,
        ]);
+        $ticketStatus = TicketStatus::factory()
+            ->for($project)
+            ->for($boardColumn)
+            ->create([
+                'name' => 'Doing',
+                'position' => 1,
+            ]);

        Ticket::factory()->create([
-            'board_column_id' => $boardColumn->id,
            'project_id' => $project->id,
            'sequence_number' => 1,
            'ticket_key' => 'CORE-1',
            'ticket_priority_id' => $priority->id,
+            'ticket_status_id' => $ticketStatus->id,
            'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
            'title' => 'First ticket',
        ]);
        Ticket::factory()->create([
-            'board_column_id' => $boardColumn->id,
            'project_id' => $project->id,
            'sequence_number' => 2,
            'ticket_key' => 'CORE-2',
            'ticket_priority_id' => $priority->id,
+            'ticket_status_id' => $ticketStatus->id,
            'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
            'title' => 'Second ticket',
        ]);
@@ -112,6 +120,11 @@ class BoardColumnTest extends TestCase
            'name' => 'Todo',
            'position' => 1,
        ]);
+        $this->assertDatabaseHas('ticket_statuses', [
+            'project_id' => $coreProject->id,
+            'name' => 'Todo',
+            'slug' => 'todo',
+        ]);

        $this->assertDatabaseHas('board_columns', [
            'project_id' => $coreProject->id,
@@ -0,0 +1,116 @@
+<?php
+
+namespace Tests\Feature\Models;
+
+use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
+use App\Models\BoardColumn;
+use App\Models\Project;
+use App\Models\TicketStatus;
+use Database\Seeders\BoardColumnSeeder;
+use Database\Seeders\ProjectSeeder;
+use Database\Seeders\ProjectTicketMetadataSeeder;
+use Database\Seeders\TicketStatusSeeder;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase;
+
+class TicketStatusTest extends TestCase
+{
+    use RefreshDatabase;
+
+    /**
+     * Ensure ticket statuses belong to exactly one board column or backlog.
+     */
+    public function test_ticket_status_factory_creates_backlog_statuses(): void
+    {
+        $ticketStatus = TicketStatus::factory()->create([
+            'name' => 'Ready for QA',
+        ]);
+
+        $this->assertNotNull($ticketStatus->project);
+        $this->assertNull($ticketStatus->boardColumn);
+        $this->assertSame('ready-for-qa', $ticketStatus->slug);
+        $this->assertSame(1, $ticketStatus->position);
+    }
+
+    /**
+     * Ensure project metadata initialization creates a default backlog status.
+     */
+    public function test_project_metadata_initialization_creates_backlog_status(): void
+    {
+        $project = Project::factory()->create();
+
+        app(InitializeProjectTicketMetadata::class)->handle($project);
+
+        $this->assertDatabaseHas('ticket_statuses', [
+            'project_id' => $project->id,
+            'board_column_id' => null,
+            'name' => 'Backlog',
+            'slug' => 'backlog',
+            'position' => 1,
+        ]);
+    }
+
+    /**
+     * Ensure new statuses can move to each other through the transition relation.
+     */
+    public function test_ticket_statuses_create_allowed_transition_relations(): void
+    {
+        $project = Project::factory()->create();
+        $backlogStatus = TicketStatus::factory()->for($project)->create([
+            'name' => 'Backlog',
+            'position' => 1,
+        ]);
+        $readyStatus = TicketStatus::factory()->for($project)->create([
+            'name' => 'Ready',
+            'position' => 2,
+        ]);
+
+        $this->assertTrue($backlogStatus->allowedTargetStatuses()->whereKey($readyStatus->id)->exists());
+        $this->assertTrue($readyStatus->allowedTargetStatuses()->whereKey($backlogStatus->id)->exists());
+    }
+
+    /**
+     * Ensure board columns expose their grouped ticket statuses in position order.
+     */
+    public function test_board_column_ticket_statuses_are_returned_in_position_order(): void
+    {
+        $project = Project::factory()->create();
+        $boardColumn = BoardColumn::factory()->for($project)->create();
+
+        TicketStatus::factory()->for($project)->for($boardColumn)->create([
+            'name' => 'Second',
+            'position' => 2,
+        ]);
+        TicketStatus::factory()->for($project)->for($boardColumn)->create([
+            'name' => 'First',
+            'position' => 1,
+        ]);
+
+        $this->assertSame(
+            ['First', 'Second'],
+            $boardColumn->fresh()->ticketStatuses->pluck('name')->all(),
+        );
+    }
+
+    /**
+     * Ensure the ticket status seeder creates extra statuses for seeded projects.
+     */
+    public function test_ticket_status_seeder_creates_statuses_for_seeded_projects(): void
+    {
+        $this->seed([
+            ProjectSeeder::class,
+            BoardColumnSeeder::class,
+            ProjectTicketMetadataSeeder::class,
+            TicketStatusSeeder::class,
+        ]);
+
+        $coreProject = Project::query()->where('key', 'CORE')->firstOrFail();
+
+        $this->assertDatabaseHas('ticket_statuses', [
+            'project_id' => $coreProject->id,
+            'board_column_id' => null,
+            'name' => 'Ready',
+            'slug' => 'ready',
+        ]);
+    }
+}
@@ -9,6 +9,7 @@ use App\Models\TicketFieldDefinition;
 use App\Models\TicketFieldValue;
 use App\Models\TicketLink;
 use App\Models\TicketLinkType;
+use App\Models\TicketStatus;
 use App\Models\TicketWorklogEntry;
 use App\Models\User;
 use Database\Seeders\BoardColumnSeeder;
@@ -29,7 +30,7 @@ class TicketTest extends TestCase
    {
        $ticket = Ticket::factory()->create();

-        $this->assertNull($ticket->board_column_id);
+        $this->assertNull($ticket->ticketStatus?->board_column_id);
        $this->assertStringContainsString('-', $ticket->ticket_key);
        $this->assertSame(1, $ticket->sequence_number);
    }
@@ -47,19 +48,22 @@ class TicketTest extends TestCase
        ]);

        $coreProject = Project::query()->where('key', 'CORE')->firstOrFail();
+        $backlogStatus = $coreProject->ticketStatuses()
+            ->whereNull('board_column_id')
+            ->firstOrFail();

        $this->assertDatabaseHas('tickets', [
            'project_id' => $coreProject->id,
            'ticket_key' => 'CORE-1',
            'title' => 'Seed backlog item',
-            'board_column_id' => null,
+            'ticket_status_id' => $backlogStatus->id,
        ]);

        $this->assertDatabaseHas('tickets', [
            'project_id' => $coreProject->id,
            'ticket_key' => 'CORE-2',
            'title' => 'Seed backlog item',
-            'board_column_id' => null,
+            'ticket_status_id' => $backlogStatus->id,
        ]);
    }

@@ -200,6 +204,22 @@ class TicketTest extends TestCase
        $this->assertSame($author->id, $ticket->fresh()->author?->id);
    }

+    /**
+     * Ensure tickets expose their status relation.
+     */
+    public function test_ticket_status_relation_is_available(): void
+    {
+        $ticketStatus = TicketStatus::factory()->create([
+            'name' => 'Backlog',
+        ]);
+        $ticket = Ticket::factory()->create([
+            'project_id' => $ticketStatus->project_id,
+            'ticket_status_id' => $ticketStatus->id,
+        ]);
+
+        $this->assertSame($ticketStatus->id, $ticket->fresh()->ticketStatus?->id);
+    }
+
    /**
     * Ensure tickets expose incoming and outgoing link relations.
     */