PetschStudios/KanbanGit
3
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 24 Wiki Activity

Implement project board status workflow

Browse Source
This commit is contained in:
Twyco
2026-03-25 08:04:34 +01:00
parent f7a0543ea1
commit 7e767b0c6c
22 changed files with 1076 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Feature/Models/BoardColumnTest.php
+49
View File
@@ -2,8 +2,11 @@
namespace Tests\Feature\Models;
use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
use App\Models\BoardColumn;
use App\Models\Project;
use App\Models\Ticket;
use App\Models\TicketPriority;
use Database\Seeders\BoardColumnSeeder;
use Database\Seeders\ProjectSeeder;
use Illuminate\Foundation\Testing\RefreshDatabase;
@@ -50,6 +53,52 @@ class BoardColumnTest extends TestCase
);
}
/**
* Ensure board columns expose tickets ordered by descending sequence number.
*/
public function test_board_column_tickets_are_returned_in_sequence_order(): void
{
$project = Project::factory()->create([
'key' => 'CORE',
]);
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$boardColumn = BoardColumn::factory()->for($project)->create([
'name' => 'Doing',
'position' => 1,
]);
Ticket::factory()->create([
'board_column_id' => $boardColumn->id,
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'title' => 'First ticket',
]);
Ticket::factory()->create([
'board_column_id' => $boardColumn->id,
'project_id' => $project->id,
'sequence_number' => 2,
'ticket_key' => 'CORE-2',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'title' => 'Second ticket',
]);
$this->assertSame(
['CORE-2', 'CORE-1'],
$boardColumn->fresh()->tickets->pluck('ticket_key')->all(),
);
}
/**
* Ensure the board column seeder creates starter workflow columns for seeded projects.
*/
tests/Feature/Models/TicketTest.php
+23
View File
@@ -4,6 +4,7 @@ namespace Tests\Feature\Models;
use App\Models\Project;
use App\Models\Ticket;
use App\Models\TicketWorklogEntry;
use Database\Seeders\BoardColumnSeeder;
use Database\Seeders\ProjectSeeder;
use Database\Seeders\ProjectTicketMetadataSeeder;
@@ -55,4 +56,26 @@ class TicketTest extends TestCase
'board_column_id' => null,
]);
}
/**
* Ensure ticket worklog entries are exposed newest first for timeline rendering.
*/
public function test_ticket_worklog_entries_are_returned_newest_first(): void
{
$ticket = Ticket::factory()->create();
$olderEntry = TicketWorklogEntry::factory()->for($ticket)->create([
'created_at' => now()->subMinute(),
'updated_at' => now()->subMinute(),
]);
$newerEntry = TicketWorklogEntry::factory()->for($ticket)->create([
'created_at' => now(),
'updated_at' => now(),
]);
$this->assertSame(
[$newerEntry->id, $olderEntry->id],
$ticket->fresh()->worklogEntries->modelKeys(),
);
}
}
tests/Feature/Models/TicketWorklogEntryTest.php
+52
View File
@@ -0,0 +1,52 @@
<?php
namespace Tests\Feature\Models;
use App\Models\TicketWorklogEntry;
use Database\Seeders\BoardColumnSeeder;
use Database\Seeders\ProjectSeeder;
use Database\Seeders\ProjectTicketMetadataSeeder;
use Database\Seeders\TicketSeeder;
use Database\Seeders\TicketWorklogEntrySeeder;
use Database\Seeders\UserSeeder;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
class TicketWorklogEntryTest extends TestCase
{
use RefreshDatabase;
/**
* Ensure the worklog factory creates related tickets and actors.
*/
public function test_ticket_worklog_entry_factory_creates_related_models(): void
{
$entry = TicketWorklogEntry::factory()->create();
$this->assertNotNull($entry->ticket);
$this->assertNotNull($entry->actor);
$this->assertSame('status_changed', $entry->entry_type);
}
/**
* Ensure the worklog seeder creates an initial entry for each seeded ticket.
*/
public function test_ticket_worklog_entry_seeder_creates_entries_for_seeded_tickets(): void
{
$this->seed([
UserSeeder::class,
ProjectSeeder::class,
BoardColumnSeeder::class,
ProjectTicketMetadataSeeder::class,
TicketSeeder::class,
TicketWorklogEntrySeeder::class,
]);
$this->assertDatabaseHas('ticket_worklog_entries', [
'entry_type' => 'created',
'summary' => 'Ticket was created in Backlog.',
]);
$this->assertSame(6, TicketWorklogEntry::query()->count());
}
}
tests/Feature/Projects/ProjectBacklogControllerTest.php
+7
View File
@@ -4,6 +4,7 @@ namespace Tests\Feature\Projects;
use App\Actions\ProjectPermissions\ProjectPermissionService;
use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
use App\Models\BoardColumn;
use App\Models\Project;
use App\Models\Ticket;
use App\Models\TicketPriority;
@@ -27,6 +28,10 @@ class ProjectBacklogControllerTest extends TestCase
]);
app(InitializeProjectTicketMetadata::class)->handle($project);
BoardColumn::factory()->for($project)->create([
'name' => 'Todo',
'position' => 1,
]);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
@@ -49,6 +54,8 @@ class ProjectBacklogControllerTest extends TestCase
->assertOk()
->assertInertia(fn (Assert $page) => $page
->component('projects/Backlog')
->where('boardColumns.0.name', 'Todo')
->where('canEditTickets', false)
->where('project.id', $project->id)
->where('tickets.0.ticket_key', $ticket->ticket_key)
->where('canCreateTickets', false),
tests/Feature/Projects/ProjectBoardControllerTest.php
+301
View File
@@ -0,0 +1,301 @@
<?php
namespace Tests\Feature\Projects;
use App\Actions\ProjectPermissions\ProjectPermissionService;
use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
use App\Models\BoardColumn;
use App\Models\Project;
use App\Models\Ticket;
use App\Models\TicketPriority;
use App\Models\User;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Inertia\Testing\AssertableInertia as Assert;
use Tests\TestCase;
class ProjectBoardControllerTest extends TestCase
{
use RefreshDatabase;
/**
* Ensure users with view permission can open the board and only see board tickets.
*/
public function test_users_with_view_permission_can_view_a_projects_board(): void
{
$user = User::factory()->create();
$project = Project::factory()->create([
'key' => 'CORE',
]);
app(InitializeProjectTicketMetadata::class)->handle($project);
$todoColumn = BoardColumn::factory()->for($project)->create([
'name' => 'Todo',
'position' => 1,
]);
$doingColumn = BoardColumn::factory()->for($project)->create([
'name' => 'Doing',
'position' => 2,
]);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 1,
]);
Ticket::factory()->create([
'board_column_id' => null,
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'title' => 'Backlog ticket',
]);
$boardTicket = Ticket::factory()->create([
'board_column_id' => $doingColumn->id,
'project_id' => $project->id,
'sequence_number' => 2,
'ticket_key' => 'CORE-2',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'title' => 'Board ticket',
]);
app(ProjectPermissionService::class)->syncUserPermissions($project, $user, ['view']);
$this->actingAs($user)
->get(route('projects.board.index', $project))
->assertOk()
->assertInertia(fn (Assert $page) => $page
->component('projects/Board')
->where('project.id', $project->id)
->where('boardColumns.0.name', $todoColumn->name)
->has('boardColumns.0.tickets', 0)
->where('boardColumns.1.name', $doingColumn->name)
->has('boardColumns.1.tickets', 1)
->where('boardColumns.1.tickets.0.ticket_key', $boardTicket->ticket_key)
->where('boardColumns.1.tickets.0.title', $boardTicket->title)
->where('canEditTickets', false),
);
}
/**
* Ensure moving backlog tickets into a board column requires edit permission and logs the change.
*/
public function test_users_with_edit_permission_can_move_backlog_tickets_to_a_board_column(): void
{
$user = User::factory()->create();
$project = Project::factory()->create([
'key' => 'CORE',
]);
app(InitializeProjectTicketMetadata::class)->handle($project);
$todoColumn = BoardColumn::factory()->for($project)->create([
'name' => 'Todo',
'position' => 1,
]);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 1,
]);
$ticket = Ticket::factory()->create([
'board_column_id' => null,
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'title' => 'Backlog ticket',
]);
app(ProjectPermissionService::class)->syncUserPermissions($project, $user, ['edit', 'view']);
$this->actingAs($user)
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
'board_column_id' => $todoColumn->id,
'redirect_to' => 'backlog',
])
->assertRedirect(route('projects.backlog.index', $project))
->assertSessionHas('status', 'CORE-1 moved to Todo.');
$this->assertDatabaseHas('tickets', [
'id' => $ticket->id,
'board_column_id' => $todoColumn->id,
]);
$this->assertDatabaseHas('ticket_worklog_entries', [
'ticket_id' => $ticket->id,
'actor_id' => $user->id,
'entry_type' => 'status_changed',
'summary' => 'Moved from Backlog to Todo.',
]);
}
/**
* Ensure board tickets can move between columns.
*/
public function test_users_with_edit_permission_can_move_board_tickets_between_columns(): void
{
$user = User::factory()->create();
$project = Project::factory()->create([
'key' => 'CORE',
]);
app(InitializeProjectTicketMetadata::class)->handle($project);
$todoColumn = BoardColumn::factory()->for($project)->create([
'name' => 'Todo',
'position' => 1,
]);
$doneColumn = BoardColumn::factory()->for($project)->create([
'name' => 'Done',
'position' => 2,
]);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 1,
]);
$ticket = Ticket::factory()->create([
'board_column_id' => $todoColumn->id,
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'title' => 'Board ticket',
]);
app(ProjectPermissionService::class)->syncUserPermissions($project, $user, ['edit', 'view']);
$this->actingAs($user)
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
'board_column_id' => $doneColumn->id,
'redirect_to' => 'board',
])
->assertRedirect(route('projects.board.index', $project))
->assertSessionHas('status', 'CORE-1 moved to Done.');
$this->assertDatabaseHas('tickets', [
'id' => $ticket->id,
'board_column_id' => $doneColumn->id,
]);
$this->assertDatabaseHas('ticket_worklog_entries', [
'ticket_id' => $ticket->id,
'actor_id' => $user->id,
'entry_type' => 'status_changed',
'summary' => 'Moved from Todo to Done.',
]);
}
/**
* Ensure moving a board ticket back to backlog removes it from the board columns.
*/
public function test_users_with_edit_permission_can_move_board_tickets_back_to_backlog(): void
{
$user = User::factory()->create();
$project = Project::factory()->create([
'key' => 'CORE',
]);
app(InitializeProjectTicketMetadata::class)->handle($project);
$doingColumn = BoardColumn::factory()->for($project)->create([
'name' => 'Doing',
'position' => 1,
]);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 1,
]);
$ticket = Ticket::factory()->create([
'board_column_id' => $doingColumn->id,
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'title' => 'Board ticket',
]);
app(ProjectPermissionService::class)->syncUserPermissions($project, $user, ['edit', 'view']);
$this->actingAs($user)
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
'board_column_id' => null,
'redirect_to' => 'board',
])
->assertRedirect(route('projects.board.index', $project))
->assertSessionHas('status', 'CORE-1 moved to Backlog.');
$this->assertDatabaseHas('tickets', [
'id' => $ticket->id,
'board_column_id' => null,
]);
$this->actingAs($user)
->get(route('projects.board.index', $project))
->assertOk()
->assertInertia(fn (Assert $page) => $page
->where('boardColumns.0.name', $doingColumn->name)
->has('boardColumns.0.tickets', 0),
);
}
/**
* Ensure cross-project board column moves are rejected.
*/
public function test_status_moves_to_columns_from_other_projects_are_rejected(): void
{
$user = User::factory()->create();
$project = Project::factory()->create();
$otherProject = Project::factory()->create();
app(InitializeProjectTicketMetadata::class)->handle($project);
app(InitializeProjectTicketMetadata::class)->handle($otherProject);
$otherProjectColumn = BoardColumn::factory()->for($otherProject)->create([
'name' => 'Foreign',
'position' => 1,
]);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 1,
]);
$ticket = Ticket::factory()->create([
'board_column_id' => null,
'project_id' => $project->id,
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
]);
app(ProjectPermissionService::class)->syncUserPermissions($project, $user, ['edit', 'view']);
$this->actingAs($user)
->from(route('projects.backlog.index', $project))
->patch(route('projects.tickets.status.update', [$project, $ticket]), [
'board_column_id' => $otherProjectColumn->id,
'redirect_to' => 'backlog',
])
->assertRedirect(route('projects.backlog.index', $project))
->assertSessionHasErrors('board_column_id');
$this->assertDatabaseHas('tickets', [
'id' => $ticket->id,
'board_column_id' => null,
]);
$this->assertDatabaseCount('ticket_worklog_entries', 0);
}
}