From 6cb3311cc717c0237312600adf6f9ab9728e7f98 Mon Sep 17 00:00:00 2001
From: Twyco <twyco@icloud.com>
Date: Mon, 13 Apr 2026 01:33:53 +0200
Subject: [PATCH] fixed tests

---
 .../seeders/ProjectTicketMetadataSeeder.php     |  5 +++++
 database/seeders/TicketWorklogEntrySeeder.php   |  1 +
 tests/Feature/Models/ProjectTest.php            |  5 ++++-
 .../Models/TicketFieldDefinitionTest.php        | 17 -----------------
 tests/Feature/Models/TicketFieldValueTest.php   |  5 +++--
 5 files changed, 13 insertions(+), 20 deletions(-)

diff --git a/database/seeders/ProjectTicketMetadataSeeder.php b/database/seeders/ProjectTicketMetadataSeeder.php
index a448128..ef29311 100644
--- a/database/seeders/ProjectTicketMetadataSeeder.php
+++ b/database/seeders/ProjectTicketMetadataSeeder.php
@@ -4,6 +4,7 @@ namespace Database\Seeders;
 
 use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
 use App\Models\Project;
+use App\Models\TicketFieldDefinition;
 use Illuminate\Database\Seeder;
 
 class ProjectTicketMetadataSeeder extends Seeder
@@ -41,6 +42,10 @@ class ProjectTicketMetadataSeeder extends Seeder
                     ['name' => 'High'],
                     ['position' => 3],
                 );
+
+                TicketFieldDefinition::factory()
+                    ->for($project)
+                    ->create(['label' => 'Driver', 'field_type' => 'user', 'position' => 1]);
             });
     }
 }
diff --git a/database/seeders/TicketWorklogEntrySeeder.php b/database/seeders/TicketWorklogEntrySeeder.php
index 21fe5c7..6bb6afc 100644
--- a/database/seeders/TicketWorklogEntrySeeder.php
+++ b/database/seeders/TicketWorklogEntrySeeder.php
@@ -17,6 +17,7 @@ class TicketWorklogEntrySeeder extends Seeder
         $defaultActor = User::query()->orderBy('id')->first();
 
         Ticket::query()
+            ->whereDoesntHave('worklogEntries')
             ->orderBy('id')
             ->get()
             ->each(function (Ticket $ticket) use ($defaultActor): void {
diff --git a/tests/Feature/Models/ProjectTest.php b/tests/Feature/Models/ProjectTest.php
index c676ea7..336a4e2 100644
--- a/tests/Feature/Models/ProjectTest.php
+++ b/tests/Feature/Models/ProjectTest.php
@@ -118,7 +118,10 @@ class ProjectTest extends TestCase
             $coreProject->ticketPriorities->pluck('name')->all(),
         );
 
-        $this->assertSame([], $coreProject->ticketFieldDefinitions->pluck('label')->all());
+        $this->assertSame(
+            ['Driver'],
+            $coreProject->ticketFieldDefinitions->pluck('label')->all(),
+        );
     }
 
     /**
diff --git a/tests/Feature/Models/TicketFieldDefinitionTest.php b/tests/Feature/Models/TicketFieldDefinitionTest.php
index 565ae1d..427ebeb 100644
--- a/tests/Feature/Models/TicketFieldDefinitionTest.php
+++ b/tests/Feature/Models/TicketFieldDefinitionTest.php
@@ -7,8 +7,6 @@ use App\Models\Project;
 use App\Models\Ticket;
 use App\Models\TicketFieldDefinition;
 use App\Models\TicketFieldValue;
-use Database\Seeders\ProjectSeeder;
-use Database\Seeders\ProjectTicketMetadataSeeder;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Tests\TestCase;
 
@@ -29,21 +27,6 @@ class TicketFieldDefinitionTest extends TestCase
         );
     }
 
-    /**
-     * Ensure the metadata seeder creates project field definitions.
-     */
-    public function test_metadata_seeder_does_not_create_fixed_ticket_field_definitions(): void
-    {
-        $this->seed([
-            ProjectSeeder::class,
-            ProjectTicketMetadataSeeder::class,
-        ]);
-
-        $coreProject = Project::query()->where('key', 'CORE')->firstOrFail();
-
-        $this->assertSame(0, $coreProject->ticketFieldDefinitions()->count());
-    }
-
     /**
      * Ensure ticket field definitions expose their related ticket values.
      */
diff --git a/tests/Feature/Models/TicketFieldValueTest.php b/tests/Feature/Models/TicketFieldValueTest.php
index a93755c..2c2707e 100644
--- a/tests/Feature/Models/TicketFieldValueTest.php
+++ b/tests/Feature/Models/TicketFieldValueTest.php
@@ -3,6 +3,7 @@
 namespace Tests\Feature\Models;
 
 use App\Models\TicketFieldValue;
+use App\Models\User;
 use Database\Seeders\BoardColumnSeeder;
 use Database\Seeders\ProjectSeeder;
 use Database\Seeders\ProjectTicketMetadataSeeder;
@@ -42,9 +43,9 @@ class TicketFieldValueTest extends TestCase
         ]);
 
         $this->assertDatabaseHas('ticket_field_values', [
-            'value_number' => 3.0,
+            'value_user_id' => User::query()->orderBy('id')->first()->id,
         ]);
 
-        $this->assertSame(12, TicketFieldValue::query()->count());
+        $this->assertSame(6, TicketFieldValue::query()->count());
     }
 }