Model ticket link counterparts explicitly

app/Http/Controllers/Api/ProjectTicketMetadataSettingsController.php

@@ -22,10 +22,12 @@ use App\Http\Requests\DestroyProjectTicketTypeRequest;
 use App\Http\Requests\StoreProjectNamedSettingRequest;
 use App\Http\Requests\StoreProjectTicketTypeRequest;
 use App\Http\Requests\StoreTicketFieldDefinitionRequest;
+use App\Http\Requests\StoreTicketLinkTypeRequest;
 use App\Http\Requests\UpdateProjectNamedSettingRequest;
 use App\Http\Requests\UpdateProjectTicketMetadataSettings as UpdateProjectTicketMetadataSettingsRequest;
 use App\Http\Requests\UpdateProjectTicketTypeRequest;
 use App\Http\Requests\UpdateTicketFieldDefinitionRequest;
+use App\Http\Requests\UpdateTicketLinkTypeRequest;
 use App\Http\Resources\ProjectResource;
 use App\Http\Resources\TicketFieldDefinitionResource;
 use App\Http\Resources\TicketLinkTypeResource;
@@ -209,7 +211,7 @@ class ProjectTicketMetadataSettingsController extends ApiController
         return response()->json(null, 204);
     }
 
-    public function storeLinkType(StoreProjectNamedSettingRequest $request, Project $project): JsonResponse
+    public function storeLinkType(StoreTicketLinkTypeRequest $request, Project $project): JsonResponse
     {
         $this->abortUnlessCanManage($request, $project);
 
@@ -222,7 +224,7 @@ class ProjectTicketMetadataSettingsController extends ApiController
     }
 
     public function updateLinkType(
-        UpdateProjectNamedSettingRequest $request,
+        UpdateTicketLinkTypeRequest $request,
         Project $project,
         TicketLinkType $ticketLinkType,
     ): JsonResponse {

app/Http/Controllers/ProjectTicketMetadataSettingsController.php

@@ -22,10 +22,12 @@ use App\Http\Requests\DestroyProjectTicketTypeRequest;
 use App\Http\Requests\StoreProjectNamedSettingRequest;
 use App\Http\Requests\StoreProjectTicketTypeRequest;
 use App\Http\Requests\StoreTicketFieldDefinitionRequest;
+use App\Http\Requests\StoreTicketLinkTypeRequest;
 use App\Http\Requests\UpdateProjectNamedSettingRequest;
 use App\Http\Requests\UpdateProjectTicketMetadataSettings;
 use App\Http\Requests\UpdateProjectTicketTypeRequest;
 use App\Http\Requests\UpdateTicketFieldDefinitionRequest;
+use App\Http\Requests\UpdateTicketLinkTypeRequest;
 use App\Models\Project;
 use App\Models\TicketFieldDefinition;
 use App\Models\TicketLinkType;
@@ -203,7 +205,7 @@ class ProjectTicketMetadataSettingsController extends Controller
             ->with('status', "{$deletedLabel} field was removed.");
     }
 
-    public function storeLinkType(StoreProjectNamedSettingRequest $request, Project $project): RedirectResponse
+    public function storeLinkType(StoreTicketLinkTypeRequest $request, Project $project): RedirectResponse
     {
         $this->abortUnlessCanManage($request, $project);
 
@@ -214,7 +216,7 @@ class ProjectTicketMetadataSettingsController extends Controller
     }
 
     public function updateLinkType(
-        UpdateProjectNamedSettingRequest $request,
+        UpdateTicketLinkTypeRequest $request,
         Project $project,
         TicketLinkType $ticketLinkType,
     ): RedirectResponse {

app/Http/Requests/StoreTicketLinkTypeRequest.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace App\Http\Requests;
+
+use Illuminate\Contracts\Validation\ValidationRule;
+use Illuminate\Foundation\Http\FormRequest;
+
+class StoreTicketLinkTypeRequest extends FormRequest
+{
+    /**
+     * Determine if the user is authorized to make this request.
+     */
+    public function authorize(): bool
+    {
+        return $this->user() !== null;
+    }
+
+    /**
+     * Get the validation rules that apply to the request.
+     *
+     * @return array<string, ValidationRule|array<mixed>|string>
+     */
+    public function rules(): array
+    {
+        return [
+            'name' => ['required', 'string', 'max:255'],
+            'counterpart_name' => ['required', 'string', 'max:255'],
+            'position' => ['nullable', 'integer', 'min:1'],
+        ];
+    }
+}

app/Http/Requests/UpdateTicketLinkTypeRequest.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace App\Http\Requests;
+
+use Illuminate\Contracts\Validation\ValidationRule;
+use Illuminate\Foundation\Http\FormRequest;
+
+class UpdateTicketLinkTypeRequest extends FormRequest
+{
+    /**
+     * Determine if the user is authorized to make this request.
+     */
+    public function authorize(): bool
+    {
+        return $this->user() !== null;
+    }
+
+    /**
+     * Get the validation rules that apply to the request.
+     *
+     * @return array<string, ValidationRule|array<mixed>|string>
+     */
+    public function rules(): array
+    {
+        return [
+            'name' => ['required', 'string', 'max:255'],
+            'counterpart_name' => ['required', 'string', 'max:255'],
+            'position' => ['required', 'integer', 'min:1'],
+        ];
+    }
+}

app/Http/Resources/TicketLinkResource.php

@@ -18,16 +18,19 @@ class TicketLinkResource extends JsonResource
     {
         if ($this->resource instanceof TicketLink) {
             $currentTicketId = (int) ($this->resource->getAttribute('current_ticket_id') ?? 0);
-            $linkedTicket = $this->source_ticket_id === $currentTicketId
+            $isSourceTicket = $this->source_ticket_id === $currentTicketId;
+            $linkedTicket = $isSourceTicket
                 ? $this->targetTicket
                 : $this->sourceTicket;
+            $ticketLinkType = TicketLinkTypeResource::make($this->ticketLinkType)->resolve();
+            $ticketLinkType['label'] = $this->ticketLinkType->labelForSource($isSourceTicket);
 
             return [
                 'id' => $this->id,
                 'linked_ticket' => TicketReferenceResource::make($linkedTicket)->resolve(),
                 'source_ticket_id' => $this->source_ticket_id,
                 'target_ticket_id' => $this->target_ticket_id,
-                'ticket_link_type' => TicketLinkTypeResource::make($this->ticketLinkType)->resolve(),
+                'ticket_link_type' => $ticketLinkType,
                 'ticket_link_type_id' => $this->ticket_link_type_id,
                 'created_at' => $this->created_at?->toISOString(),
                 'updated_at' => $this->updated_at?->toISOString(),

app/Http/Resources/TicketLinkTypeResource.php

@@ -17,6 +17,7 @@ class TicketLinkTypeResource extends JsonResource
         return [
             'id' => $this->id,
             'label' => $this->label,
+            'counterpart_label' => $this->counterpart_label ?: $this->label,
             'position' => $this->position,
             'project_id' => $this->project_id,
             'created_at' => $this->created_at?->toISOString(),