Implement ticket types priorities and custom fields

2026-03-25 01:28:25 +01:00
parent 3f9b83ec16
commit 35aacff318
32 changed files with 1832 additions and 1 deletions
@@ -6,6 +6,7 @@ use App\Models\BoardColumn;
 use App\Models\Project;
 use Database\Seeders\BoardColumnSeeder;
 use Database\Seeders\ProjectSeeder;
+use Database\Seeders\ProjectTicketMetadataSeeder;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Tests\TestCase;

@@ -92,4 +93,32 @@ class ProjectTest extends TestCase
            'position' => 1,
        ]);
    }
+
+    /**
+     * Ensure projects expose ticket metadata relationships after seeding.
+     */
+    public function test_projects_expose_ticket_metadata_relationships(): void
+    {
+        $this->seed([
+            ProjectSeeder::class,
+            ProjectTicketMetadataSeeder::class,
+        ]);
+
+        $coreProject = Project::query()->where('key', 'CORE')->firstOrFail();
+
+        $this->assertSame(
+            ['Task', 'Parent', 'Bug'],
+            $coreProject->ticketTypes->pluck('name')->all(),
+        );
+
+        $this->assertSame(
+            ['Low', 'Medium', 'High'],
+            $coreProject->ticketPriorities->pluck('name')->all(),
+        );
+
+        $this->assertSame(
+            ['Assignee', 'Story Points'],
+            $coreProject->ticketFieldDefinitions->pluck('label')->all(),
+        );
+    }
 }
@@ -0,0 +1,55 @@
+<?php
+
+namespace Tests\Feature\Models;
+
+use App\Models\Project;
+use App\Models\TicketFieldDefinition;
+use Database\Seeders\ProjectSeeder;
+use Database\Seeders\ProjectTicketMetadataSeeder;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase;
+
+class TicketFieldDefinitionTest extends TestCase
+{
+    use RefreshDatabase;
+
+    /**
+     * Ensure the field definition factory uses a supported field type.
+     */
+    public function test_ticket_field_definition_factory_uses_supported_types(): void
+    {
+        $ticketFieldDefinition = TicketFieldDefinition::factory()->create();
+
+        $this->assertContains(
+            $ticketFieldDefinition->field_type,
+            TicketFieldDefinition::FIELD_TYPES,
+        );
+    }
+
+    /**
+     * Ensure the metadata seeder creates project field definitions.
+     */
+    public function test_metadata_seeder_creates_ticket_field_definitions(): void
+    {
+        $this->seed([
+            ProjectSeeder::class,
+            ProjectTicketMetadataSeeder::class,
+        ]);
+
+        $coreProject = Project::query()->where('key', 'CORE')->firstOrFail();
+
+        $this->assertDatabaseHas('ticket_field_definitions', [
+            'project_id' => $coreProject->id,
+            'label' => 'Assignee',
+            'field_type' => 'user',
+            'position' => 1,
+        ]);
+
+        $this->assertDatabaseHas('ticket_field_definitions', [
+            'project_id' => $coreProject->id,
+            'label' => 'Story Points',
+            'field_type' => 'number',
+            'position' => 2,
+        ]);
+    }
+}
@@ -0,0 +1,56 @@
+<?php
+
+namespace Tests\Feature\Models;
+
+use App\Models\Project;
+use App\Models\TicketPriority;
+use Database\Seeders\ProjectSeeder;
+use Database\Seeders\ProjectTicketMetadataSeeder;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase;
+
+class TicketPriorityTest extends TestCase
+{
+    use RefreshDatabase;
+
+    /**
+     * Ensure the ticket priority factory creates a default position.
+     */
+    public function test_ticket_priority_factory_creates_a_position(): void
+    {
+        $ticketPriority = TicketPriority::factory()->create();
+
+        $this->assertSame(1, $ticketPriority->position);
+    }
+
+    /**
+     * Ensure the metadata seeder creates project-specific priorities.
+     */
+    public function test_metadata_seeder_creates_project_priorities(): void
+    {
+        $this->seed([
+            ProjectSeeder::class,
+            ProjectTicketMetadataSeeder::class,
+        ]);
+
+        $coreProject = Project::query()->where('key', 'CORE')->firstOrFail();
+
+        $this->assertDatabaseHas('ticket_priorities', [
+            'project_id' => $coreProject->id,
+            'name' => 'Low',
+            'position' => 1,
+        ]);
+
+        $this->assertDatabaseHas('ticket_priorities', [
+            'project_id' => $coreProject->id,
+            'name' => 'Medium',
+            'position' => 2,
+        ]);
+
+        $this->assertDatabaseHas('ticket_priorities', [
+            'project_id' => $coreProject->id,
+            'name' => 'High',
+            'position' => 3,
+        ]);
+    }
+}
@@ -0,0 +1,55 @@
+<?php
+
+namespace Tests\Feature\Models;
+
+use App\Models\Project;
+use App\Models\TicketType;
+use Database\Seeders\ProjectSeeder;
+use Database\Seeders\ProjectTicketMetadataSeeder;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase;
+
+class TicketTypeTest extends TestCase
+{
+    use RefreshDatabase;
+
+    /**
+     * Ensure the ticket type factory creates custom types by default.
+     */
+    public function test_ticket_type_factory_creates_custom_types(): void
+    {
+        $ticketType = TicketType::factory()->create();
+
+        $this->assertFalse($ticketType->is_builtin);
+        $this->assertNull($ticketType->system_key);
+    }
+
+    /**
+     * Ensure the metadata seeder creates the required built-in types for projects.
+     */
+    public function test_metadata_seeder_creates_builtin_task_and_parent_types(): void
+    {
+        $this->seed([
+            ProjectSeeder::class,
+            ProjectTicketMetadataSeeder::class,
+        ]);
+
+        $coreProject = Project::query()->where('key', 'CORE')->firstOrFail();
+
+        $this->assertDatabaseHas('ticket_types', [
+            'project_id' => $coreProject->id,
+            'name' => 'Task',
+            'system_key' => 'task',
+            'is_builtin' => true,
+            'position' => 1,
+        ]);
+
+        $this->assertDatabaseHas('ticket_types', [
+            'project_id' => $coreProject->id,
+            'name' => 'Parent',
+            'system_key' => 'parent',
+            'is_builtin' => true,
+            'position' => 2,
+        ]);
+    }
+}
@@ -135,6 +135,20 @@ class ProjectControllerTest extends TestCase
                'permission' => $permission,
            ]);
        }
+
+        $this->assertDatabaseHas('ticket_types', [
+            'project_id' => $project->id,
+            'name' => 'Task',
+            'system_key' => 'task',
+            'is_builtin' => true,
+        ]);
+
+        $this->assertDatabaseHas('ticket_types', [
+            'project_id' => $project->id,
+            'name' => 'Parent',
+            'system_key' => 'parent',
+            'is_builtin' => true,
+        ]);
    }

    /**
@@ -0,0 +1,211 @@
+<?php
+
+namespace Tests\Feature\Projects;
+
+use App\Actions\ProjectPermissions\ProjectPermissionService;
+use App\Models\Project;
+use App\Models\TicketFieldDefinition;
+use App\Models\TicketPriority;
+use App\Models\TicketType;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Inertia\Testing\AssertableInertia as Assert;
+use Tests\TestCase;
+
+class ProjectTicketMetadataSettingsControllerTest extends TestCase
+{
+    use RefreshDatabase;
+
+    /**
+     * Ensure users with edit permission can view ticket metadata settings.
+     */
+    public function test_users_with_edit_permission_can_view_ticket_metadata_settings(): void
+    {
+        $user = User::factory()->create();
+        $project = Project::factory()->create();
+        TicketType::factory()->for($project)->create([
+            'name' => 'Bug',
+            'position' => 3,
+        ]);
+
+        app(ProjectPermissionService::class)->syncUserPermissions($project, $user, ['edit']);
+
+        $this->actingAs($user)
+            ->get(route('projects.settings.metadata', $project))
+            ->assertOk()
+            ->assertInertia(fn (Assert $page) => $page
+                ->component('projects/settings/Metadata')
+                ->where('ticketTypes.0.name', 'Task')
+                ->where('ticketTypes.1.name', 'Parent')
+                ->where('ticketTypes.2.name', 'Bug'),
+            );
+    }
+
+    /**
+     * Ensure users can create custom ticket types.
+     */
+    public function test_users_with_edit_permission_can_create_custom_ticket_types(): void
+    {
+        $user = User::factory()->create();
+        $project = Project::factory()->create();
+
+        app(ProjectPermissionService::class)->syncUserPermissions($project, $user, ['edit']);
+
+        $this->actingAs($user)
+            ->post(route('projects.settings.metadata.types.store', $project), [
+                'name' => 'Bug',
+            ])
+            ->assertRedirect(route('projects.settings.metadata', $project))
+            ->assertSessionHas('status', 'Bug type was added.');
+
+        $this->assertDatabaseHas('ticket_types', [
+            'project_id' => $project->id,
+            'name' => 'Bug',
+            'is_builtin' => false,
+            'system_key' => null,
+        ]);
+    }
+
+    /**
+     * Ensure built-in ticket types can be renamed but not deleted.
+     */
+    public function test_builtin_ticket_types_can_be_renamed_but_not_deleted(): void
+    {
+        $user = User::factory()->create();
+        $project = Project::factory()->create();
+
+        app(ProjectPermissionService::class)->syncUserPermissions($project, $user, ['edit']);
+
+        $taskType = TicketType::query()
+            ->where('project_id', $project->id)
+            ->where('system_key', 'task')
+            ->first();
+
+        if ($taskType === null) {
+            $this->actingAs($user)
+                ->get(route('projects.settings.metadata', $project))
+                ->assertOk();
+
+            $taskType = TicketType::query()
+                ->where('project_id', $project->id)
+                ->where('system_key', 'task')
+                ->firstOrFail();
+        }
+
+        $this->actingAs($user)
+            ->patch(route('projects.settings.metadata.types.update', [$project, $taskType]), [
+                'name' => 'Standard Task',
+                'position' => 1,
+            ])
+            ->assertRedirect(route('projects.settings.metadata', $project))
+            ->assertSessionHas('status', 'Standard Task type was updated.');
+
+        $this->assertDatabaseHas('ticket_types', [
+            'id' => $taskType->id,
+            'name' => 'Standard Task',
+            'system_key' => 'task',
+            'is_builtin' => true,
+        ]);
+
+        $this->actingAs($user)
+            ->delete(route('projects.settings.metadata.types.destroy', [$project, $taskType]))
+            ->assertForbidden();
+    }
+
+    /**
+     * Ensure priorities can be created, updated, and deleted.
+     */
+    public function test_users_with_edit_permission_can_manage_ticket_priorities(): void
+    {
+        $user = User::factory()->create();
+        $project = Project::factory()->create();
+        $priority = TicketPriority::factory()->for($project)->create([
+            'name' => 'High',
+            'position' => 1,
+        ]);
+
+        app(ProjectPermissionService::class)->syncUserPermissions($project, $user, ['edit']);
+
+        $this->actingAs($user)
+            ->post(route('projects.settings.metadata.priorities.store', $project), [
+                'name' => 'Low',
+            ])
+            ->assertRedirect(route('projects.settings.metadata', $project));
+
+        $this->actingAs($user)
+            ->patch(route('projects.settings.metadata.priorities.update', [$project, $priority]), [
+                'name' => 'Urgent',
+                'position' => 2,
+            ])
+            ->assertRedirect(route('projects.settings.metadata', $project))
+            ->assertSessionHas('status', 'Urgent priority was updated.');
+
+        $this->actingAs($user)
+            ->delete(route('projects.settings.metadata.priorities.destroy', [$project, $priority]))
+            ->assertRedirect(route('projects.settings.metadata', $project))
+            ->assertSessionHas('status', 'Urgent priority was removed.');
+
+        $this->assertDatabaseMissing('ticket_priorities', [
+            'id' => $priority->id,
+        ]);
+    }
+
+    /**
+     * Ensure custom field definitions can be created and updated with supported types.
+     */
+    public function test_users_with_edit_permission_can_manage_custom_field_definitions(): void
+    {
+        $user = User::factory()->create();
+        $project = Project::factory()->create();
+        $fieldDefinition = TicketFieldDefinition::factory()->for($project)->create([
+            'label' => 'Story Points',
+            'field_type' => 'number',
+            'position' => 1,
+        ]);
+
+        app(ProjectPermissionService::class)->syncUserPermissions($project, $user, ['edit']);
+
+        $this->actingAs($user)
+            ->post(route('projects.settings.metadata.fields.store', $project), [
+                'label' => 'Reviewer',
+                'field_type' => 'user',
+            ])
+            ->assertRedirect(route('projects.settings.metadata', $project))
+            ->assertSessionHas('status', 'Reviewer field was added.');
+
+        $this->actingAs($user)
+            ->patch(route('projects.settings.metadata.fields.update', [$project, $fieldDefinition]), [
+                'label' => 'Estimated Points',
+                'field_type' => 'number',
+                'position' => 2,
+            ])
+            ->assertRedirect(route('projects.settings.metadata', $project))
+            ->assertSessionHas('status', 'Estimated Points field was updated.');
+
+        $this->assertDatabaseHas('ticket_field_definitions', [
+            'id' => $fieldDefinition->id,
+            'label' => 'Estimated Points',
+            'field_type' => 'number',
+        ]);
+    }
+
+    /**
+     * Ensure unsupported field types are rejected.
+     */
+    public function test_unsupported_field_types_are_rejected(): void
+    {
+        $user = User::factory()->create();
+        $project = Project::factory()->create();
+
+        app(ProjectPermissionService::class)->syncUserPermissions($project, $user, ['edit']);
+
+        $this->actingAs($user)
+            ->from(route('projects.settings.metadata', $project))
+            ->post(route('projects.settings.metadata.fields.store', $project), [
+                'label' => 'Reviewer',
+                'field_type' => 'text',
+            ])
+            ->assertSessionHasErrors('field_type')
+            ->assertRedirect(route('projects.settings.metadata', $project));
+    }
+}