Sync acceptance criteria toggle state to children
This commit is contained in:
@@ -3,6 +3,7 @@
|
||||
namespace Tests\Feature\Projects;
|
||||
|
||||
use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
|
||||
use App\Actions\Tickets\Support\AcceptanceCriteriaChecklistMapper;
|
||||
use App\Models\AcceptanceCriterion;
|
||||
use App\Models\BoardColumn;
|
||||
use App\Models\Project;
|
||||
@@ -495,7 +496,7 @@ class ProjectTicketControllerTest extends TestCase
|
||||
],
|
||||
[
|
||||
'text' => 'Includes nested confirmations',
|
||||
'checked' => true,
|
||||
'checked' => false,
|
||||
'indent' => 1,
|
||||
],
|
||||
];
|
||||
@@ -540,7 +541,7 @@ class ProjectTicketControllerTest extends TestCase
|
||||
|
||||
$this->assertEquals(
|
||||
$updatedAcceptanceCriteria,
|
||||
\App\Actions\Tickets\Support\AcceptanceCriteriaChecklistMapper::fromModels($ticket->acceptanceCriteria),
|
||||
AcceptanceCriteriaChecklistMapper::fromModels($ticket->acceptanceCriteria),
|
||||
);
|
||||
$this->assertDatabaseHas('acceptance_criteria', [
|
||||
'ticket_id' => $ticket->id,
|
||||
@@ -549,7 +550,7 @@ class ProjectTicketControllerTest extends TestCase
|
||||
'text' => 'Shows success banner',
|
||||
'is_checked' => false,
|
||||
]);
|
||||
$rootCriterionId = \App\Models\AcceptanceCriterion::query()
|
||||
$rootCriterionId = AcceptanceCriterion::query()
|
||||
->where('ticket_id', $ticket->id)
|
||||
->where('text', 'Shows success banner')
|
||||
->value('id');
|
||||
@@ -559,7 +560,7 @@ class ProjectTicketControllerTest extends TestCase
|
||||
'parent_acceptance_criterion_id' => $rootCriterionId,
|
||||
'position' => 0,
|
||||
'text' => 'Includes nested confirmations',
|
||||
'is_checked' => true,
|
||||
'is_checked' => false,
|
||||
]);
|
||||
$this->assertDatabaseHas('ticket_field_values', [
|
||||
'ticket_id' => $ticket->id,
|
||||
@@ -627,7 +628,7 @@ class ProjectTicketControllerTest extends TestCase
|
||||
[
|
||||
'id' => $childCriterion->id,
|
||||
'text' => 'Updated child item',
|
||||
'checked' => false,
|
||||
'checked' => true,
|
||||
'indent' => 1,
|
||||
],
|
||||
],
|
||||
@@ -657,7 +658,7 @@ class ProjectTicketControllerTest extends TestCase
|
||||
'parent_acceptance_criterion_id' => $rootCriterion->id,
|
||||
'position' => 0,
|
||||
'text' => 'Updated child item',
|
||||
'is_checked' => false,
|
||||
'is_checked' => true,
|
||||
]);
|
||||
}
|
||||
|
||||
@@ -707,6 +708,141 @@ class ProjectTicketControllerTest extends TestCase
|
||||
]);
|
||||
}
|
||||
|
||||
public function test_ticket_update_syncs_child_acceptance_criteria_when_parent_is_toggled(): void
|
||||
{
|
||||
$editor = User::factory()->create();
|
||||
$project = Project::factory()->create([
|
||||
'key' => 'CORE',
|
||||
]);
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
$ticketType = $this->nonParentType($project);
|
||||
$ticket = Ticket::factory()->create([
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 1,
|
||||
'ticket_key' => 'CORE-1',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $ticketType->id,
|
||||
'title' => 'Acceptance criteria parent toggle test',
|
||||
]);
|
||||
$parentCriterion = AcceptanceCriterion::query()->create([
|
||||
'ticket_id' => $ticket->id,
|
||||
'parent_acceptance_criterion_id' => null,
|
||||
'position' => 0,
|
||||
'text' => 'Parent item',
|
||||
'is_checked' => false,
|
||||
]);
|
||||
$childCriterion = AcceptanceCriterion::query()->create([
|
||||
'ticket_id' => $ticket->id,
|
||||
'parent_acceptance_criterion_id' => $parentCriterion->id,
|
||||
'position' => 0,
|
||||
'text' => 'Child item',
|
||||
'is_checked' => false,
|
||||
]);
|
||||
$grandchildCriterion = AcceptanceCriterion::query()->create([
|
||||
'ticket_id' => $ticket->id,
|
||||
'parent_acceptance_criterion_id' => $childCriterion->id,
|
||||
'position' => 0,
|
||||
'text' => 'Grandchild item',
|
||||
'is_checked' => false,
|
||||
]);
|
||||
|
||||
$this->syncProjectPermissions($project, $editor, ['write', 'view']);
|
||||
|
||||
$headers = [
|
||||
'Accept' => 'application/json',
|
||||
'X-Requested-With' => 'XMLHttpRequest',
|
||||
];
|
||||
|
||||
$this->actingAs($editor)
|
||||
->withHeaders($headers)
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
|
||||
'acceptance_criteria' => [
|
||||
[
|
||||
'id' => $parentCriterion->id,
|
||||
'text' => 'Parent item',
|
||||
'checked' => true,
|
||||
'indent' => 0,
|
||||
],
|
||||
[
|
||||
'id' => $childCriterion->id,
|
||||
'text' => 'Child item',
|
||||
'checked' => false,
|
||||
'indent' => 1,
|
||||
],
|
||||
[
|
||||
'id' => $grandchildCriterion->id,
|
||||
'text' => 'Grandchild item',
|
||||
'checked' => false,
|
||||
'indent' => 2,
|
||||
],
|
||||
],
|
||||
]))
|
||||
->assertOk()
|
||||
->assertJson([
|
||||
'message' => 'CORE-1 was updated.',
|
||||
'updated' => true,
|
||||
]);
|
||||
|
||||
$this->assertDatabaseHas('acceptance_criteria', [
|
||||
'id' => $parentCriterion->id,
|
||||
'is_checked' => true,
|
||||
]);
|
||||
$this->assertDatabaseHas('acceptance_criteria', [
|
||||
'id' => $childCriterion->id,
|
||||
'is_checked' => true,
|
||||
]);
|
||||
$this->assertDatabaseHas('acceptance_criteria', [
|
||||
'id' => $grandchildCriterion->id,
|
||||
'is_checked' => true,
|
||||
]);
|
||||
|
||||
$this->actingAs($editor)
|
||||
->withHeaders($headers)
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket->fresh(), [
|
||||
'acceptance_criteria' => [
|
||||
[
|
||||
'id' => $parentCriterion->id,
|
||||
'text' => 'Parent item',
|
||||
'checked' => false,
|
||||
'indent' => 0,
|
||||
],
|
||||
[
|
||||
'id' => $childCriterion->id,
|
||||
'text' => 'Child item',
|
||||
'checked' => true,
|
||||
'indent' => 1,
|
||||
],
|
||||
[
|
||||
'id' => $grandchildCriterion->id,
|
||||
'text' => 'Grandchild item',
|
||||
'checked' => true,
|
||||
'indent' => 2,
|
||||
],
|
||||
],
|
||||
]))
|
||||
->assertOk()
|
||||
->assertJson([
|
||||
'message' => 'CORE-1 was updated.',
|
||||
'updated' => true,
|
||||
]);
|
||||
|
||||
$this->assertDatabaseHas('acceptance_criteria', [
|
||||
'id' => $parentCriterion->id,
|
||||
'is_checked' => false,
|
||||
]);
|
||||
$this->assertDatabaseHas('acceptance_criteria', [
|
||||
'id' => $childCriterion->id,
|
||||
'is_checked' => false,
|
||||
]);
|
||||
$this->assertDatabaseHas('acceptance_criteria', [
|
||||
'id' => $grandchildCriterion->id,
|
||||
'is_checked' => false,
|
||||
]);
|
||||
}
|
||||
|
||||
/**
|
||||
* Ensure non-parent tickets cannot be assigned as a parent target.
|
||||
*/
|
||||
@@ -1107,7 +1243,7 @@ class ProjectTicketControllerTest extends TestCase
|
||||
private function updatePayload(Ticket $ticket, array $overrides = []): array
|
||||
{
|
||||
return array_merge([
|
||||
'acceptance_criteria' => \App\Actions\Tickets\Support\AcceptanceCriteriaChecklistMapper::fromModels(
|
||||
'acceptance_criteria' => AcceptanceCriteriaChecklistMapper::fromModels(
|
||||
$ticket->acceptanceCriteria()->get(),
|
||||
),
|
||||
'assignee_user_id' => $ticket->assignee_user_id,
|
||||
|
||||
Reference in New Issue
Block a user