diff --git a/app/Http/Controllers/ProjectBacklogController.php b/app/Http/Controllers/ProjectBacklogController.php index 54d6091..86908da 100644 --- a/app/Http/Controllers/ProjectBacklogController.php +++ b/app/Http/Controllers/ProjectBacklogController.php @@ -28,7 +28,6 @@ class ProjectBacklogController extends Controller 403, ); - return Inertia::render('projects/Backlog', [ 'boardColumns' => $project->boardColumns()->get(), 'canEditTickets' => $this->projectPermissionService->userHasPermission($user, $project, 'edit'), diff --git a/app/Http/Controllers/ProjectRepositorySettingsController.php b/app/Http/Controllers/ProjectRepositorySettingsController.php index 0ccd23a..a2c3914 100644 --- a/app/Http/Controllers/ProjectRepositorySettingsController.php +++ b/app/Http/Controllers/ProjectRepositorySettingsController.php @@ -100,7 +100,6 @@ class ProjectRepositorySettingsController extends Controller 403, ); - $validated = $request->validated(); $userGitConnectionId = Arr::get($validated, 'user_git_connection_id'); $providerRepositoryId = Arr::get($validated, 'provider_repository_id'); diff --git a/app/Http/Controllers/ProjectTicketBranchController.php b/app/Http/Controllers/ProjectTicketBranchController.php index a6656e3..86937c8 100644 --- a/app/Http/Controllers/ProjectTicketBranchController.php +++ b/app/Http/Controllers/ProjectTicketBranchController.php @@ -118,8 +118,6 @@ class ProjectTicketBranchController extends Controller $repositoryConnectionId = Arr::get($validated, 'repository_connection_id'); $branchName = trim((string) Arr::get($validated, 'branch_name')); - - $repositoryConnection = $this->projectRepositoryConnection( $project, $repositoryConnectionId, diff --git a/app/Http/Controllers/ProjectTicketController.php b/app/Http/Controllers/ProjectTicketController.php index 16ff9d9..30105cc 100644 --- a/app/Http/Controllers/ProjectTicketController.php +++ b/app/Http/Controllers/ProjectTicketController.php @@ -101,7 +101,7 @@ class ProjectTicketController extends Controller Ticket $ticket, ): RedirectResponse { - $user = $request->user(); + $user = $request->user(); abort_unless( $this->projectPermissionService->userHasPermission($user, $project, 'edit'), 403, diff --git a/app/Http/Controllers/ProjectTicketMetadataSettingsController.php b/app/Http/Controllers/ProjectTicketMetadataSettingsController.php index 659fcca..3827cf9 100644 --- a/app/Http/Controllers/ProjectTicketMetadataSettingsController.php +++ b/app/Http/Controllers/ProjectTicketMetadataSettingsController.php @@ -59,7 +59,6 @@ class ProjectTicketMetadataSettingsController extends Controller $name = Arr::get($validated, 'name'); $position = Arr::get($validated, 'position'); - $ticketType = DB::transaction(function () use ($project, $name, $position): TicketType { $ticketType = $project->ticketTypes()->create([ 'is_builtin' => false, diff --git a/app/Http/Controllers/Settings/GitConnectionController.php b/app/Http/Controllers/Settings/GitConnectionController.php index 7b575b5..8fbea25 100644 --- a/app/Http/Controllers/Settings/GitConnectionController.php +++ b/app/Http/Controllers/Settings/GitConnectionController.php @@ -52,7 +52,6 @@ class GitConnectionController extends Controller $provider = GitProviderKey::from(Arr::get($validated, 'provider')); $user = $request->user(); - try { $gitProvider = $this->gitProviderManager->client($provider); $authenticatedUser = $gitProvider->getAuthenticatedUser( @@ -91,8 +90,6 @@ class GitConnectionController extends Controller $baseUrl = Arr::get($validated, 'base_url'); $provider = GitProviderKey::from(Arr::get($validated, 'provider')); - - try { $gitProvider = $this->gitProviderManager->client($provider); $authenticatedUser = $gitProvider->getAuthenticatedUser( diff --git a/app/Http/Requests/Settings/StoreUserGitConnectionRequest.php b/app/Http/Requests/Settings/StoreUserGitConnectionRequest.php index 8e4e70c..20f07ed 100644 --- a/app/Http/Requests/Settings/StoreUserGitConnectionRequest.php +++ b/app/Http/Requests/Settings/StoreUserGitConnectionRequest.php @@ -17,6 +17,7 @@ class StoreUserGitConnectionRequest extends FormRequest { return $this->user() !== null; } + protected function prepareForValidation(): void { $this->merge([ @@ -49,6 +50,7 @@ class StoreUserGitConnectionRequest extends FormRequest ))], ]; } + private function normalizedBaseUrl(): string { $baseUrl = Str::of((string) $this->input('base_url')) diff --git a/app/Http/Requests/Settings/UpdateUserGitConnectionRequest.php b/app/Http/Requests/Settings/UpdateUserGitConnectionRequest.php index 911fea2..f4a8348 100644 --- a/app/Http/Requests/Settings/UpdateUserGitConnectionRequest.php +++ b/app/Http/Requests/Settings/UpdateUserGitConnectionRequest.php @@ -26,6 +26,7 @@ class UpdateUserGitConnectionRequest extends FormRequest 'provider' => Str::lower(trim((string) $this->input('provider'))), ]); } + /** * Get the validation rules that apply to the request. * @@ -54,6 +55,7 @@ class UpdateUserGitConnectionRequest extends FormRequest ))], ]; } + private function normalizedBaseUrl(): string { $baseUrl = Str::of((string) $this->input('base_url')) diff --git a/app/Http/Requests/StoreProjectNamedSettingRequest.php b/app/Http/Requests/StoreProjectNamedSettingRequest.php index 137dbf2..25153de 100644 --- a/app/Http/Requests/StoreProjectNamedSettingRequest.php +++ b/app/Http/Requests/StoreProjectNamedSettingRequest.php @@ -27,6 +27,4 @@ class StoreProjectNamedSettingRequest extends FormRequest 'position' => ['nullable', 'integer', 'min:1'], ]; } - - } diff --git a/app/Http/Requests/StoreProjectTicketBranchRequest.php b/app/Http/Requests/StoreProjectTicketBranchRequest.php index d7dc682..2d3e10b 100644 --- a/app/Http/Requests/StoreProjectTicketBranchRequest.php +++ b/app/Http/Requests/StoreProjectTicketBranchRequest.php @@ -28,5 +28,3 @@ class StoreProjectTicketBranchRequest extends FormRequest ]; } } - - diff --git a/app/Http/Requests/StoreRepositoryConnectionRequest.php b/app/Http/Requests/StoreRepositoryConnectionRequest.php index d5ec8e2..221bb25 100644 --- a/app/Http/Requests/StoreRepositoryConnectionRequest.php +++ b/app/Http/Requests/StoreRepositoryConnectionRequest.php @@ -27,6 +27,4 @@ class StoreRepositoryConnectionRequest extends FormRequest 'user_git_connection_id' => ['required', 'integer', 'exists:user_git_connections,id'], ]; } - - } diff --git a/app/Http/Requests/StoreTicketFieldDefinitionRequest.php b/app/Http/Requests/StoreTicketFieldDefinitionRequest.php index bd09cfa..239f6a9 100644 --- a/app/Http/Requests/StoreTicketFieldDefinitionRequest.php +++ b/app/Http/Requests/StoreTicketFieldDefinitionRequest.php @@ -30,5 +30,4 @@ class StoreTicketFieldDefinitionRequest extends FormRequest 'position' => ['nullable', 'integer', 'min:1'], ]; } - } diff --git a/app/Http/Requests/SyncProjectPermissionsRequest.php b/app/Http/Requests/SyncProjectPermissionsRequest.php index ee397ee..b3c8bf6 100644 --- a/app/Http/Requests/SyncProjectPermissionsRequest.php +++ b/app/Http/Requests/SyncProjectPermissionsRequest.php @@ -33,5 +33,4 @@ class SyncProjectPermissionsRequest extends FormRequest ], ]; } - } diff --git a/app/Http/Requests/UpdateProjectNamedSettingRequest.php b/app/Http/Requests/UpdateProjectNamedSettingRequest.php index 68800ad..cb3f60c 100644 --- a/app/Http/Requests/UpdateProjectNamedSettingRequest.php +++ b/app/Http/Requests/UpdateProjectNamedSettingRequest.php @@ -27,6 +27,4 @@ class UpdateProjectNamedSettingRequest extends FormRequest 'position' => ['required', 'integer', 'min:1'], ]; } - - } diff --git a/app/Http/Requests/UpdateRepositoryConnectionRequest.php b/app/Http/Requests/UpdateRepositoryConnectionRequest.php index 48da785..f7e4a22 100644 --- a/app/Http/Requests/UpdateRepositoryConnectionRequest.php +++ b/app/Http/Requests/UpdateRepositoryConnectionRequest.php @@ -27,6 +27,4 @@ class UpdateRepositoryConnectionRequest extends FormRequest 'user_git_connection_id' => ['required', 'integer', 'exists:user_git_connections,id'], ]; } - - } diff --git a/app/Http/Requests/UpdateTeamMembersRequest.php b/app/Http/Requests/UpdateTeamMembersRequest.php index 680f1ab..2c2edd7 100644 --- a/app/Http/Requests/UpdateTeamMembersRequest.php +++ b/app/Http/Requests/UpdateTeamMembersRequest.php @@ -28,5 +28,4 @@ class UpdateTeamMembersRequest extends FormRequest 'user_ids.*' => ['integer', 'distinct', Rule::exists('users', 'id')], ]; } - } diff --git a/app/Http/Requests/UpdateTicketFieldDefinitionRequest.php b/app/Http/Requests/UpdateTicketFieldDefinitionRequest.php index 69147f0..dc8693d 100644 --- a/app/Http/Requests/UpdateTicketFieldDefinitionRequest.php +++ b/app/Http/Requests/UpdateTicketFieldDefinitionRequest.php @@ -30,5 +30,4 @@ class UpdateTicketFieldDefinitionRequest extends FormRequest 'position' => ['required', 'integer', 'min:1'], ]; } - }