feat(KAN-41): edit allowed status transitions

2026-09-15 16:05:06 +02:00
parent d2f659de8f
commit 208989d5fc
6 changed files with 544 additions and 93 deletions
@@ -298,6 +298,79 @@ class ProjectBoardSettingsControllerTest extends TestCase
        $this->assertCount(0, $sourceStatus->allowedTargetStatuses()->get());
    }

+    /**
+     * Ensure saved outgoing targets reach both consumers without changing the reverse direction.
+     */
+    public function test_saved_transition_subsets_and_empty_targets_are_reflected_in_ticket_and_board_responses(): void
+    {
+        $user = User::factory()->create();
+        $project = Project::factory()->create(['key' => 'CORE']);
+        $this->syncProjectPermissions($project, $user, ['edit']);
+        $column = BoardColumn::factory()->for($project)->create(['position' => 1]);
+        $sourceStatus = TicketStatus::factory()->for($project)->for($column)->create([
+            'name' => 'Progress',
+            'position' => 1,
+        ]);
+        $reviewStatus = TicketStatus::factory()->for($project)->create([
+            'name' => 'Review',
+            'position' => 2,
+        ]);
+        $doneStatus = TicketStatus::factory()->for($project)->create([
+            'name' => 'Done',
+            'position' => 3,
+        ]);
+        $ticket = Ticket::factory()->for($project)->create(['ticket_status_id' => $sourceStatus->id]);
+        $sourceStatus->allowedTargetStatuses()->sync([$reviewStatus->id, $doneStatus->id]);
+        $reviewStatus->allowedTargetStatuses()->sync([$sourceStatus->id]);
+
+        $this->actingAs($user)
+            ->patch(route('projects.settings.board.statuses.transitions.update', [$project, $sourceStatus]), [
+                'allowed_ticket_status_ids' => [$reviewStatus->id],
+            ])
+            ->assertRedirect(route('projects.settings.board', $project))
+            ->assertSessionHasNoErrors();
+
+        $this->assertSame([$reviewStatus->id], $sourceStatus->allowedTargetStatuses()->get()->modelKeys());
+        $this->assertSame([$sourceStatus->id], $reviewStatus->allowedTargetStatuses()->get()->modelKeys());
+
+        $this->withApplicationKey($user)
+            ->getJson(route('api.projects.tickets.status-targets', [$project, $ticket]))
+            ->assertOk()
+            ->assertJsonPath('data.current_status.id', $sourceStatus->id)
+            ->assertJsonCount(1, 'data.target_statuses')
+            ->assertJsonPath('data.target_statuses.0.id', $reviewStatus->id);
+
+        $this->get(route('projects.board.index', $project))
+            ->assertOk()
+            ->assertInertia(fn (Assert $page) => $page
+                ->component('projects/Board')
+                ->where('boardColumns.0.tickets.0.id', $ticket->id)
+                ->has('boardColumns.0.tickets.0.ticket_status.allowed_target_statuses', 1)
+                ->where('boardColumns.0.tickets.0.ticket_status.allowed_target_statuses.0.id', $reviewStatus->id),
+            );
+
+        $this->patch(route('projects.settings.board.statuses.transitions.update', [$project, $sourceStatus]), [
+            'allowed_ticket_status_ids' => [],
+        ])
+            ->assertRedirect(route('projects.settings.board', $project))
+            ->assertSessionHasNoErrors();
+
+        $this->assertCount(0, $sourceStatus->allowedTargetStatuses()->get());
+        $this->assertSame([$sourceStatus->id], $reviewStatus->allowedTargetStatuses()->get()->modelKeys());
+
+        $this->getJson(route('api.projects.tickets.status-targets', [$project, $ticket]))
+            ->assertOk()
+            ->assertJsonPath('data.target_statuses', []);
+
+        $this->get(route('projects.board.index', $project))
+            ->assertOk()
+            ->assertInertia(fn (Assert $page) => $page
+                ->component('projects/Board')
+                ->where('boardColumns.0.tickets.0.id', $ticket->id)
+                ->has('boardColumns.0.tickets.0.ticket_status.allowed_target_statuses', 0),
+            );
+    }
+
    /**
     * Ensure transition updates only accept targets from the same project and never the source status itself.
     */