DEleted function in request and changed the way the controller uses it,
linter / quality (pull_request) Successful in 1m13s
tests / ci (8.4) (pull_request) Failing after 1m15s

This commit is contained in:
Eric Peters
2026-04-03 16:50:00 +02:00
parent 2c1a0cbff3
commit 1c355c20b4
27 changed files with 285 additions and 263 deletions
@@ -17,6 +17,13 @@ class StoreUserGitConnectionRequest extends FormRequest
{
return $this->user() !== null;
}
protected function prepareForValidation(): void
{
$this->merge([
'base_url' => $this->normalizedBaseUrl(),
'provider' => Str::lower(trim((string) $this->input('provider'))),
]);
}
/**
* Get the validation rules that apply to the request.
@@ -42,30 +49,6 @@ class StoreUserGitConnectionRequest extends FormRequest
))],
];
}
protected function prepareForValidation(): void
{
$this->merge([
'base_url' => $this->normalizedBaseUrl(),
'provider' => Str::lower(trim((string) $this->input('provider'))),
]);
}
public function apiToken(): string
{
return (string) $this->validated('api_token');
}
public function baseUrl(): string
{
return (string) $this->validated('base_url');
}
public function provider(): GitProviderKey
{
return GitProviderKey::from((string) $this->validated('provider'));
}
private function normalizedBaseUrl(): string
{
$baseUrl = Str::of((string) $this->input('base_url'))
@@ -19,6 +19,13 @@ class UpdateUserGitConnectionRequest extends FormRequest
return $this->user() !== null;
}
protected function prepareForValidation(): void
{
$this->merge([
'base_url' => $this->normalizedBaseUrl(),
'provider' => Str::lower(trim((string) $this->input('provider'))),
]);
}
/**
* Get the validation rules that apply to the request.
*
@@ -47,30 +54,6 @@ class UpdateUserGitConnectionRequest extends FormRequest
))],
];
}
protected function prepareForValidation(): void
{
$this->merge([
'base_url' => $this->normalizedBaseUrl(),
'provider' => Str::lower(trim((string) $this->input('provider'))),
]);
}
public function apiToken(): string
{
return (string) $this->validated('api_token');
}
public function baseUrl(): string
{
return (string) $this->validated('base_url');
}
public function provider(): GitProviderKey
{
return GitProviderKey::from((string) $this->validated('provider'));
}
private function normalizedBaseUrl(): string
{
$baseUrl = Str::of((string) $this->input('base_url'))
@@ -28,14 +28,5 @@ class StoreProjectNamedSettingRequest extends FormRequest
];
}
public function position(): ?int
{
$position = $this->validated('position');
if ($position === null) {
return null;
}
return (int) $position;
}
}
@@ -27,14 +27,6 @@ class StoreProjectTicketBranchRequest extends FormRequest
'repository_connection_id' => ['required', 'integer', 'exists:repository_connections,id'],
];
}
public function branchName(): string
{
return trim((string) $this->validated('branch_name'));
}
public function repositoryConnectionId(): int
{
return (int) $this->validated('repository_connection_id');
}
}
@@ -28,13 +28,5 @@ class StoreRepositoryConnectionRequest extends FormRequest
];
}
public function providerRepositoryId(): string
{
return (string) $this->validated('provider_repository_id');
}
public function userGitConnectionId(): int
{
return (int) $this->validated('user_git_connection_id');
}
}
@@ -31,14 +31,4 @@ class StoreTicketFieldDefinitionRequest extends FormRequest
];
}
public function position(): ?int
{
$position = $this->validated('position');
if ($position === null) {
return null;
}
return (int) $position;
}
}
@@ -61,14 +61,4 @@ class StoreTicketLinkRequest extends FormRequest
},
];
}
public function linkedTicketId(): int
{
return (int) $this->validated('linked_ticket_id');
}
public function ticketLinkTypeId(): int
{
return (int) $this->validated('ticket_link_type_id');
}
}
@@ -33,15 +33,4 @@ class SyncProjectPermissionsRequest extends FormRequest
];
}
/**
* @return array<int, string>
*/
public function permissions(): array
{
return collect($this->validated('permissions', []))
->map(fn (mixed $permission): string => (string) $permission)
->unique()
->values()
->all();
}
}
@@ -28,8 +28,5 @@ class UpdateProjectNamedSettingRequest extends FormRequest
];
}
public function position(): int
{
return (int) $this->validated('position');
}
}
@@ -181,18 +181,6 @@ class UpdateProjectTicketRequest extends FormRequest
* value_user_id?: int|string|null
* }>
*/
public function fieldValues(): array
{
/** @var array<int, array{
* ticket_field_definition_id: int,
* value_number?: float|int|string|null,
* value_user_id?: int|string|null
* }> $fieldValues
*/
$fieldValues = $this->validated('field_values', []);
return $fieldValues;
}
private function createsCycle(Ticket $ticket, Ticket $candidateParent): bool
{
@@ -28,13 +28,5 @@ class UpdateRepositoryConnectionRequest extends FormRequest
];
}
public function providerRepositoryId(): string
{
return (string) $this->validated('provider_repository_id');
}
public function userGitConnectionId(): int
{
return (int) $this->validated('user_git_connection_id');
}
}
@@ -32,12 +32,4 @@ class UpdateTeamMembersRequest extends FormRequest
/**
* @return array<int, int>
*/
public function userIds(): array
{
return collect($this->validated('user_ids', []))
->map(fn (mixed $userId): int => (int) $userId)
->unique()
->values()
->all();
}
}
@@ -31,8 +31,4 @@ class UpdateTicketFieldDefinitionRequest extends FormRequest
];
}
public function position(): int
{
return (int) $this->validated('position');
}
}
@@ -27,14 +27,4 @@ class ValidateProjectTicketBranchRequest extends FormRequest
'repository_connection_id' => ['required', 'integer', 'exists:repository_connections,id'],
];
}
public function branchName(): string
{
return trim((string) $this->validated('branch_name'));
}
public function repositoryConnectionId(): int
{
return (int) $this->validated('repository_connection_id');
}
}