codex ticket rework
This commit is contained in:
@@ -11,6 +11,7 @@ use App\Models\TicketFieldValue;
|
||||
use App\Models\TicketLink;
|
||||
use App\Models\TicketLinkType;
|
||||
use App\Models\TicketPriority;
|
||||
use App\Models\TicketType;
|
||||
use App\Models\TicketWorklogEntry;
|
||||
use App\Models\User;
|
||||
use App\Models\UserGitConnection;
|
||||
@@ -29,19 +30,23 @@ class ProjectTicketControllerTest extends TestCase
|
||||
public function test_users_with_view_permission_can_view_ticket_details(): void
|
||||
{
|
||||
$viewer = User::factory()->create();
|
||||
$author = User::factory()->create([
|
||||
'name' => 'Author User',
|
||||
]);
|
||||
$assignee = User::factory()->create([
|
||||
'name' => 'Assigned User',
|
||||
]);
|
||||
$project = Project::factory()->create([
|
||||
'key' => 'CORE',
|
||||
'show_author' => false,
|
||||
]);
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = TicketPriority::factory()->for($project)->create([
|
||||
'name' => 'Medium',
|
||||
'position' => 1,
|
||||
]);
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
$fieldDefinition = TicketFieldDefinition::factory()->for($project)->create([
|
||||
'field_type' => 'number',
|
||||
'label' => 'Story Points',
|
||||
'label' => 'Complexity',
|
||||
'position' => 1,
|
||||
]);
|
||||
$ticketLinkType = TicketLinkType::factory()->for($project)->create([
|
||||
@@ -50,26 +55,30 @@ class ProjectTicketControllerTest extends TestCase
|
||||
]);
|
||||
|
||||
$ticket = Ticket::factory()->create([
|
||||
'assignee_user_id' => $assignee->id,
|
||||
'author_user_id' => $author->id,
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 1,
|
||||
'story_points' => 5,
|
||||
'ticket_key' => 'CORE-1',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
'title' => 'Ticket detail test',
|
||||
]);
|
||||
$linkedTicket = Ticket::factory()->create([
|
||||
'author_user_id' => $author->id,
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 2,
|
||||
'ticket_key' => 'CORE-2',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
'title' => 'Linked ticket',
|
||||
]);
|
||||
|
||||
TicketFieldValue::factory()->create([
|
||||
'ticket_field_definition_id' => $fieldDefinition->id,
|
||||
'ticket_id' => $ticket->id,
|
||||
'value_number' => 5,
|
||||
'value_number' => 3,
|
||||
'value_user_id' => null,
|
||||
]);
|
||||
TicketLink::factory()->create([
|
||||
@@ -81,7 +90,7 @@ class ProjectTicketControllerTest extends TestCase
|
||||
TicketWorklogEntry::factory()->create([
|
||||
'actor_id' => $viewer->id,
|
||||
'entry_type' => 'updated',
|
||||
'summary' => 'Updated Story Points field.',
|
||||
'summary' => 'Updated story points.',
|
||||
'ticket_id' => $ticket->id,
|
||||
]);
|
||||
|
||||
@@ -93,16 +102,62 @@ class ProjectTicketControllerTest extends TestCase
|
||||
->assertInertia(fn (Assert $page) => $page
|
||||
->component('projects/Ticket')
|
||||
->where('project.id', $project->id)
|
||||
->where('project.show_author', false)
|
||||
->where('ticket.ticket_key', 'CORE-1')
|
||||
->where('suggestedBranchName', 'core-1-ticket-detail-test')
|
||||
->where('ticket.field_values.0.ticket_field_definition.label', 'Story Points')
|
||||
->where('ticket.field_values.0.value_number', 5)
|
||||
->where('ticket.story_points', 5)
|
||||
->where('ticket.assignee.name', 'Assigned User')
|
||||
->where('ticket.author', null)
|
||||
->where('ticket.author_user_id', null)
|
||||
->where('ticket.field_values.0.ticket_field_definition.label', 'Complexity')
|
||||
->where('ticket.field_values.0.value_number', 3)
|
||||
->where('ticket.worklog_entries.0.actor.name', $viewer->name)
|
||||
->where('linkedTickets.0.linked_ticket.ticket_key', 'CORE-2')
|
||||
->where('linkedTickets.0.ticket_link_type.label', 'Relates to')
|
||||
->where('repositoryBranches', [])
|
||||
->where('repositoryPullRequests', [])
|
||||
->where('canEditTicket', false),
|
||||
->where('canEditTicket', false)
|
||||
->where('canManageProject', false),
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Ensure project admins can still inspect the author when project author visibility is disabled.
|
||||
*/
|
||||
public function test_project_admins_can_still_view_hidden_authors(): void
|
||||
{
|
||||
$admin = User::factory()->create();
|
||||
$author = User::factory()->create([
|
||||
'name' => 'Author User',
|
||||
]);
|
||||
$project = Project::factory()->create([
|
||||
'key' => 'CORE',
|
||||
'show_author' => false,
|
||||
]);
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
$ticket = Ticket::factory()->create([
|
||||
'author_user_id' => $author->id,
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 1,
|
||||
'story_points' => 5,
|
||||
'ticket_key' => 'CORE-1',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
'title' => 'Admin author visibility',
|
||||
]);
|
||||
|
||||
$this->syncProjectPermissions($project, $admin, ['admin', 'view']);
|
||||
|
||||
$this->actingAs($admin)
|
||||
->get(route('projects.tickets.show', [$project, $ticket]))
|
||||
->assertOk()
|
||||
->assertInertia(fn (Assert $page) => $page
|
||||
->component('projects/Ticket')
|
||||
->where('ticket.author.name', 'Author User')
|
||||
->where('ticket.author_user_id', $author->id)
|
||||
->where('canManageProject', true),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -160,17 +215,14 @@ class ProjectTicketControllerTest extends TestCase
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = TicketPriority::factory()->for($project)->create([
|
||||
'name' => 'Medium',
|
||||
'position' => 1,
|
||||
]);
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
|
||||
$ticket = Ticket::factory()->create([
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 1,
|
||||
'ticket_key' => 'CORE-1',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
'title' => 'Branch detail test',
|
||||
]);
|
||||
|
||||
@@ -232,45 +284,40 @@ class ProjectTicketControllerTest extends TestCase
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = TicketPriority::factory()->for($project)->create([
|
||||
'name' => 'Medium',
|
||||
'position' => 1,
|
||||
]);
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
|
||||
$ticket = Ticket::factory()->create([
|
||||
'project_id' => $project->id,
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
]);
|
||||
|
||||
$this->syncProjectPermissions($project, $viewer, ['view']);
|
||||
|
||||
$this->actingAs($viewer)
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), [
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
|
||||
'title' => 'Updated title',
|
||||
'description' => 'Updated description',
|
||||
'acceptance_criteria' => 'Updated criteria',
|
||||
'blocked_comment' => $ticket->blocked_comment,
|
||||
'is_blocked' => $ticket->is_blocked,
|
||||
'parent_ticket_id' => $ticket->parent_ticket_id,
|
||||
'ticket_type_id' => $ticket->ticket_type_id,
|
||||
'ticket_priority_id' => $ticket->ticket_priority_id,
|
||||
'field_values' => [],
|
||||
])
|
||||
]))
|
||||
->assertForbidden();
|
||||
}
|
||||
|
||||
/**
|
||||
* Ensure editing tracked ticket fields creates a worklog entry and persists field values.
|
||||
* Ensure editing ticket details persists fixed ticket fields and custom fields and creates a worklog entry.
|
||||
*/
|
||||
public function test_users_with_edit_permission_can_update_ticket_details_and_custom_fields(): void
|
||||
{
|
||||
$editor = User::factory()->create([
|
||||
'name' => 'Editor User',
|
||||
]);
|
||||
$author = User::factory()->create([
|
||||
'name' => 'Author User',
|
||||
]);
|
||||
$assignee = User::factory()->create([
|
||||
'name' => 'Assigned User',
|
||||
]);
|
||||
$reviewer = User::factory()->create([
|
||||
'name' => 'Reviewer User',
|
||||
]);
|
||||
$project = Project::factory()->create([
|
||||
'key' => 'CORE',
|
||||
]);
|
||||
@@ -279,73 +326,72 @@ class ProjectTicketControllerTest extends TestCase
|
||||
|
||||
$lowPriority = TicketPriority::factory()->for($project)->create([
|
||||
'name' => 'Low',
|
||||
'position' => 1,
|
||||
'position' => 2,
|
||||
]);
|
||||
$highPriority = TicketPriority::factory()->for($project)->create([
|
||||
'name' => 'High',
|
||||
'position' => 2,
|
||||
'position' => 3,
|
||||
]);
|
||||
|
||||
$assigneeField = TicketFieldDefinition::factory()->for($project)->create([
|
||||
$reviewerField = TicketFieldDefinition::factory()->for($project)->create([
|
||||
'field_type' => 'user',
|
||||
'label' => 'Assignee',
|
||||
'label' => 'Reviewer',
|
||||
'position' => 1,
|
||||
]);
|
||||
$storyPointsField = TicketFieldDefinition::factory()->for($project)->create([
|
||||
$complexityField = TicketFieldDefinition::factory()->for($project)->create([
|
||||
'field_type' => 'number',
|
||||
'label' => 'Story Points',
|
||||
'label' => 'Complexity',
|
||||
'position' => 2,
|
||||
]);
|
||||
|
||||
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
|
||||
$parentType = $project->ticketTypes()->where('system_key', 'parent')->firstOrFail();
|
||||
|
||||
$ticket = Ticket::factory()->create([
|
||||
'acceptance_criteria' => 'Old acceptance criteria',
|
||||
'author_user_id' => $author->id,
|
||||
'description' => 'Old description',
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 1,
|
||||
'story_points' => 3,
|
||||
'ticket_key' => 'CORE-1',
|
||||
'ticket_priority_id' => $lowPriority->id,
|
||||
'ticket_type_id' => $taskType->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
'title' => 'Old title',
|
||||
]);
|
||||
|
||||
TicketFieldValue::factory()->create([
|
||||
'ticket_field_definition_id' => $assigneeField->id,
|
||||
'ticket_field_definition_id' => $reviewerField->id,
|
||||
'ticket_id' => $ticket->id,
|
||||
'value_number' => null,
|
||||
'value_user_id' => $editor->id,
|
||||
]);
|
||||
TicketFieldValue::factory()->create([
|
||||
'ticket_field_definition_id' => $storyPointsField->id,
|
||||
'ticket_field_definition_id' => $complexityField->id,
|
||||
'ticket_id' => $ticket->id,
|
||||
'value_number' => 3,
|
||||
'value_number' => 2,
|
||||
'value_user_id' => null,
|
||||
]);
|
||||
|
||||
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
|
||||
$this->syncProjectPermissions($project, $editor, ['write', 'view']);
|
||||
|
||||
$this->actingAs($editor)
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), [
|
||||
'title' => 'Updated title',
|
||||
'description' => 'Updated description',
|
||||
'acceptance_criteria' => 'Updated acceptance criteria',
|
||||
'assignee_user_id' => $assignee->id,
|
||||
'blocked_comment' => $ticket->blocked_comment,
|
||||
'is_blocked' => $ticket->is_blocked,
|
||||
'parent_ticket_id' => $ticket->parent_ticket_id,
|
||||
'ticket_type_id' => $parentType->id,
|
||||
'ticket_priority_id' => $highPriority->id,
|
||||
'description' => 'Updated description',
|
||||
'field_values' => [
|
||||
[
|
||||
'ticket_field_definition_id' => $assigneeField->id,
|
||||
'value_user_id' => $assignee->id,
|
||||
'ticket_field_definition_id' => $reviewerField->id,
|
||||
'value_user_id' => $reviewer->id,
|
||||
],
|
||||
[
|
||||
'ticket_field_definition_id' => $storyPointsField->id,
|
||||
'ticket_field_definition_id' => $complexityField->id,
|
||||
'value_number' => 8,
|
||||
],
|
||||
],
|
||||
'is_blocked' => $ticket->is_blocked,
|
||||
'parent_ticket_id' => $ticket->parent_ticket_id,
|
||||
'story_points' => 8,
|
||||
'ticket_priority_id' => $highPriority->id,
|
||||
'ticket_type_id' => $this->parentType($project)->id,
|
||||
'title' => 'Updated title',
|
||||
])
|
||||
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
|
||||
->assertSessionHas('status', 'CORE-1 was updated.');
|
||||
@@ -355,27 +401,26 @@ class ProjectTicketControllerTest extends TestCase
|
||||
'title' => 'Updated title',
|
||||
'description' => 'Updated description',
|
||||
'acceptance_criteria' => 'Updated acceptance criteria',
|
||||
'ticket_type_id' => $parentType->id,
|
||||
'assignee_user_id' => $assignee->id,
|
||||
'story_points' => 8,
|
||||
'ticket_type_id' => $this->parentType($project)->id,
|
||||
'ticket_priority_id' => $highPriority->id,
|
||||
]);
|
||||
|
||||
$this->assertDatabaseHas('ticket_field_values', [
|
||||
'ticket_id' => $ticket->id,
|
||||
'ticket_field_definition_id' => $assigneeField->id,
|
||||
'value_user_id' => $assignee->id,
|
||||
'ticket_field_definition_id' => $reviewerField->id,
|
||||
'value_user_id' => $reviewer->id,
|
||||
]);
|
||||
|
||||
$this->assertDatabaseHas('ticket_field_values', [
|
||||
'ticket_id' => $ticket->id,
|
||||
'ticket_field_definition_id' => $storyPointsField->id,
|
||||
'ticket_field_definition_id' => $complexityField->id,
|
||||
'value_number' => 8.0,
|
||||
]);
|
||||
|
||||
$this->assertDatabaseHas('ticket_worklog_entries', [
|
||||
'ticket_id' => $ticket->id,
|
||||
'actor_id' => $editor->id,
|
||||
'entry_type' => 'updated',
|
||||
'summary' => 'Updated title, description, acceptance criteria, type, priority, Assignee field, and Story Points field.',
|
||||
'summary' => 'Updated title, description, acceptance criteria, story points, type, priority, assignee, Reviewer field, and Complexity field.',
|
||||
]);
|
||||
}
|
||||
|
||||
@@ -391,12 +436,8 @@ class ProjectTicketControllerTest extends TestCase
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = TicketPriority::factory()->for($project)->create([
|
||||
'name' => 'Medium',
|
||||
'position' => 1,
|
||||
]);
|
||||
|
||||
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
$taskType = $this->nonParentType($project);
|
||||
|
||||
$candidateParent = Ticket::factory()->create([
|
||||
'project_id' => $project->id,
|
||||
@@ -406,7 +447,6 @@ class ProjectTicketControllerTest extends TestCase
|
||||
'ticket_type_id' => $taskType->id,
|
||||
'title' => 'Task ticket',
|
||||
]);
|
||||
|
||||
$childTicket = Ticket::factory()->create([
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 2,
|
||||
@@ -420,17 +460,9 @@ class ProjectTicketControllerTest extends TestCase
|
||||
|
||||
$this->actingAs($editor)
|
||||
->from(route('projects.tickets.show', [$project, $childTicket]))
|
||||
->patch(route('projects.tickets.update', [$project, $childTicket]), [
|
||||
'title' => $childTicket->title,
|
||||
'description' => $childTicket->description,
|
||||
'acceptance_criteria' => $childTicket->acceptance_criteria,
|
||||
'blocked_comment' => $childTicket->blocked_comment,
|
||||
'is_blocked' => $childTicket->is_blocked,
|
||||
->patch(route('projects.tickets.update', [$project, $childTicket]), $this->updatePayload($childTicket, [
|
||||
'parent_ticket_id' => $candidateParent->id,
|
||||
'ticket_type_id' => $childTicket->ticket_type_id,
|
||||
'ticket_priority_id' => $childTicket->ticket_priority_id,
|
||||
'field_values' => [],
|
||||
])
|
||||
]))
|
||||
->assertRedirect(route('projects.tickets.show', [$project, $childTicket]))
|
||||
->assertSessionHasErrors('parent_ticket_id');
|
||||
}
|
||||
@@ -447,46 +479,31 @@ class ProjectTicketControllerTest extends TestCase
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = TicketPriority::factory()->for($project)->create([
|
||||
'name' => 'Medium',
|
||||
'position' => 1,
|
||||
]);
|
||||
|
||||
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
|
||||
$parentType = $project->ticketTypes()->where('system_key', 'parent')->firstOrFail();
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
|
||||
$parentTicket = Ticket::factory()->create([
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 1,
|
||||
'ticket_key' => 'CORE-1',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $parentType->id,
|
||||
'ticket_type_id' => $this->parentType($project)->id,
|
||||
'title' => 'Parent ticket',
|
||||
]);
|
||||
|
||||
$childTicket = Ticket::factory()->create([
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 2,
|
||||
'ticket_key' => 'CORE-2',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $taskType->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
'title' => 'Child ticket',
|
||||
]);
|
||||
|
||||
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
|
||||
|
||||
$this->actingAs($editor)
|
||||
->patch(route('projects.tickets.update', [$project, $childTicket]), [
|
||||
'title' => $childTicket->title,
|
||||
'description' => $childTicket->description,
|
||||
'acceptance_criteria' => $childTicket->acceptance_criteria,
|
||||
'blocked_comment' => $childTicket->blocked_comment,
|
||||
'is_blocked' => $childTicket->is_blocked,
|
||||
->patch(route('projects.tickets.update', [$project, $childTicket]), $this->updatePayload($childTicket, [
|
||||
'parent_ticket_id' => $parentTicket->id,
|
||||
'ticket_type_id' => $childTicket->ticket_type_id,
|
||||
'ticket_priority_id' => $childTicket->ticket_priority_id,
|
||||
'field_values' => [],
|
||||
])
|
||||
]))
|
||||
->assertRedirect(route('projects.tickets.show', [$project, $childTicket]))
|
||||
->assertSessionHas('status', 'CORE-2 was updated.');
|
||||
|
||||
@@ -494,7 +511,6 @@ class ProjectTicketControllerTest extends TestCase
|
||||
'id' => $childTicket->id,
|
||||
'parent_ticket_id' => $parentTicket->id,
|
||||
]);
|
||||
|
||||
$this->assertDatabaseHas('ticket_worklog_entries', [
|
||||
'ticket_id' => $childTicket->id,
|
||||
'actor_id' => $editor->id,
|
||||
@@ -503,6 +519,46 @@ class ProjectTicketControllerTest extends TestCase
|
||||
]);
|
||||
}
|
||||
|
||||
/**
|
||||
* Ensure tickets with children must remain parent-enabled.
|
||||
*/
|
||||
public function test_tickets_with_children_must_keep_a_parent_enabled_type(): void
|
||||
{
|
||||
$editor = User::factory()->create();
|
||||
$project = Project::factory()->create();
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
$parentTicket = Ticket::factory()->create([
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 1,
|
||||
'ticket_key' => 'CORE-1',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $this->parentType($project)->id,
|
||||
'title' => 'Parent ticket',
|
||||
]);
|
||||
Ticket::factory()->create([
|
||||
'parent_ticket_id' => $parentTicket->id,
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 2,
|
||||
'ticket_key' => 'CORE-2',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
'title' => 'Child ticket',
|
||||
]);
|
||||
|
||||
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
|
||||
|
||||
$this->actingAs($editor)
|
||||
->from(route('projects.tickets.show', [$project, $parentTicket]))
|
||||
->patch(route('projects.tickets.update', [$project, $parentTicket]), $this->updatePayload($parentTicket, [
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
]))
|
||||
->assertRedirect(route('projects.tickets.show', [$project, $parentTicket]))
|
||||
->assertSessionHasErrors('ticket_type_id');
|
||||
}
|
||||
|
||||
/**
|
||||
* Ensure parent ticket detail pages show nested child trees.
|
||||
*/
|
||||
@@ -515,50 +571,41 @@ class ProjectTicketControllerTest extends TestCase
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = TicketPriority::factory()->for($project)->create([
|
||||
'name' => 'Medium',
|
||||
'position' => 1,
|
||||
]);
|
||||
|
||||
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
|
||||
$parentType = $project->ticketTypes()->where('system_key', 'parent')->firstOrFail();
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
|
||||
$rootParent = Ticket::factory()->create([
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 1,
|
||||
'ticket_key' => 'CORE-1',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $parentType->id,
|
||||
'ticket_type_id' => $this->parentType($project)->id,
|
||||
'title' => 'Root parent',
|
||||
]);
|
||||
|
||||
$nestedParent = Ticket::factory()->create([
|
||||
'parent_ticket_id' => $rootParent->id,
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 2,
|
||||
'ticket_key' => 'CORE-2',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $parentType->id,
|
||||
'ticket_type_id' => $this->parentType($project)->id,
|
||||
'title' => 'Nested parent',
|
||||
]);
|
||||
|
||||
$directTask = Ticket::factory()->create([
|
||||
'parent_ticket_id' => $rootParent->id,
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 3,
|
||||
'ticket_key' => 'CORE-3',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $taskType->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
'title' => 'Direct task',
|
||||
]);
|
||||
|
||||
$nestedTask = Ticket::factory()->create([
|
||||
'parent_ticket_id' => $nestedParent->id,
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 4,
|
||||
'ticket_key' => 'CORE-4',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $taskType->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
'title' => 'Nested task',
|
||||
]);
|
||||
|
||||
@@ -585,31 +632,21 @@ class ProjectTicketControllerTest extends TestCase
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = TicketPriority::factory()->for($project)->create([
|
||||
'name' => 'Medium',
|
||||
'position' => 1,
|
||||
]);
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
$ticket = Ticket::factory()->create([
|
||||
'project_id' => $project->id,
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
]);
|
||||
|
||||
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
|
||||
|
||||
$this->actingAs($editor)
|
||||
->from(route('projects.tickets.show', [$project, $ticket]))
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), [
|
||||
'title' => $ticket->title,
|
||||
'description' => $ticket->description,
|
||||
'acceptance_criteria' => $ticket->acceptance_criteria,
|
||||
'ticket_type_id' => $ticket->ticket_type_id,
|
||||
'ticket_priority_id' => $ticket->ticket_priority_id,
|
||||
'parent_ticket_id' => $ticket->parent_ticket_id,
|
||||
'is_blocked' => true,
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
|
||||
'blocked_comment' => '',
|
||||
'field_values' => [],
|
||||
])
|
||||
'is_blocked' => true,
|
||||
]))
|
||||
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
|
||||
->assertSessionHasErrors('blocked_comment');
|
||||
|
||||
@@ -632,32 +669,22 @@ class ProjectTicketControllerTest extends TestCase
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = TicketPriority::factory()->for($project)->create([
|
||||
'name' => 'Medium',
|
||||
'position' => 1,
|
||||
]);
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
$ticket = Ticket::factory()->create([
|
||||
'project_id' => $project->id,
|
||||
'sequence_number' => 1,
|
||||
'ticket_key' => 'CORE-1',
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
]);
|
||||
|
||||
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
|
||||
|
||||
$this->actingAs($editor)
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), [
|
||||
'title' => $ticket->title,
|
||||
'description' => $ticket->description,
|
||||
'acceptance_criteria' => $ticket->acceptance_criteria,
|
||||
'ticket_type_id' => $ticket->ticket_type_id,
|
||||
'ticket_priority_id' => $ticket->ticket_priority_id,
|
||||
'parent_ticket_id' => $ticket->parent_ticket_id,
|
||||
'is_blocked' => true,
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
|
||||
'blocked_comment' => 'Waiting for dependency approval.',
|
||||
'field_values' => [],
|
||||
])
|
||||
'is_blocked' => true,
|
||||
]))
|
||||
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
|
||||
->assertSessionHas('status', 'CORE-1 was updated.');
|
||||
|
||||
@@ -666,7 +693,6 @@ class ProjectTicketControllerTest extends TestCase
|
||||
'is_blocked' => true,
|
||||
'blocked_comment' => 'Waiting for dependency approval.',
|
||||
]);
|
||||
|
||||
$this->assertDatabaseHas('ticket_worklog_entries', [
|
||||
'ticket_id' => $ticket->id,
|
||||
'actor_id' => $editor->id,
|
||||
@@ -675,17 +701,10 @@ class ProjectTicketControllerTest extends TestCase
|
||||
]);
|
||||
|
||||
$this->actingAs($editor)
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), [
|
||||
'title' => $ticket->title,
|
||||
'description' => $ticket->description,
|
||||
'acceptance_criteria' => $ticket->acceptance_criteria,
|
||||
'ticket_type_id' => $ticket->ticket_type_id,
|
||||
'ticket_priority_id' => $ticket->ticket_priority_id,
|
||||
'parent_ticket_id' => $ticket->parent_ticket_id,
|
||||
'is_blocked' => false,
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
|
||||
'blocked_comment' => '',
|
||||
'field_values' => [],
|
||||
])
|
||||
'is_blocked' => false,
|
||||
]))
|
||||
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
|
||||
->assertSessionHas('status', 'CORE-1 was updated.');
|
||||
|
||||
@@ -694,7 +713,6 @@ class ProjectTicketControllerTest extends TestCase
|
||||
'is_blocked' => false,
|
||||
'blocked_comment' => null,
|
||||
]);
|
||||
|
||||
$this->assertSame(
|
||||
2,
|
||||
TicketWorklogEntry::query()
|
||||
@@ -704,4 +722,120 @@ class ProjectTicketControllerTest extends TestCase
|
||||
->count(),
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Ensure non-admin users cannot change the fixed author.
|
||||
*/
|
||||
public function test_non_admin_users_cannot_change_the_ticket_author(): void
|
||||
{
|
||||
$editor = User::factory()->create();
|
||||
$originalAuthor = User::factory()->create();
|
||||
$replacementAuthor = User::factory()->create();
|
||||
$project = Project::factory()->create();
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
$ticket = Ticket::factory()->create([
|
||||
'author_user_id' => $originalAuthor->id,
|
||||
'project_id' => $project->id,
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
]);
|
||||
|
||||
$this->syncProjectPermissions($project, $editor, ['write', 'view']);
|
||||
|
||||
$this->actingAs($editor)
|
||||
->from(route('projects.tickets.show', [$project, $ticket]))
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
|
||||
'author_user_id' => $replacementAuthor->id,
|
||||
]))
|
||||
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
|
||||
->assertSessionHasErrors('author_user_id');
|
||||
|
||||
$this->assertDatabaseHas('tickets', [
|
||||
'id' => $ticket->id,
|
||||
'author_user_id' => $originalAuthor->id,
|
||||
]);
|
||||
}
|
||||
|
||||
/**
|
||||
* Ensure project admins can change the fixed author.
|
||||
*/
|
||||
public function test_project_admins_can_change_the_ticket_author(): void
|
||||
{
|
||||
$admin = User::factory()->create();
|
||||
$originalAuthor = User::factory()->create();
|
||||
$replacementAuthor = User::factory()->create([
|
||||
'name' => 'Replacement Author',
|
||||
]);
|
||||
$project = Project::factory()->create();
|
||||
|
||||
app(InitializeProjectTicketMetadata::class)->handle($project);
|
||||
|
||||
$priority = $project->ticketPriorities()->firstOrFail();
|
||||
$ticket = Ticket::factory()->create([
|
||||
'author_user_id' => $originalAuthor->id,
|
||||
'project_id' => $project->id,
|
||||
'ticket_priority_id' => $priority->id,
|
||||
'ticket_type_id' => $this->nonParentType($project)->id,
|
||||
]);
|
||||
|
||||
$this->syncProjectPermissions($project, $admin, ['admin', 'view']);
|
||||
|
||||
$this->actingAs($admin)
|
||||
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
|
||||
'author_user_id' => $replacementAuthor->id,
|
||||
]))
|
||||
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
|
||||
->assertSessionHas('status', "{$ticket->ticket_key} was updated.");
|
||||
|
||||
$this->assertDatabaseHas('tickets', [
|
||||
'id' => $ticket->id,
|
||||
'author_user_id' => $replacementAuthor->id,
|
||||
]);
|
||||
$this->assertDatabaseHas('ticket_worklog_entries', [
|
||||
'ticket_id' => $ticket->id,
|
||||
'actor_id' => $admin->id,
|
||||
'entry_type' => 'updated',
|
||||
'summary' => 'Updated author.',
|
||||
]);
|
||||
}
|
||||
|
||||
private function nonParentType(Project $project): TicketType
|
||||
{
|
||||
return $project->ticketTypes()
|
||||
->where('is_parent', false)
|
||||
->orderBy('position')
|
||||
->firstOrFail();
|
||||
}
|
||||
|
||||
private function parentType(Project $project): TicketType
|
||||
{
|
||||
return $project->ticketTypes()
|
||||
->where('is_parent', true)
|
||||
->orderBy('position')
|
||||
->firstOrFail();
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array<string, mixed>
|
||||
*/
|
||||
private function updatePayload(Ticket $ticket, array $overrides = []): array
|
||||
{
|
||||
return array_merge([
|
||||
'acceptance_criteria' => $ticket->acceptance_criteria,
|
||||
'assignee_user_id' => $ticket->assignee_user_id,
|
||||
'author_user_id' => $ticket->author_user_id,
|
||||
'blocked_comment' => $ticket->blocked_comment,
|
||||
'description' => $ticket->description,
|
||||
'field_values' => [],
|
||||
'is_blocked' => $ticket->is_blocked,
|
||||
'parent_ticket_id' => $ticket->parent_ticket_id,
|
||||
'story_points' => $ticket->story_points,
|
||||
'ticket_priority_id' => $ticket->ticket_priority_id,
|
||||
'ticket_type_id' => $ticket->ticket_type_id,
|
||||
'title' => $ticket->title,
|
||||
], $overrides);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user