codex ticket rework

tests/Feature/Models/BoardColumnTest.php

@@ -6,7 +6,6 @@ use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
 use App\Models\BoardColumn;
 use App\Models\Project;
 use App\Models\Ticket;
-use App\Models\TicketPriority;
 use Database\Seeders\BoardColumnSeeder;
 use Database\Seeders\ProjectSeeder;
 use Illuminate\Foundation\Testing\RefreshDatabase;
@@ -64,10 +63,7 @@ class BoardColumnTest extends TestCase
 
         app(InitializeProjectTicketMetadata::class)->handle($project);
 
-        $priority = TicketPriority::factory()->for($project)->create([
-            'name' => 'Medium',
-            'position' => 1,
-        ]);
+        $priority = $project->ticketPriorities()->firstOrFail();
 
         $boardColumn = BoardColumn::factory()->for($project)->create([
             'name' => 'Doing',

tests/Feature/Models/ProjectTest.php

@@ -109,7 +109,7 @@ class ProjectTest extends TestCase
         $coreProject = Project::query()->where('key', 'CORE')->firstOrFail();
 
         $this->assertSame(
-            ['Task', 'Parent', 'Bug'],
+            ['Task', 'Release', 'Bug'],
             $coreProject->ticketTypes->pluck('name')->all(),
         );
 
@@ -118,10 +118,7 @@ class ProjectTest extends TestCase
             $coreProject->ticketPriorities->pluck('name')->all(),
         );
 
-        $this->assertSame(
-            ['Assignee', 'Story Points'],
-            $coreProject->ticketFieldDefinitions->pluck('label')->all(),
-        );
+        $this->assertSame([], $coreProject->ticketFieldDefinitions->pluck('label')->all());
     }
 
     /**

tests/Feature/Models/TicketFieldDefinitionTest.php

@@ -7,7 +7,6 @@ use App\Models\Project;
 use App\Models\Ticket;
 use App\Models\TicketFieldDefinition;
 use App\Models\TicketFieldValue;
-use App\Models\TicketPriority;
 use Database\Seeders\ProjectSeeder;
 use Database\Seeders\ProjectTicketMetadataSeeder;
 use Illuminate\Foundation\Testing\RefreshDatabase;
@@ -33,7 +32,7 @@ class TicketFieldDefinitionTest extends TestCase
     /**
      * Ensure the metadata seeder creates project field definitions.
      */
-    public function test_metadata_seeder_creates_ticket_field_definitions(): void
+    public function test_metadata_seeder_does_not_create_fixed_ticket_field_definitions(): void
     {
         $this->seed([
             ProjectSeeder::class,
@@ -42,19 +41,7 @@ class TicketFieldDefinitionTest extends TestCase
 
         $coreProject = Project::query()->where('key', 'CORE')->firstOrFail();
 
-        $this->assertDatabaseHas('ticket_field_definitions', [
-            'project_id' => $coreProject->id,
-            'label' => 'Assignee',
-            'field_type' => 'user',
-            'position' => 1,
-        ]);
-
-        $this->assertDatabaseHas('ticket_field_definitions', [
-            'project_id' => $coreProject->id,
-            'label' => 'Story Points',
-            'field_type' => 'number',
-            'position' => 2,
-        ]);
+        $this->assertSame(0, $coreProject->ticketFieldDefinitions()->count());
     }
 
     /**
@@ -68,10 +55,7 @@ class TicketFieldDefinitionTest extends TestCase
 
         app(InitializeProjectTicketMetadata::class)->handle($project);
 
-        $priority = TicketPriority::factory()->for($project)->create([
-            'name' => 'Medium',
-            'position' => 1,
-        ]);
+        $priority = $project->ticketPriorities()->firstOrFail();
 
         $ticket = Ticket::factory()->create([
             'project_id' => $project->id,
@@ -81,7 +65,7 @@ class TicketFieldDefinitionTest extends TestCase
 
         $fieldDefinition = TicketFieldDefinition::factory()->for($project)->create([
             'field_type' => 'number',
-            'label' => 'Story Points',
+            'label' => 'Complexity',
             'position' => 1,
         ]);
 

tests/Feature/Models/TicketLinkTest.php

@@ -7,7 +7,6 @@ use App\Models\Project;
 use App\Models\Ticket;
 use App\Models\TicketLink;
 use App\Models\TicketLinkType;
-use App\Models\TicketPriority;
 use Database\Seeders\ProjectSeeder;
 use Database\Seeders\ProjectTicketMetadataSeeder;
 use Database\Seeders\TicketLinkSeeder;
@@ -31,11 +30,11 @@ class TicketLinkTest extends TestCase
 
         app(InitializeProjectTicketMetadata::class)->handle($project);
 
-        $priority = TicketPriority::factory()->for($project)->create([
-            'name' => 'Medium',
-            'position' => 1,
-        ]);
-        $taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
+        $priority = $project->ticketPriorities()->firstOrFail();
+        $taskType = $project->ticketTypes()
+            ->where('is_parent', false)
+            ->orderBy('position')
+            ->firstOrFail();
 
         $firstTicket = Ticket::factory()->create([
             'project_id' => $project->id,

tests/Feature/Models/TicketTest.php

@@ -9,8 +9,8 @@ use App\Models\TicketFieldDefinition;
 use App\Models\TicketFieldValue;
 use App\Models\TicketLink;
 use App\Models\TicketLinkType;
-use App\Models\TicketPriority;
 use App\Models\TicketWorklogEntry;
+use App\Models\User;
 use Database\Seeders\BoardColumnSeeder;
 use Database\Seeders\ProjectSeeder;
 use Database\Seeders\ProjectTicketMetadataSeeder;
@@ -96,10 +96,7 @@ class TicketTest extends TestCase
 
         app(InitializeProjectTicketMetadata::class)->handle($project);
 
-        $priority = TicketPriority::factory()->for($project)->create([
-            'name' => 'Medium',
-            'position' => 1,
-        ]);
+        $priority = $project->ticketPriorities()->firstOrFail();
 
         $ticket = Ticket::factory()->create([
             'project_id' => $project->id,
@@ -111,7 +108,7 @@ class TicketTest extends TestCase
 
         $fieldDefinition = TicketFieldDefinition::factory()->for($project)->create([
             'field_type' => 'number',
-            'label' => 'Story Points',
+            'label' => 'Complexity',
             'position' => 1,
         ]);
 
@@ -139,13 +136,16 @@ class TicketTest extends TestCase
 
         app(InitializeProjectTicketMetadata::class)->handle($project);
 
-        $priority = TicketPriority::factory()->for($project)->create([
-            'name' => 'Medium',
-            'position' => 1,
-        ]);
+        $priority = $project->ticketPriorities()->firstOrFail();
 
-        $taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
-        $parentType = $project->ticketTypes()->where('system_key', 'parent')->firstOrFail();
+        $taskType = $project->ticketTypes()
+            ->where('is_parent', false)
+            ->orderBy('position')
+            ->firstOrFail();
+        $parentType = $project->ticketTypes()
+            ->where('is_parent', true)
+            ->orderBy('position')
+            ->firstOrFail();
 
         $parentTicket = Ticket::factory()->create([
             'project_id' => $project->id,
@@ -184,6 +184,22 @@ class TicketTest extends TestCase
         $this->assertSame('Waiting for environment access.', $freshTicket->blocked_comment);
     }
 
+    /**
+     * Ensure tickets expose their fixed assignee and author relations.
+     */
+    public function test_ticket_assignee_and_author_relations_are_available(): void
+    {
+        $assignee = User::factory()->create();
+        $author = User::factory()->create();
+        $ticket = Ticket::factory()->create([
+            'assignee_user_id' => $assignee->id,
+            'author_user_id' => $author->id,
+        ]);
+
+        $this->assertSame($assignee->id, $ticket->fresh()->assignee?->id);
+        $this->assertSame($author->id, $ticket->fresh()->author?->id);
+    }
+
     /**
      * Ensure tickets expose incoming and outgoing link relations.
      */
@@ -195,11 +211,11 @@ class TicketTest extends TestCase
 
         app(InitializeProjectTicketMetadata::class)->handle($project);
 
-        $priority = TicketPriority::factory()->for($project)->create([
-            'name' => 'Medium',
-            'position' => 1,
-        ]);
-        $taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
+        $priority = $project->ticketPriorities()->firstOrFail();
+        $taskType = $project->ticketTypes()
+            ->where('is_parent', false)
+            ->orderBy('position')
+            ->firstOrFail();
 
         $sourceTicket = Ticket::factory()->create([
             'project_id' => $project->id,

tests/Feature/Models/TicketTypeTest.php

@@ -20,14 +20,13 @@ class TicketTypeTest extends TestCase
     {
         $ticketType = TicketType::factory()->create();
 
-        $this->assertFalse($ticketType->is_builtin);
-        $this->assertNull($ticketType->system_key);
+        $this->assertFalse($ticketType->is_parent);
     }
 
     /**
-     * Ensure the metadata seeder creates the required built-in types for projects.
+     * Ensure the metadata seeder creates the expected starter types for projects.
      */
-    public function test_metadata_seeder_creates_builtin_task_and_parent_types(): void
+    public function test_metadata_seeder_creates_task_release_and_bug_types(): void
     {
         $this->seed([
             ProjectSeeder::class,
@@ -39,17 +38,22 @@ class TicketTypeTest extends TestCase
         $this->assertDatabaseHas('ticket_types', [
             'project_id' => $coreProject->id,
             'name' => 'Task',
-            'system_key' => 'task',
-            'is_builtin' => true,
+            'is_parent' => false,
             'position' => 1,
         ]);
 
         $this->assertDatabaseHas('ticket_types', [
             'project_id' => $coreProject->id,
-            'name' => 'Parent',
-            'system_key' => 'parent',
-            'is_builtin' => true,
+            'name' => 'Release',
+            'is_parent' => true,
             'position' => 2,
         ]);
+
+        $this->assertDatabaseHas('ticket_types', [
+            'project_id' => $coreProject->id,
+            'name' => 'Bug',
+            'is_parent' => false,
+            'position' => 3,
+        ]);
     }
 }