PetschStudios/KanbanGit
3
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 24 Wiki Activity

codex ticket rework

Browse Source
This commit is contained in:
Twyco
2026-04-13 01:04:06 +02:00
parent b3f2cc3afd
commit 182ed018d1
45 changed files with 1208 additions and 420 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Feature/Models/BoardColumnTest.php
+1 -5
View File
@@ -6,7 +6,6 @@ use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
use App\Models\BoardColumn;
use App\Models\Project;
use App\Models\Ticket;
use App\Models\TicketPriority;
use Database\Seeders\BoardColumnSeeder;
use Database\Seeders\ProjectSeeder;
use Illuminate\Foundation\Testing\RefreshDatabase;
@@ -64,10 +63,7 @@ class BoardColumnTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$boardColumn = BoardColumn::factory()->for($project)->create([
'name' => 'Doing',
tests/Feature/Models/ProjectTest.php
+2 -5
View File
@@ -109,7 +109,7 @@ class ProjectTest extends TestCase
$coreProject = Project::query()->where('key', 'CORE')->firstOrFail();
$this->assertSame(
['Task', 'Parent', 'Bug'],
['Task', 'Release', 'Bug'],
$coreProject->ticketTypes->pluck('name')->all(),
);
@@ -118,10 +118,7 @@ class ProjectTest extends TestCase
$coreProject->ticketPriorities->pluck('name')->all(),
);
$this->assertSame(
['Assignee', 'Story Points'],
$coreProject->ticketFieldDefinitions->pluck('label')->all(),
);
$this->assertSame([], $coreProject->ticketFieldDefinitions->pluck('label')->all());
}
/**
tests/Feature/Models/TicketFieldDefinitionTest.php
+4 -20
View File
@@ -7,7 +7,6 @@ use App\Models\Project;
use App\Models\Ticket;
use App\Models\TicketFieldDefinition;
use App\Models\TicketFieldValue;
use App\Models\TicketPriority;
use Database\Seeders\ProjectSeeder;
use Database\Seeders\ProjectTicketMetadataSeeder;
use Illuminate\Foundation\Testing\RefreshDatabase;
@@ -33,7 +32,7 @@ class TicketFieldDefinitionTest extends TestCase
/**
* Ensure the metadata seeder creates project field definitions.
*/
public function test_metadata_seeder_creates_ticket_field_definitions(): void
public function test_metadata_seeder_does_not_create_fixed_ticket_field_definitions(): void
{
$this->seed([
ProjectSeeder::class,
@@ -42,19 +41,7 @@ class TicketFieldDefinitionTest extends TestCase
$coreProject = Project::query()->where('key', 'CORE')->firstOrFail();
$this->assertDatabaseHas('ticket_field_definitions', [
'project_id' => $coreProject->id,
'label' => 'Assignee',
'field_type' => 'user',
'position' => 1,
]);
$this->assertDatabaseHas('ticket_field_definitions', [
'project_id' => $coreProject->id,
'label' => 'Story Points',
'field_type' => 'number',
'position' => 2,
]);
$this->assertSame(0, $coreProject->ticketFieldDefinitions()->count());
}
/**
@@ -68,10 +55,7 @@ class TicketFieldDefinitionTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$ticket = Ticket::factory()->create([
'project_id' => $project->id,
@@ -81,7 +65,7 @@ class TicketFieldDefinitionTest extends TestCase
$fieldDefinition = TicketFieldDefinition::factory()->for($project)->create([
'field_type' => 'number',
'label' => 'Story Points',
'label' => 'Complexity',
'position' => 1,
]);
tests/Feature/Models/TicketLinkTest.php
+5 -6
View File
@@ -7,7 +7,6 @@ use App\Models\Project;
use App\Models\Ticket;
use App\Models\TicketLink;
use App\Models\TicketLinkType;
use App\Models\TicketPriority;
use Database\Seeders\ProjectSeeder;
use Database\Seeders\ProjectTicketMetadataSeeder;
use Database\Seeders\TicketLinkSeeder;
@@ -31,11 +30,11 @@ class TicketLinkTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
$priority = $project->ticketPriorities()->firstOrFail();
$taskType = $project->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail();
$firstTicket = Ticket::factory()->create([
'project_id' => $project->id,
tests/Feature/Models/TicketTest.php
+33 -17
View File
@@ -9,8 +9,8 @@ use App\Models\TicketFieldDefinition;
use App\Models\TicketFieldValue;
use App\Models\TicketLink;
use App\Models\TicketLinkType;
use App\Models\TicketPriority;
use App\Models\TicketWorklogEntry;
use App\Models\User;
use Database\Seeders\BoardColumnSeeder;
use Database\Seeders\ProjectSeeder;
use Database\Seeders\ProjectTicketMetadataSeeder;
@@ -96,10 +96,7 @@ class TicketTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$ticket = Ticket::factory()->create([
'project_id' => $project->id,
@@ -111,7 +108,7 @@ class TicketTest extends TestCase
$fieldDefinition = TicketFieldDefinition::factory()->for($project)->create([
'field_type' => 'number',
'label' => 'Story Points',
'label' => 'Complexity',
'position' => 1,
]);
@@ -139,13 +136,16 @@ class TicketTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
$parentType = $project->ticketTypes()->where('system_key', 'parent')->firstOrFail();
$taskType = $project->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail();
$parentType = $project->ticketTypes()
->where('is_parent', true)
->orderBy('position')
->firstOrFail();
$parentTicket = Ticket::factory()->create([
'project_id' => $project->id,
@@ -184,6 +184,22 @@ class TicketTest extends TestCase
$this->assertSame('Waiting for environment access.', $freshTicket->blocked_comment);
}
/**
* Ensure tickets expose their fixed assignee and author relations.
*/
public function test_ticket_assignee_and_author_relations_are_available(): void
{
$assignee = User::factory()->create();
$author = User::factory()->create();
$ticket = Ticket::factory()->create([
'assignee_user_id' => $assignee->id,
'author_user_id' => $author->id,
]);
$this->assertSame($assignee->id, $ticket->fresh()->assignee?->id);
$this->assertSame($author->id, $ticket->fresh()->author?->id);
}
/**
* Ensure tickets expose incoming and outgoing link relations.
*/
@@ -195,11 +211,11 @@ class TicketTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
$priority = $project->ticketPriorities()->firstOrFail();
$taskType = $project->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail();
$sourceTicket = Ticket::factory()->create([
'project_id' => $project->id,
tests/Feature/Models/TicketTypeTest.php
+13 -9
View File
@@ -20,14 +20,13 @@ class TicketTypeTest extends TestCase
{
$ticketType = TicketType::factory()->create();
$this->assertFalse($ticketType->is_builtin);
$this->assertNull($ticketType->system_key);
$this->assertFalse($ticketType->is_parent);
}
/**
* Ensure the metadata seeder creates the required built-in types for projects.
* Ensure the metadata seeder creates the expected starter types for projects.
*/
public function test_metadata_seeder_creates_builtin_task_and_parent_types(): void
public function test_metadata_seeder_creates_task_release_and_bug_types(): void
{
$this->seed([
ProjectSeeder::class,
@@ -39,17 +38,22 @@ class TicketTypeTest extends TestCase
$this->assertDatabaseHas('ticket_types', [
'project_id' => $coreProject->id,
'name' => 'Task',
'system_key' => 'task',
'is_builtin' => true,
'is_parent' => false,
'position' => 1,
]);
$this->assertDatabaseHas('ticket_types', [
'project_id' => $coreProject->id,
'name' => 'Parent',
'system_key' => 'parent',
'is_builtin' => true,
'name' => 'Release',
'is_parent' => true,
'position' => 2,
]);
$this->assertDatabaseHas('ticket_types', [
'project_id' => $coreProject->id,
'name' => 'Bug',
'is_parent' => false,
'position' => 3,
]);
}
}
tests/Feature/Projects/ProjectBacklogControllerTest.php
+12 -9
View File
@@ -32,10 +32,7 @@ class ProjectBacklogControllerTest extends TestCase
'position' => 1,
]);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$ticket = Ticket::factory()->create([
'project_id' => $project->id,
@@ -71,10 +68,7 @@ class ProjectBacklogControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$this->syncProjectPermissions($project, $user, ['view']);
@@ -95,6 +89,7 @@ class ProjectBacklogControllerTest extends TestCase
public function test_users_with_create_permission_can_add_duplicate_titled_tickets_to_backlog(): void
{
$user = User::factory()->create();
$assignee = User::factory()->create();
$project = Project::factory()->create([
'key' => 'AUTH',
]);
@@ -103,7 +98,7 @@ class ProjectBacklogControllerTest extends TestCase
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 1,
'position' => 2,
]);
$this->syncProjectPermissions($project, $user, ['create', 'view']);
@@ -112,6 +107,8 @@ class ProjectBacklogControllerTest extends TestCase
'title' => 'Same title',
'description' => 'Description',
'acceptance_criteria' => 'Criteria',
'assignee_user_id' => $assignee->id,
'story_points' => 3,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'ticket_priority_id' => $priority->id,
];
@@ -130,14 +127,20 @@ class ProjectBacklogControllerTest extends TestCase
'project_id' => $project->id,
'ticket_key' => 'AUTH-1',
'title' => 'Same title',
'assignee_user_id' => $assignee->id,
'author_user_id' => $user->id,
'board_column_id' => null,
'story_points' => 3,
]);
$this->assertDatabaseHas('tickets', [
'project_id' => $project->id,
'ticket_key' => 'AUTH-2',
'title' => 'Same title',
'assignee_user_id' => $assignee->id,
'author_user_id' => $user->id,
'board_column_id' => null,
'story_points' => 3,
]);
$this->assertDatabaseCount('ticket_worklog_entries', 2);
tests/Feature/Projects/ProjectBoardControllerTest.php
+5 -5
View File
@@ -39,7 +39,7 @@ class ProjectBoardControllerTest extends TestCase
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 1,
'position' => 2,
]);
Ticket::factory()->create([
@@ -99,7 +99,7 @@ class ProjectBoardControllerTest extends TestCase
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 1,
'position' => 2,
]);
$ticket = Ticket::factory()->create([
@@ -158,7 +158,7 @@ class ProjectBoardControllerTest extends TestCase
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 1,
'position' => 2,
]);
$ticket = Ticket::factory()->create([
@@ -213,7 +213,7 @@ class ProjectBoardControllerTest extends TestCase
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 1,
'position' => 2,
]);
$ticket = Ticket::factory()->create([
@@ -269,7 +269,7 @@ class ProjectBoardControllerTest extends TestCase
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 1,
'position' => 2,
]);
$ticket = Ticket::factory()->create([
tests/Feature/Projects/ProjectControllerTest.php
+9 -11
View File
@@ -7,7 +7,6 @@ use App\Models\BoardColumn;
use App\Models\Project;
use App\Models\Team;
use App\Models\Ticket;
use App\Models\TicketPriority;
use App\Models\User;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Inertia\Testing\AssertableInertia as Assert;
@@ -155,15 +154,13 @@ class ProjectControllerTest extends TestCase
$this->assertDatabaseHas('ticket_types', [
'project_id' => $project->id,
'name' => 'Task',
'system_key' => 'task',
'is_builtin' => true,
'is_parent' => false,
]);
$this->assertDatabaseHas('ticket_types', [
'project_id' => $project->id,
'name' => 'Parent',
'system_key' => 'parent',
'is_builtin' => true,
'name' => 'Release',
'is_parent' => true,
]);
}
@@ -344,10 +341,7 @@ class ProjectControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$boardColumn = BoardColumn::factory()->for($project)->create([
'name' => 'In Progress',
'position' => 1,
@@ -358,7 +352,11 @@ class ProjectControllerTest extends TestCase
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->where('system_key', 'task')->firstOrFail()->id,
'ticket_type_id' => $project->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail()
->id,
'title' => 'Delete me',
]);
tests/Feature/Projects/ProjectTicketBranchControllerTest.php
+5 -6
View File
@@ -7,7 +7,6 @@ use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
use App\Models\Project;
use App\Models\RepositoryConnection;
use App\Models\Ticket;
use App\Models\TicketPriority;
use App\Models\User;
use App\Models\UserGitConnection;
use Illuminate\Foundation\Testing\RefreshDatabase;
@@ -237,11 +236,11 @@ class ProjectTicketBranchControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
$priority = $project->ticketPriorities()->firstOrFail();
$taskType = $project->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail();
$ticket = Ticket::factory()->create([
'project_id' => $project->id,
tests/Feature/Projects/ProjectTicketControllerTest.php
+295 -161
View File
@@ -11,6 +11,7 @@ use App\Models\TicketFieldValue;
use App\Models\TicketLink;
use App\Models\TicketLinkType;
use App\Models\TicketPriority;
use App\Models\TicketType;
use App\Models\TicketWorklogEntry;
use App\Models\User;
use App\Models\UserGitConnection;
@@ -29,19 +30,23 @@ class ProjectTicketControllerTest extends TestCase
public function test_users_with_view_permission_can_view_ticket_details(): void
{
$viewer = User::factory()->create();
$author = User::factory()->create([
'name' => 'Author User',
]);
$assignee = User::factory()->create([
'name' => 'Assigned User',
]);
$project = Project::factory()->create([
'key' => 'CORE',
'show_author' => false,
]);
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$fieldDefinition = TicketFieldDefinition::factory()->for($project)->create([
'field_type' => 'number',
'label' => 'Story Points',
'label' => 'Complexity',
'position' => 1,
]);
$ticketLinkType = TicketLinkType::factory()->for($project)->create([
@@ -50,26 +55,30 @@ class ProjectTicketControllerTest extends TestCase
]);
$ticket = Ticket::factory()->create([
'assignee_user_id' => $assignee->id,
'author_user_id' => $author->id,
'project_id' => $project->id,
'sequence_number' => 1,
'story_points' => 5,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'ticket_type_id' => $this->nonParentType($project)->id,
'title' => 'Ticket detail test',
]);
$linkedTicket = Ticket::factory()->create([
'author_user_id' => $author->id,
'project_id' => $project->id,
'sequence_number' => 2,
'ticket_key' => 'CORE-2',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'ticket_type_id' => $this->nonParentType($project)->id,
'title' => 'Linked ticket',
]);
TicketFieldValue::factory()->create([
'ticket_field_definition_id' => $fieldDefinition->id,
'ticket_id' => $ticket->id,
'value_number' => 5,
'value_number' => 3,
'value_user_id' => null,
]);
TicketLink::factory()->create([
@@ -81,7 +90,7 @@ class ProjectTicketControllerTest extends TestCase
TicketWorklogEntry::factory()->create([
'actor_id' => $viewer->id,
'entry_type' => 'updated',
'summary' => 'Updated Story Points field.',
'summary' => 'Updated story points.',
'ticket_id' => $ticket->id,
]);
@@ -93,16 +102,62 @@ class ProjectTicketControllerTest extends TestCase
->assertInertia(fn (Assert $page) => $page
->component('projects/Ticket')
->where('project.id', $project->id)
->where('project.show_author', false)
->where('ticket.ticket_key', 'CORE-1')
->where('suggestedBranchName', 'core-1-ticket-detail-test')
->where('ticket.field_values.0.ticket_field_definition.label', 'Story Points')
->where('ticket.field_values.0.value_number', 5)
->where('ticket.story_points', 5)
->where('ticket.assignee.name', 'Assigned User')
->where('ticket.author', null)
->where('ticket.author_user_id', null)
->where('ticket.field_values.0.ticket_field_definition.label', 'Complexity')
->where('ticket.field_values.0.value_number', 3)
->where('ticket.worklog_entries.0.actor.name', $viewer->name)
->where('linkedTickets.0.linked_ticket.ticket_key', 'CORE-2')
->where('linkedTickets.0.ticket_link_type.label', 'Relates to')
->where('repositoryBranches', [])
->where('repositoryPullRequests', [])
->where('canEditTicket', false),
->where('canEditTicket', false)
->where('canManageProject', false),
);
}
/**
* Ensure project admins can still inspect the author when project author visibility is disabled.
*/
public function test_project_admins_can_still_view_hidden_authors(): void
{
$admin = User::factory()->create();
$author = User::factory()->create([
'name' => 'Author User',
]);
$project = Project::factory()->create([
'key' => 'CORE',
'show_author' => false,
]);
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = $project->ticketPriorities()->firstOrFail();
$ticket = Ticket::factory()->create([
'author_user_id' => $author->id,
'project_id' => $project->id,
'sequence_number' => 1,
'story_points' => 5,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $this->nonParentType($project)->id,
'title' => 'Admin author visibility',
]);
$this->syncProjectPermissions($project, $admin, ['admin', 'view']);
$this->actingAs($admin)
->get(route('projects.tickets.show', [$project, $ticket]))
->assertOk()
->assertInertia(fn (Assert $page) => $page
->component('projects/Ticket')
->where('ticket.author.name', 'Author User')
->where('ticket.author_user_id', $author->id)
->where('canManageProject', true),
);
}
@@ -160,17 +215,14 @@ class ProjectTicketControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$ticket = Ticket::factory()->create([
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'ticket_type_id' => $this->nonParentType($project)->id,
'title' => 'Branch detail test',
]);
@@ -232,45 +284,40 @@ class ProjectTicketControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$ticket = Ticket::factory()->create([
'project_id' => $project->id,
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'ticket_type_id' => $this->nonParentType($project)->id,
]);
$this->syncProjectPermissions($project, $viewer, ['view']);
$this->actingAs($viewer)
->patch(route('projects.tickets.update', [$project, $ticket]), [
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
'title' => 'Updated title',
'description' => 'Updated description',
'acceptance_criteria' => 'Updated criteria',
'blocked_comment' => $ticket->blocked_comment,
'is_blocked' => $ticket->is_blocked,
'parent_ticket_id' => $ticket->parent_ticket_id,
'ticket_type_id' => $ticket->ticket_type_id,
'ticket_priority_id' => $ticket->ticket_priority_id,
'field_values' => [],
])
]))
->assertForbidden();
}
/**
* Ensure editing tracked ticket fields creates a worklog entry and persists field values.
* Ensure editing ticket details persists fixed ticket fields and custom fields and creates a worklog entry.
*/
public function test_users_with_edit_permission_can_update_ticket_details_and_custom_fields(): void
{
$editor = User::factory()->create([
'name' => 'Editor User',
]);
$author = User::factory()->create([
'name' => 'Author User',
]);
$assignee = User::factory()->create([
'name' => 'Assigned User',
]);
$reviewer = User::factory()->create([
'name' => 'Reviewer User',
]);
$project = Project::factory()->create([
'key' => 'CORE',
]);
@@ -279,73 +326,72 @@ class ProjectTicketControllerTest extends TestCase
$lowPriority = TicketPriority::factory()->for($project)->create([
'name' => 'Low',
'position' => 1,
'position' => 2,
]);
$highPriority = TicketPriority::factory()->for($project)->create([
'name' => 'High',
'position' => 2,
'position' => 3,
]);
$assigneeField = TicketFieldDefinition::factory()->for($project)->create([
$reviewerField = TicketFieldDefinition::factory()->for($project)->create([
'field_type' => 'user',
'label' => 'Assignee',
'label' => 'Reviewer',
'position' => 1,
]);
$storyPointsField = TicketFieldDefinition::factory()->for($project)->create([
$complexityField = TicketFieldDefinition::factory()->for($project)->create([
'field_type' => 'number',
'label' => 'Story Points',
'label' => 'Complexity',
'position' => 2,
]);
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
$parentType = $project->ticketTypes()->where('system_key', 'parent')->firstOrFail();
$ticket = Ticket::factory()->create([
'acceptance_criteria' => 'Old acceptance criteria',
'author_user_id' => $author->id,
'description' => 'Old description',
'project_id' => $project->id,
'sequence_number' => 1,
'story_points' => 3,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $lowPriority->id,
'ticket_type_id' => $taskType->id,
'ticket_type_id' => $this->nonParentType($project)->id,
'title' => 'Old title',
]);
TicketFieldValue::factory()->create([
'ticket_field_definition_id' => $assigneeField->id,
'ticket_field_definition_id' => $reviewerField->id,
'ticket_id' => $ticket->id,
'value_number' => null,
'value_user_id' => $editor->id,
]);
TicketFieldValue::factory()->create([
'ticket_field_definition_id' => $storyPointsField->id,
'ticket_field_definition_id' => $complexityField->id,
'ticket_id' => $ticket->id,
'value_number' => 3,
'value_number' => 2,
'value_user_id' => null,
]);
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
$this->syncProjectPermissions($project, $editor, ['write', 'view']);
$this->actingAs($editor)
->patch(route('projects.tickets.update', [$project, $ticket]), [
'title' => 'Updated title',
'description' => 'Updated description',
'acceptance_criteria' => 'Updated acceptance criteria',
'assignee_user_id' => $assignee->id,
'blocked_comment' => $ticket->blocked_comment,
'is_blocked' => $ticket->is_blocked,
'parent_ticket_id' => $ticket->parent_ticket_id,
'ticket_type_id' => $parentType->id,
'ticket_priority_id' => $highPriority->id,
'description' => 'Updated description',
'field_values' => [
[
'ticket_field_definition_id' => $assigneeField->id,
'value_user_id' => $assignee->id,
'ticket_field_definition_id' => $reviewerField->id,
'value_user_id' => $reviewer->id,
],
[
'ticket_field_definition_id' => $storyPointsField->id,
'ticket_field_definition_id' => $complexityField->id,
'value_number' => 8,
],
],
'is_blocked' => $ticket->is_blocked,
'parent_ticket_id' => $ticket->parent_ticket_id,
'story_points' => 8,
'ticket_priority_id' => $highPriority->id,
'ticket_type_id' => $this->parentType($project)->id,
'title' => 'Updated title',
])
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
->assertSessionHas('status', 'CORE-1 was updated.');
@@ -355,27 +401,26 @@ class ProjectTicketControllerTest extends TestCase
'title' => 'Updated title',
'description' => 'Updated description',
'acceptance_criteria' => 'Updated acceptance criteria',
'ticket_type_id' => $parentType->id,
'assignee_user_id' => $assignee->id,
'story_points' => 8,
'ticket_type_id' => $this->parentType($project)->id,
'ticket_priority_id' => $highPriority->id,
]);
$this->assertDatabaseHas('ticket_field_values', [
'ticket_id' => $ticket->id,
'ticket_field_definition_id' => $assigneeField->id,
'value_user_id' => $assignee->id,
'ticket_field_definition_id' => $reviewerField->id,
'value_user_id' => $reviewer->id,
]);
$this->assertDatabaseHas('ticket_field_values', [
'ticket_id' => $ticket->id,
'ticket_field_definition_id' => $storyPointsField->id,
'ticket_field_definition_id' => $complexityField->id,
'value_number' => 8.0,
]);
$this->assertDatabaseHas('ticket_worklog_entries', [
'ticket_id' => $ticket->id,
'actor_id' => $editor->id,
'entry_type' => 'updated',
'summary' => 'Updated title, description, acceptance criteria, type, priority, Assignee field, and Story Points field.',
'summary' => 'Updated title, description, acceptance criteria, story points, type, priority, assignee, Reviewer field, and Complexity field.',
]);
}
@@ -391,12 +436,8 @@ class ProjectTicketControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
$priority = $project->ticketPriorities()->firstOrFail();
$taskType = $this->nonParentType($project);
$candidateParent = Ticket::factory()->create([
'project_id' => $project->id,
@@ -406,7 +447,6 @@ class ProjectTicketControllerTest extends TestCase
'ticket_type_id' => $taskType->id,
'title' => 'Task ticket',
]);
$childTicket = Ticket::factory()->create([
'project_id' => $project->id,
'sequence_number' => 2,
@@ -420,17 +460,9 @@ class ProjectTicketControllerTest extends TestCase
$this->actingAs($editor)
->from(route('projects.tickets.show', [$project, $childTicket]))
->patch(route('projects.tickets.update', [$project, $childTicket]), [
'title' => $childTicket->title,
'description' => $childTicket->description,
'acceptance_criteria' => $childTicket->acceptance_criteria,
'blocked_comment' => $childTicket->blocked_comment,
'is_blocked' => $childTicket->is_blocked,
->patch(route('projects.tickets.update', [$project, $childTicket]), $this->updatePayload($childTicket, [
'parent_ticket_id' => $candidateParent->id,
'ticket_type_id' => $childTicket->ticket_type_id,
'ticket_priority_id' => $childTicket->ticket_priority_id,
'field_values' => [],
])
]))
->assertRedirect(route('projects.tickets.show', [$project, $childTicket]))
->assertSessionHasErrors('parent_ticket_id');
}
@@ -447,46 +479,31 @@ class ProjectTicketControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
$parentType = $project->ticketTypes()->where('system_key', 'parent')->firstOrFail();
$priority = $project->ticketPriorities()->firstOrFail();
$parentTicket = Ticket::factory()->create([
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $parentType->id,
'ticket_type_id' => $this->parentType($project)->id,
'title' => 'Parent ticket',
]);
$childTicket = Ticket::factory()->create([
'project_id' => $project->id,
'sequence_number' => 2,
'ticket_key' => 'CORE-2',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $taskType->id,
'ticket_type_id' => $this->nonParentType($project)->id,
'title' => 'Child ticket',
]);
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
$this->actingAs($editor)
->patch(route('projects.tickets.update', [$project, $childTicket]), [
'title' => $childTicket->title,
'description' => $childTicket->description,
'acceptance_criteria' => $childTicket->acceptance_criteria,
'blocked_comment' => $childTicket->blocked_comment,
'is_blocked' => $childTicket->is_blocked,
->patch(route('projects.tickets.update', [$project, $childTicket]), $this->updatePayload($childTicket, [
'parent_ticket_id' => $parentTicket->id,
'ticket_type_id' => $childTicket->ticket_type_id,
'ticket_priority_id' => $childTicket->ticket_priority_id,
'field_values' => [],
])
]))
->assertRedirect(route('projects.tickets.show', [$project, $childTicket]))
->assertSessionHas('status', 'CORE-2 was updated.');
@@ -494,7 +511,6 @@ class ProjectTicketControllerTest extends TestCase
'id' => $childTicket->id,
'parent_ticket_id' => $parentTicket->id,
]);
$this->assertDatabaseHas('ticket_worklog_entries', [
'ticket_id' => $childTicket->id,
'actor_id' => $editor->id,
@@ -503,6 +519,46 @@ class ProjectTicketControllerTest extends TestCase
]);
}
/**
* Ensure tickets with children must remain parent-enabled.
*/
public function test_tickets_with_children_must_keep_a_parent_enabled_type(): void
{
$editor = User::factory()->create();
$project = Project::factory()->create();
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = $project->ticketPriorities()->firstOrFail();
$parentTicket = Ticket::factory()->create([
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $this->parentType($project)->id,
'title' => 'Parent ticket',
]);
Ticket::factory()->create([
'parent_ticket_id' => $parentTicket->id,
'project_id' => $project->id,
'sequence_number' => 2,
'ticket_key' => 'CORE-2',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $this->nonParentType($project)->id,
'title' => 'Child ticket',
]);
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
$this->actingAs($editor)
->from(route('projects.tickets.show', [$project, $parentTicket]))
->patch(route('projects.tickets.update', [$project, $parentTicket]), $this->updatePayload($parentTicket, [
'ticket_type_id' => $this->nonParentType($project)->id,
]))
->assertRedirect(route('projects.tickets.show', [$project, $parentTicket]))
->assertSessionHasErrors('ticket_type_id');
}
/**
* Ensure parent ticket detail pages show nested child trees.
*/
@@ -515,50 +571,41 @@ class ProjectTicketControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
$parentType = $project->ticketTypes()->where('system_key', 'parent')->firstOrFail();
$priority = $project->ticketPriorities()->firstOrFail();
$rootParent = Ticket::factory()->create([
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $parentType->id,
'ticket_type_id' => $this->parentType($project)->id,
'title' => 'Root parent',
]);
$nestedParent = Ticket::factory()->create([
'parent_ticket_id' => $rootParent->id,
'project_id' => $project->id,
'sequence_number' => 2,
'ticket_key' => 'CORE-2',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $parentType->id,
'ticket_type_id' => $this->parentType($project)->id,
'title' => 'Nested parent',
]);
$directTask = Ticket::factory()->create([
'parent_ticket_id' => $rootParent->id,
'project_id' => $project->id,
'sequence_number' => 3,
'ticket_key' => 'CORE-3',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $taskType->id,
'ticket_type_id' => $this->nonParentType($project)->id,
'title' => 'Direct task',
]);
$nestedTask = Ticket::factory()->create([
'parent_ticket_id' => $nestedParent->id,
'project_id' => $project->id,
'sequence_number' => 4,
'ticket_key' => 'CORE-4',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $taskType->id,
'ticket_type_id' => $this->nonParentType($project)->id,
'title' => 'Nested task',
]);
@@ -585,31 +632,21 @@ class ProjectTicketControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$ticket = Ticket::factory()->create([
'project_id' => $project->id,
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'ticket_type_id' => $this->nonParentType($project)->id,
]);
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
$this->actingAs($editor)
->from(route('projects.tickets.show', [$project, $ticket]))
->patch(route('projects.tickets.update', [$project, $ticket]), [
'title' => $ticket->title,
'description' => $ticket->description,
'acceptance_criteria' => $ticket->acceptance_criteria,
'ticket_type_id' => $ticket->ticket_type_id,
'ticket_priority_id' => $ticket->ticket_priority_id,
'parent_ticket_id' => $ticket->parent_ticket_id,
'is_blocked' => true,
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
'blocked_comment' => '',
'field_values' => [],
])
'is_blocked' => true,
]))
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
->assertSessionHasErrors('blocked_comment');
@@ -632,32 +669,22 @@ class ProjectTicketControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$priority = $project->ticketPriorities()->firstOrFail();
$ticket = Ticket::factory()->create([
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $project->ticketTypes()->firstOrFail()->id,
'ticket_type_id' => $this->nonParentType($project)->id,
]);
$this->syncProjectPermissions($project, $editor, ['edit', 'view']);
$this->actingAs($editor)
->patch(route('projects.tickets.update', [$project, $ticket]), [
'title' => $ticket->title,
'description' => $ticket->description,
'acceptance_criteria' => $ticket->acceptance_criteria,
'ticket_type_id' => $ticket->ticket_type_id,
'ticket_priority_id' => $ticket->ticket_priority_id,
'parent_ticket_id' => $ticket->parent_ticket_id,
'is_blocked' => true,
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
'blocked_comment' => 'Waiting for dependency approval.',
'field_values' => [],
])
'is_blocked' => true,
]))
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
->assertSessionHas('status', 'CORE-1 was updated.');
@@ -666,7 +693,6 @@ class ProjectTicketControllerTest extends TestCase
'is_blocked' => true,
'blocked_comment' => 'Waiting for dependency approval.',
]);
$this->assertDatabaseHas('ticket_worklog_entries', [
'ticket_id' => $ticket->id,
'actor_id' => $editor->id,
@@ -675,17 +701,10 @@ class ProjectTicketControllerTest extends TestCase
]);
$this->actingAs($editor)
->patch(route('projects.tickets.update', [$project, $ticket]), [
'title' => $ticket->title,
'description' => $ticket->description,
'acceptance_criteria' => $ticket->acceptance_criteria,
'ticket_type_id' => $ticket->ticket_type_id,
'ticket_priority_id' => $ticket->ticket_priority_id,
'parent_ticket_id' => $ticket->parent_ticket_id,
'is_blocked' => false,
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
'blocked_comment' => '',
'field_values' => [],
])
'is_blocked' => false,
]))
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
->assertSessionHas('status', 'CORE-1 was updated.');
@@ -694,7 +713,6 @@ class ProjectTicketControllerTest extends TestCase
'is_blocked' => false,
'blocked_comment' => null,
]);
$this->assertSame(
2,
TicketWorklogEntry::query()
@@ -704,4 +722,120 @@ class ProjectTicketControllerTest extends TestCase
->count(),
);
}
/**
* Ensure non-admin users cannot change the fixed author.
*/
public function test_non_admin_users_cannot_change_the_ticket_author(): void
{
$editor = User::factory()->create();
$originalAuthor = User::factory()->create();
$replacementAuthor = User::factory()->create();
$project = Project::factory()->create();
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = $project->ticketPriorities()->firstOrFail();
$ticket = Ticket::factory()->create([
'author_user_id' => $originalAuthor->id,
'project_id' => $project->id,
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $this->nonParentType($project)->id,
]);
$this->syncProjectPermissions($project, $editor, ['write', 'view']);
$this->actingAs($editor)
->from(route('projects.tickets.show', [$project, $ticket]))
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
'author_user_id' => $replacementAuthor->id,
]))
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
->assertSessionHasErrors('author_user_id');
$this->assertDatabaseHas('tickets', [
'id' => $ticket->id,
'author_user_id' => $originalAuthor->id,
]);
}
/**
* Ensure project admins can change the fixed author.
*/
public function test_project_admins_can_change_the_ticket_author(): void
{
$admin = User::factory()->create();
$originalAuthor = User::factory()->create();
$replacementAuthor = User::factory()->create([
'name' => 'Replacement Author',
]);
$project = Project::factory()->create();
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = $project->ticketPriorities()->firstOrFail();
$ticket = Ticket::factory()->create([
'author_user_id' => $originalAuthor->id,
'project_id' => $project->id,
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $this->nonParentType($project)->id,
]);
$this->syncProjectPermissions($project, $admin, ['admin', 'view']);
$this->actingAs($admin)
->patch(route('projects.tickets.update', [$project, $ticket]), $this->updatePayload($ticket, [
'author_user_id' => $replacementAuthor->id,
]))
->assertRedirect(route('projects.tickets.show', [$project, $ticket]))
->assertSessionHas('status', "{$ticket->ticket_key} was updated.");
$this->assertDatabaseHas('tickets', [
'id' => $ticket->id,
'author_user_id' => $replacementAuthor->id,
]);
$this->assertDatabaseHas('ticket_worklog_entries', [
'ticket_id' => $ticket->id,
'actor_id' => $admin->id,
'entry_type' => 'updated',
'summary' => 'Updated author.',
]);
}
private function nonParentType(Project $project): TicketType
{
return $project->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail();
}
private function parentType(Project $project): TicketType
{
return $project->ticketTypes()
->where('is_parent', true)
->orderBy('position')
->firstOrFail();
}
/**
* @return array<string, mixed>
*/
private function updatePayload(Ticket $ticket, array $overrides = []): array
{
return array_merge([
'acceptance_criteria' => $ticket->acceptance_criteria,
'assignee_user_id' => $ticket->assignee_user_id,
'author_user_id' => $ticket->author_user_id,
'blocked_comment' => $ticket->blocked_comment,
'description' => $ticket->description,
'field_values' => [],
'is_blocked' => $ticket->is_blocked,
'parent_ticket_id' => $ticket->parent_ticket_id,
'story_points' => $ticket->story_points,
'ticket_priority_id' => $ticket->ticket_priority_id,
'ticket_type_id' => $ticket->ticket_type_id,
'title' => $ticket->title,
], $overrides);
}
}
tests/Feature/Projects/ProjectTicketLinkControllerTest.php
+20 -21
View File
@@ -7,7 +7,6 @@ use App\Models\Project;
use App\Models\Ticket;
use App\Models\TicketLink;
use App\Models\TicketLinkType;
use App\Models\TicketPriority;
use App\Models\User;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
@@ -28,11 +27,11 @@ class ProjectTicketLinkControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
$priority = $project->ticketPriorities()->firstOrFail();
$taskType = $project->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail();
$ticketLinkType = TicketLinkType::factory()->for($project)->create([
'label' => 'Relates to',
'position' => 1,
@@ -88,16 +87,16 @@ class ProjectTicketLinkControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
app(InitializeProjectTicketMetadata::class)->handle($otherProject);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$otherPriority = TicketPriority::factory()->for($otherProject)->create([
'name' => 'Medium',
'position' => 1,
]);
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
$otherTaskType = $otherProject->ticketTypes()->where('system_key', 'task')->firstOrFail();
$priority = $project->ticketPriorities()->firstOrFail();
$otherPriority = $otherProject->ticketPriorities()->firstOrFail();
$taskType = $project->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail();
$otherTaskType = $otherProject->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail();
$ticketLinkType = TicketLinkType::factory()->for($project)->create([
'label' => 'Relates to',
'position' => 1,
@@ -150,11 +149,11 @@ class ProjectTicketLinkControllerTest extends TestCase
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = TicketPriority::factory()->for($project)->create([
'name' => 'Medium',
'position' => 1,
]);
$taskType = $project->ticketTypes()->where('system_key', 'task')->firstOrFail();
$priority = $project->ticketPriorities()->firstOrFail();
$taskType = $project->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail();
$ticketLinkType = TicketLinkType::factory()->for($project)->create([
'label' => 'Relates to',
'position' => 1,
tests/Feature/Projects/ProjectTicketMetadataSettingsControllerTest.php
+231 -34
View File
@@ -2,7 +2,9 @@
namespace Tests\Feature\Projects;
use App\Actions\ProjectTicketMetadata\InitializeProjectTicketMetadata;
use App\Models\Project;
use App\Models\Ticket;
use App\Models\TicketFieldDefinition;
use App\Models\TicketLinkType;
use App\Models\TicketPriority;
@@ -23,6 +25,9 @@ class ProjectTicketMetadataSettingsControllerTest extends TestCase
{
$user = User::factory()->create();
$project = Project::factory()->create();
app(InitializeProjectTicketMetadata::class)->handle($project);
TicketType::factory()->for($project)->create([
'name' => 'Bug',
'position' => 3,
@@ -39,8 +44,11 @@ class ProjectTicketMetadataSettingsControllerTest extends TestCase
->assertOk()
->assertInertia(fn (Assert $page) => $page
->component('projects/settings/Metadata')
->where('project.show_author', true)
->where('project.show_story_points', true)
->where('ticketTypes.0.name', 'Task')
->where('ticketTypes.1.name', 'Parent')
->where('ticketTypes.1.name', 'Release')
->where('ticketTypes.1.is_parent', true)
->where('ticketTypes.2.name', 'Bug')
->where('ticketLinkTypes.0.label', 'Relates to'),
);
@@ -58,6 +66,7 @@ class ProjectTicketMetadataSettingsControllerTest extends TestCase
$this->actingAs($user)
->post(route('projects.settings.metadata.types.store', $project), [
'is_parent' => '1',
'name' => 'Bug',
])
->assertRedirect(route('projects.settings.metadata', $project))
@@ -66,57 +75,245 @@ class ProjectTicketMetadataSettingsControllerTest extends TestCase
$this->assertDatabaseHas('ticket_types', [
'project_id' => $project->id,
'name' => 'Bug',
'is_builtin' => false,
'system_key' => null,
'is_parent' => true,
]);
}
/**
* Ensure built-in ticket types can be renamed but not deleted.
* Ensure type parent flags cannot be changed after creation.
*/
public function test_builtin_ticket_types_can_be_renamed_but_not_deleted(): void
public function test_ticket_type_parent_flags_cannot_be_changed_after_creation(): void
{
$user = User::factory()->create();
$project = Project::factory()->create();
app(InitializeProjectTicketMetadata::class)->handle($project);
$releaseType = $project->ticketTypes()
->where('is_parent', true)
->orderBy('position')
->firstOrFail();
$this->syncProjectPermissions($project, $user, ['edit']);
$taskType = TicketType::query()
->where('project_id', $project->id)
->where('system_key', 'task')
->first();
if ($taskType === null) {
$this->actingAs($user)
->get(route('projects.settings.metadata', $project))
->assertOk();
$taskType = TicketType::query()
->where('project_id', $project->id)
->where('system_key', 'task')
->firstOrFail();
}
$this->actingAs($user)
->patch(route('projects.settings.metadata.types.update', [$project, $taskType]), [
'name' => 'Standard Task',
'position' => 1,
->patch(route('projects.settings.metadata.types.update', [$project, $releaseType]), [
'is_parent' => '0',
'name' => 'Standard Release',
'position' => 2,
])
->assertRedirect(route('projects.settings.metadata', $project))
->assertSessionHas('status', 'Standard Task type was updated.');
->assertSessionHas('status', 'Standard Release type was updated.');
$this->assertDatabaseHas('ticket_types', [
'id' => $taskType->id,
'name' => 'Standard Task',
'system_key' => 'task',
'is_builtin' => true,
'id' => $releaseType->id,
'name' => 'Standard Release',
'is_parent' => true,
]);
}
/**
* Ensure users with edit permission can update project ticket visibility settings.
*/
public function test_users_with_edit_permission_can_update_ticket_visibility_settings(): void
{
$user = User::factory()->create();
$project = Project::factory()->create([
'show_author' => true,
'show_story_points' => true,
]);
$this->syncProjectPermissions($project, $user, ['edit']);
$this->actingAs($user)
->delete(route('projects.settings.metadata.types.destroy', [$project, $taskType]))
->patch(route('projects.settings.metadata.update', $project), [
'show_author' => false,
'show_story_points' => false,
])
->assertRedirect(route('projects.settings.metadata', $project))
->assertSessionHas('status', 'Settings have been updated.');
$this->assertDatabaseHas('projects', [
'id' => $project->id,
'show_author' => false,
'show_story_points' => false,
]);
}
/**
* Ensure users without project admin permission cannot update ticket metadata settings.
*/
public function test_non_admin_users_cannot_update_ticket_metadata_settings(): void
{
$user = User::factory()->create();
$project = Project::factory()->create();
$this->syncProjectPermissions($project, $user, ['view']);
$this->actingAs($user)
->patch(route('projects.settings.metadata.update', $project), [
'show_author' => false,
'show_story_points' => false,
])
->assertForbidden();
}
/**
* Ensure the last remaining ticket type cannot be deleted.
*/
public function test_the_last_remaining_ticket_type_cannot_be_deleted(): void
{
$user = User::factory()->create();
$project = Project::factory()->create();
$ticketType = TicketType::factory()->for($project)->create([
'name' => 'Solo',
'position' => 1,
]);
$this->syncProjectPermissions($project, $user, ['edit']);
$this->actingAs($user)
->delete(route('projects.settings.metadata.types.destroy', [$project, $ticketType]))
->assertRedirect(route('projects.settings.metadata', $project))
->assertSessionHas('status', 'The last ticket type cannot be deleted.');
$this->assertDatabaseHas('ticket_types', [
'id' => $ticketType->id,
]);
}
/**
* Ensure deleting a used ticket type requires a replacement and reassigns affected tickets.
*/
public function test_used_ticket_types_require_replacement_before_deletion_and_reassign_tickets(): void
{
$user = User::factory()->create();
$author = User::factory()->create();
$project = Project::factory()->create([
'key' => 'CORE',
]);
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = $project->ticketPriorities()->firstOrFail();
$taskType = $project->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail();
$releaseType = $project->ticketTypes()
->where('is_parent', true)
->orderBy('position')
->firstOrFail();
$ticket = Ticket::factory()->create([
'author_user_id' => $author->id,
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $taskType->id,
'title' => 'Replace my type',
]);
$this->syncProjectPermissions($project, $user, ['edit']);
$this->actingAs($user)
->from(route('projects.settings.metadata', $project))
->delete(route('projects.settings.metadata.types.destroy', [$project, $taskType]))
->assertRedirect(route('projects.settings.metadata', $project))
->assertSessionHasErrors('replacement_ticket_type_id');
$this->actingAs($user)
->delete(route('projects.settings.metadata.types.destroy', [$project, $taskType]), [
'replacement_ticket_type_id' => $releaseType->id,
])
->assertRedirect(route('projects.settings.metadata', $project))
->assertSessionHas('status', 'Task type was removed.');
$this->assertDatabaseMissing('ticket_types', [
'id' => $taskType->id,
]);
$this->assertDatabaseHas('tickets', [
'id' => $ticket->id,
'ticket_type_id' => $releaseType->id,
]);
$this->assertDatabaseHas('ticket_worklog_entries', [
'ticket_id' => $ticket->id,
'actor_id' => $user->id,
'entry_type' => 'updated',
'summary' => 'Updated type because Task type was deleted.',
]);
}
/**
* Ensure parent tickets cannot be reassigned to a non-parent replacement type during delete.
*/
public function test_parent_tickets_require_a_parent_enabled_replacement_type_when_deleting_types(): void
{
$user = User::factory()->create();
$author = User::factory()->create();
$project = Project::factory()->create([
'key' => 'CORE',
]);
app(InitializeProjectTicketMetadata::class)->handle($project);
$priority = $project->ticketPriorities()->firstOrFail();
$taskType = $project->ticketTypes()
->where('is_parent', false)
->orderBy('position')
->firstOrFail();
$releaseType = $project->ticketTypes()
->where('is_parent', true)
->orderBy('position')
->firstOrFail();
$epicType = TicketType::factory()->for($project)->create([
'is_parent' => true,
'name' => 'Epic',
'position' => 3,
]);
$parentTicket = Ticket::factory()->create([
'author_user_id' => $author->id,
'project_id' => $project->id,
'sequence_number' => 1,
'ticket_key' => 'CORE-1',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $releaseType->id,
'title' => 'Parent ticket',
]);
Ticket::factory()->create([
'author_user_id' => $author->id,
'parent_ticket_id' => $parentTicket->id,
'project_id' => $project->id,
'sequence_number' => 2,
'ticket_key' => 'CORE-2',
'ticket_priority_id' => $priority->id,
'ticket_type_id' => $taskType->id,
'title' => 'Child ticket',
]);
$this->syncProjectPermissions($project, $user, ['edit']);
$this->actingAs($user)
->from(route('projects.settings.metadata', $project))
->delete(route('projects.settings.metadata.types.destroy', [$project, $releaseType]), [
'replacement_ticket_type_id' => $taskType->id,
])
->assertRedirect(route('projects.settings.metadata', $project))
->assertSessionHasErrors('replacement_ticket_type_id');
$this->actingAs($user)
->delete(route('projects.settings.metadata.types.destroy', [$project, $releaseType]), [
'replacement_ticket_type_id' => $epicType->id,
])
->assertRedirect(route('projects.settings.metadata', $project))
->assertSessionHas('status', 'Release type was removed.');
$this->assertDatabaseHas('tickets', [
'id' => $parentTicket->id,
'ticket_type_id' => $epicType->id,
]);
}
/**
* Ensure priorities can be created, updated, and deleted.
*/
@@ -163,7 +360,7 @@ class ProjectTicketMetadataSettingsControllerTest extends TestCase
$user = User::factory()->create();
$project = Project::factory()->create();
$fieldDefinition = TicketFieldDefinition::factory()->for($project)->create([
'label' => 'Story Points',
'label' => 'Complexity',
'field_type' => 'number',
'position' => 1,
]);
@@ -180,16 +377,16 @@ class ProjectTicketMetadataSettingsControllerTest extends TestCase
$this->actingAs($user)
->patch(route('projects.settings.metadata.fields.update', [$project, $fieldDefinition]), [
'label' => 'Estimated Points',
'label' => 'Risk score',
'field_type' => 'number',
'position' => 2,
])
->assertRedirect(route('projects.settings.metadata', $project))
->assertSessionHas('status', 'Estimated Points field was updated.');
->assertSessionHas('status', 'Risk score field was updated.');
$this->assertDatabaseHas('ticket_field_definitions', [
'id' => $fieldDefinition->id,
'label' => 'Estimated Points',
'label' => 'Risk score',
'field_type' => 'number',
]);
}